From e4573f8b52465545d52fb614be1ea1dbe27f9856 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Tue, 13 Dec 2022 12:20:29 +0000 Subject: [PATCH] feat: remove 0 case and show all "do you know details" questions regardless of previous answers --- app/models/form/sales/pages/person1_known.rb | 1 - app/models/form/sales/pages/person2_known.rb | 6 +++--- app/models/form/sales/pages/person3_known.rb | 4 ++-- app/models/form/sales/pages/person4_known.rb | 2 +- app/views/form/headers/_person_1_known_page.erb | 1 - 5 files changed, 6 insertions(+), 8 deletions(-) delete mode 100644 app/views/form/headers/_person_1_known_page.erb diff --git a/app/models/form/sales/pages/person1_known.rb b/app/models/form/sales/pages/person1_known.rb index 315dc5f02..439fb520a 100644 --- a/app/models/form/sales/pages/person1_known.rb +++ b/app/models/form/sales/pages/person1_known.rb @@ -2,7 +2,6 @@ class Form::Sales::Pages::Person1Known < ::Form::Page def initialize(id, hsh, subsection) super @id = "person_1_known" - @header_partial = "person_1_known_page" @header = "" @description = "" @subsection = subsection diff --git a/app/models/form/sales/pages/person2_known.rb b/app/models/form/sales/pages/person2_known.rb index eb29c1cfd..c1eeebf20 100644 --- a/app/models/form/sales/pages/person2_known.rb +++ b/app/models/form/sales/pages/person2_known.rb @@ -7,9 +7,9 @@ class Form::Sales::Pages::Person2Known < ::Form::Page @description = "" @subsection = subsection @depends_on = [ - { "hholdcount" => 2, "details_known_1" => 1 }, - { "hholdcount" => 3, "details_known_1" => 1 }, - { "hholdcount" => 4, "details_known_1" => 1 }, + { "hholdcount" => 2 }, + { "hholdcount" => 3 }, + { "hholdcount" => 4 }, ] end diff --git a/app/models/form/sales/pages/person3_known.rb b/app/models/form/sales/pages/person3_known.rb index 7671a0de4..60b344034 100644 --- a/app/models/form/sales/pages/person3_known.rb +++ b/app/models/form/sales/pages/person3_known.rb @@ -7,8 +7,8 @@ class Form::Sales::Pages::Person3Known < ::Form::Page @description = "" @subsection = subsection @depends_on = [ - { "hholdcount" => 3, "details_known_2" => 1 }, - { "hholdcount" => 4, "details_known_2" => 1 }, + { "hholdcount" => 3 }, + { "hholdcount" => 4 }, ] end diff --git a/app/models/form/sales/pages/person4_known.rb b/app/models/form/sales/pages/person4_known.rb index c6c0208ea..b07ef6356 100644 --- a/app/models/form/sales/pages/person4_known.rb +++ b/app/models/form/sales/pages/person4_known.rb @@ -7,7 +7,7 @@ class Form::Sales::Pages::Person4Known < ::Form::Page @description = "" @subsection = subsection @depends_on = [ - { "hholdcount" => 4, "details_known_3" => 1 }, + { "hholdcount" => 4 }, ] end diff --git a/app/views/form/headers/_person_1_known_page.erb b/app/views/form/headers/_person_1_known_page.erb deleted file mode 100644 index b179fcdb8..000000000 --- a/app/views/form/headers/_person_1_known_page.erb +++ /dev/null @@ -1 +0,0 @@ -You have given us the details for 0 of the <%= log.hholdcount %> other people in the household