From e79ed6e8ed4711297f5d46b28e760a18ab6f1a85 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 23 Apr 2025 14:39:03 +0100
Subject: [PATCH] Update logging level in InvalidLogsHelper from debug to info
 for better visibility

---
 app/helpers/invalid_logs_helper.rb | 10 +++++-----
 lib/tasks/invalid_logs.rake        | 11 +++--------
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/app/helpers/invalid_logs_helper.rb b/app/helpers/invalid_logs_helper.rb
index 56d5481ee..00e8cb786 100644
--- a/app/helpers/invalid_logs_helper.rb
+++ b/app/helpers/invalid_logs_helper.rb
@@ -1,19 +1,19 @@
 module InvalidLogsHelper
   def count_and_display_invalid_logs(model, log_type, year)
     invalid_logs = fetch_invalid_logs(model, year)
-    Rails.logger.debug "Number of invalid #{log_type} for year #{year}: #{invalid_logs.size}"
-    Rails.logger.debug "Invalid #{log_type} IDs: #{invalid_logs.map(&:id).join(', ')}"
+    Rails.logger.info "Number of invalid #{log_type} for year #{year}: #{invalid_logs.size}"
+    Rails.logger.info "Invalid #{log_type} IDs: #{invalid_logs.map(&:id).join(', ')}"
   end
 
   def surface_invalid_logs(model, log_type, year)
     invalid_logs = fetch_invalid_logs(model, year)
     if invalid_logs.any?
       invalid_logs.each do |log|
-        Rails.logger.debug "#{log_type} ID: #{log.id}"
-        log.errors.full_messages.each { |message| Rails.logger.debug "  - #{message}" }
+        Rails.logger.info "#{log_type} ID: #{log.id}"
+        log.errors.full_messages.each { |message| Rails.logger.info "  - #{message}" }
       end
     else
-      Rails.logger.debug "No invalid #{log_type} found for year #{year}."
+      Rails.logger.info "No invalid #{log_type} found for year #{year}."
     end
   end
 
diff --git a/lib/tasks/invalid_logs.rake b/lib/tasks/invalid_logs.rake
index a132c17fa..3a5a4cd69 100644
--- a/lib/tasks/invalid_logs.rake
+++ b/lib/tasks/invalid_logs.rake
@@ -1,11 +1,9 @@
-require "helpers/invalid_logs_helper"
-
 namespace :logs do
+  include CollectionTimeHelper
+  include InvalidLogsHelper
+
   desc "Count the number of invalid LettingsLog and SalesLog for a given year"
   task :count_invalid, [:year] => :environment do |_task, args|
-    include CollectionTimeHelper
-    include InvalidLogsHelper
-
     year = args[:year] || current_collection_year
     count_and_display_invalid_logs(LettingsLog, "LettingsLog", year)
     count_and_display_invalid_logs(SalesLog, "SalesLog", year)
@@ -13,9 +11,6 @@ namespace :logs do
 
   desc "Surface all invalid logs and output their error messages for a given year"
   task :surface_invalid, [:year] => :environment do |_task, args|
-    include CollectionTimeHelper
-    include InvalidLogsHelper
-
     year = args[:year] || current_collection_year
     surface_invalid_logs(LettingsLog, "LettingsLog", year)
     surface_invalid_logs(SalesLog, "SalesLog", year)