From f1f7eb257d9418516ff3174f94d9817daab58be2 Mon Sep 17 00:00:00 2001
From: JG <moarpheus@gmail.com>
Date: Sat, 28 May 2022 12:32:04 +0100
Subject: [PATCH] refactoring

---
 app/controllers/case_logs_controller.rb     |  6 +++---
 app/controllers/organisations_controller.rb | 11 ++++-------
 spec/requests/case_logs_controller_spec.rb  | 13 +++----------
 3 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/app/controllers/case_logs_controller.rb b/app/controllers/case_logs_controller.rb
index 9677e582f..2178355c7 100644
--- a/app/controllers/case_logs_controller.rb
+++ b/app/controllers/case_logs_controller.rb
@@ -13,9 +13,9 @@ class CaseLogsController < ApplicationController
 
     all_logs = current_user.case_logs
 
-    unpaginated_logs = filtered_case_logs(filtered_collection(all_logs, search_term))
+    unpaginated_filtered_logs = filtered_case_logs(filtered_collection(all_logs, search_term))
 
-    @pagy, @case_logs = pagy(unpaginated_logs)
+    @pagy, @case_logs = pagy(unpaginated_filtered_logs)
 
     @searched = search_term.presence
     @total_count = all_logs.size
@@ -23,7 +23,7 @@ class CaseLogsController < ApplicationController
     respond_to do |format|
       format.html
       format.csv do
-        send_data unpaginated_logs.to_csv, filename: "logs-#{Time.zone.now}.csv"
+        send_data unpaginated_filtered_logs.to_csv, filename: "logs-#{Time.zone.now}.csv"
       end
     end
   end
diff --git a/app/controllers/organisations_controller.rb b/app/controllers/organisations_controller.rb
index ad195b624..c10c18dbe 100644
--- a/app/controllers/organisations_controller.rb
+++ b/app/controllers/organisations_controller.rb
@@ -56,13 +56,10 @@ class OrganisationsController < ApplicationController
 
       organisation_logs = CaseLog.all.where(owning_organisation_id: @organisation.id)
 
-      @pagy, @case_logs = pagy(
-        filtered_case_logs(
-          filtered_collection(
-            organisation_logs, search_term
-          ),
-        ),
-      )
+      unpaginated_filtered_logs = filtered_case_logs(filtered_collection(organisation_logs, search_term))
+
+      @pagy, @case_logs = pagy(unpaginated_filtered_logs)
+
       @searched = search_term.presence
       @total_count = organisation_logs.size
 
diff --git a/spec/requests/case_logs_controller_spec.rb b/spec/requests/case_logs_controller_spec.rb
index 8c8bc2ac2..a59ca39a3 100644
--- a/spec/requests/case_logs_controller_spec.rb
+++ b/spec/requests/case_logs_controller_spec.rb
@@ -761,20 +761,13 @@ RSpec.describe CaseLogsController, type: :request do
       end
 
       context "when both filter and search applied" do
+        let(:postcode) { "XX1 1TG" }
         let!(:case_log) do
-          FactoryBot.create(
-            :case_log,
-            :completed,
-            postcode_full: "XX1 1TG",
-            owning_organisation: organisation,
-          )
+          FactoryBot.create(:case_log, :completed, postcode_full: postcode, owning_organisation: organisation)
         end
 
         before do
-          FactoryBot.create(:case_log,
-                            :in_progress,
-                            postcode_full: case_log.postcode_full,
-                            owning_organisation: organisation)
+          FactoryBot.create(:case_log, :in_progress, postcode_full: postcode, owning_organisation: organisation)
         end
 
         it "dowloads logs matching both csv and filter logs" do