Browse Source
* Add discounted_sale_value_check to sales * Add DiscountedSaleValueCheck pages and questions * Add value check to the form * Only run validate_discounted_ownership_value as a hard validation on and after 24/25 * Rebase fix * Fix form spec * Update discounted_ownership_value_invalid? * update validation * Update soft validation content * PR comments * typo * lint * Default discounted_sale_value_check on importpull/1449/head
kosiakkatrina
2 years ago
committed by
GitHub
20 changed files with 450 additions and 104 deletions
@ -0,0 +1,26 @@ |
|||||||
|
class Form::Sales::Pages::DiscountedSaleValueCheck < ::Form::Page |
||||||
|
def initialize(id, hsh, subsection, person_index = nil) |
||||||
|
super(id, hsh, subsection) |
||||||
|
@depends_on = depends_on |
||||||
|
@title_text = { |
||||||
|
"translation" => "soft_validations.discounted_sale_value.title_text", |
||||||
|
"arguments" => [{ "key" => "value_with_discount", "label" => false, "i18n_template" => "value_with_discount" }], |
||||||
|
} |
||||||
|
@informative_text = { |
||||||
|
"translation" => "soft_validations.discounted_sale_value.informative_text", |
||||||
|
"arguments" => [{ "key" => "mortgage_deposit_and_grant_total", "label" => false, "i18n_template" => "mortgage_deposit_and_grant_total" }], |
||||||
|
} |
||||||
|
@person_index = person_index |
||||||
|
@depends_on = [ |
||||||
|
{ |
||||||
|
"discounted_ownership_value_invalid?" => true, |
||||||
|
}, |
||||||
|
] |
||||||
|
end |
||||||
|
|
||||||
|
def questions |
||||||
|
@questions ||= [ |
||||||
|
Form::Sales::Questions::DiscountedSaleValueCheck.new(nil, nil, self), |
||||||
|
] |
||||||
|
end |
||||||
|
end |
@ -0,0 +1,23 @@ |
|||||||
|
class Form::Sales::Questions::DiscountedSaleValueCheck < ::Form::Question |
||||||
|
def initialize(id, hsh, page) |
||||||
|
super |
||||||
|
@id = "discounted_sale_value_check" |
||||||
|
@check_answer_label = "Discounted sale value confirmation" |
||||||
|
@header = "Are you sure this is correct?" |
||||||
|
@type = "interruption_screen" |
||||||
|
@answer_options = { |
||||||
|
"0" => { "value" => "Yes" }, |
||||||
|
"1" => { "value" => "No" }, |
||||||
|
} |
||||||
|
@hidden_in_check_answers = { |
||||||
|
"depends_on" => [ |
||||||
|
{ |
||||||
|
"discounted_sale_value_check" => 0, |
||||||
|
}, |
||||||
|
{ |
||||||
|
"discounted_sale_value_check" => 1, |
||||||
|
}, |
||||||
|
], |
||||||
|
} |
||||||
|
end |
||||||
|
end |
@ -0,0 +1,5 @@ |
|||||||
|
class AddDiscountedSaleValueCheck < ActiveRecord::Migration[7.0] |
||||||
|
def change |
||||||
|
add_column :sales_logs, :discounted_sale_value_check, :integer |
||||||
|
end |
||||||
|
end |
@ -0,0 +1,52 @@ |
|||||||
|
require "rails_helper" |
||||||
|
|
||||||
|
RSpec.describe Form::Sales::Pages::DiscountedSaleValueCheck, type: :model do |
||||||
|
subject(:page) { described_class.new(page_id, page_definition, subsection, index) } |
||||||
|
|
||||||
|
let(:page_id) { "discounted_sale_value_check" } |
||||||
|
let(:page_definition) { nil } |
||||||
|
let(:index) { 1 } |
||||||
|
let(:subsection) { instance_double(Form::Subsection) } |
||||||
|
|
||||||
|
it "has correct subsection" do |
||||||
|
expect(page.subsection).to eq(subsection) |
||||||
|
end |
||||||
|
|
||||||
|
it "has correct questions" do |
||||||
|
expect(page.questions.map(&:id)).to eq(%w[discounted_sale_value_check]) |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct id" do |
||||||
|
expect(page.id).to eq("discounted_sale_value_check") |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct header" do |
||||||
|
expect(page.header).to be_nil |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct title_text" do |
||||||
|
expect(page.title_text).to eq({ |
||||||
|
"translation" => "soft_validations.discounted_sale_value.title_text", |
||||||
|
"arguments" => [{ "key" => "value_with_discount", "label" => false, "i18n_template" => "value_with_discount" }], |
||||||
|
}) |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct informative_text" do |
||||||
|
expect(page.informative_text).to eq({ |
||||||
|
"translation" => "soft_validations.discounted_sale_value.informative_text", |
||||||
|
"arguments" => [{ "key" => "mortgage_deposit_and_grant_total", "label" => false, "i18n_template" => "mortgage_deposit_and_grant_total" }], |
||||||
|
}) |
||||||
|
end |
||||||
|
|
||||||
|
it "is interruption screen page" do |
||||||
|
expect(page.interruption_screen?).to eq(true) |
||||||
|
end |
||||||
|
|
||||||
|
it "has correct depends_on" do |
||||||
|
expect(page.depends_on).to eq([ |
||||||
|
{ |
||||||
|
"discounted_ownership_value_invalid?" => true, |
||||||
|
}, |
||||||
|
]) |
||||||
|
end |
||||||
|
end |
@ -0,0 +1,57 @@ |
|||||||
|
require "rails_helper" |
||||||
|
|
||||||
|
RSpec.describe Form::Sales::Questions::DiscountedSaleValueCheck, type: :model do |
||||||
|
subject(:question) { described_class.new(question_id, question_definition, page) } |
||||||
|
|
||||||
|
let(:question_id) { nil } |
||||||
|
let(:question_definition) { nil } |
||||||
|
let(:page) { instance_double(Form::Page) } |
||||||
|
|
||||||
|
it "has correct page" do |
||||||
|
expect(question.page).to eq(page) |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct id" do |
||||||
|
expect(question.id).to eq("discounted_sale_value_check") |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct header" do |
||||||
|
expect(question.header).to eq("Are you sure this is correct?") |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct check_answer_label" do |
||||||
|
expect(question.check_answer_label).to eq("Discounted sale value confirmation") |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct type" do |
||||||
|
expect(question.type).to eq("interruption_screen") |
||||||
|
end |
||||||
|
|
||||||
|
it "is not marked as derived" do |
||||||
|
expect(question.derived?).to be false |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct hint" do |
||||||
|
expect(question.hint_text).to be_nil |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct answer_options" do |
||||||
|
expect(question.answer_options).to eq({ |
||||||
|
"0" => { "value" => "Yes" }, |
||||||
|
"1" => { "value" => "No" }, |
||||||
|
}) |
||||||
|
end |
||||||
|
|
||||||
|
it "has the correct hidden_in_check_answers" do |
||||||
|
expect(question.hidden_in_check_answers).to eq({ |
||||||
|
"depends_on" => [ |
||||||
|
{ |
||||||
|
"discounted_sale_value_check" => 0, |
||||||
|
}, |
||||||
|
{ |
||||||
|
"discounted_sale_value_check" => 1, |
||||||
|
}, |
||||||
|
], |
||||||
|
}) |
||||||
|
end |
||||||
|
end |
Loading…
Reference in new issue