From f5e573b51a48be1e37d655d7356031f5278eb174 Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Wed, 10 Nov 2021 15:54:51 +0000 Subject: [PATCH] Conventional routes are easier to reason about than constraints --- app/views/form/page.html.erb | 2 +- config/routes.rb | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/views/form/page.html.erb b/app/views/form/page.html.erb index 188b16cda..2a5793703 100644 --- a/app/views/form/page.html.erb +++ b/app/views/form/page.html.erb @@ -9,7 +9,7 @@ <%= page_info["header"] %> <% end %> - <%= form_with model: @case_log, method: "submit_form", builder: GOVUKDesignSystemFormBuilder::FormBuilder do |f| %> + <%= form_with model: @case_log, url: form_case_log_path(@case_log), method: "post", builder: GOVUKDesignSystemFormBuilder::FormBuilder do |f| %> <%= f.govuk_error_summary %> <% page_info["questions"].map do |question_key, question| %>
<%= display_question_key_div(page_info, question_key) %> > diff --git a/config/routes.rb b/config/routes.rb index 142a48d72..4e6620cee 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -4,8 +4,6 @@ Rails.application.routes.draw do root to: "test#index" get "about", to: "about#index" - post "/case_logs/:id", to: "case_logs#submit_form", constraints: { id: /\d.+/ } - form_handler = FormHandler.instance form = form_handler.get_form("2021_2022") @@ -15,6 +13,10 @@ Rails.application.routes.draw do get "/bulk_uploads", to: "bulk_upload#show" end + member do + post "/form", to: "case_logs#submit_form" + end + form.all_pages.keys.map do |page| get page.to_s, to: "case_logs##{page}" get "#{page}/soft_validations", to: "soft_validations#show" if form.soft_validations_for_page(page)