CLDC-4000: Buyer/Tenant nationality other answer option exclude UK (#3043)

* Buyer Tenant nationality other answer option exclude UK

* Fix answer options count in nationality_all_spec to reflect correct value

* Update nationality_all to use GlobalConstants for answer options and adjust displayed options

app/models/form/lettings/questions/nationality_all.rb

@@ -13,6 +13,10 @@ class Form::Lettings::Questions::NationalityAll < ::Form::Question
     answer_options[log.nationality_all.to_s]["name"]
   end
 
+  def displayed_answer_options(_log, _current_user = nil)
+    @answer_options.reject { |key, _| key == "826" }
+  end
+
   QUESTION_NUMBER_FROM_YEAR = { 2023 => 36, 2024 => 35 }.freeze
 
   def label_from_value(value)

app/models/form/sales/questions/nationality_all.rb

@@ -12,6 +12,10 @@ class Form::Sales::Questions::NationalityAll < ::Form::Question
     answer_options[log.send(id).to_s]["name"]
   end
 
+  def displayed_answer_options(_log, _current_user = nil)
+    @answer_options.reject { |key, _| key == "826" }
+  end
+
   QUESTION_NUMBER_FROM_YEAR_AND_BUYER_INDEX = {
     2023 => { 1 => 24, 2 => 32 },
     2024 => { 1 => 26, 2 => 34 },

spec/models/form/lettings/questions/nationality_all_spec.rb

@@ -20,4 +20,8 @@ RSpec.describe Form::Lettings::Questions::NationalityAll, type: :model do
   it "has the correct answer_options" do
     expect(question.answer_options.count).to eq(203)
   end
+
+  it "has the correct displayed_answer_options" do
+    expect(question.displayed_answer_options(nil, nil).count).to eq(202)
+  end
 end

spec/models/form/sales/questions/nationality_all_spec.rb

@@ -23,6 +23,10 @@ RSpec.describe Form::Sales::Questions::NationalityAll, type: :model do
     expect(question.answer_options.count).to eq(203)
   end
 
+  it "has the correct displayed_answer_options" do
+    expect(question.displayed_answer_options(nil, nil).count).to eq(202)
+  end
+
   it "has correct conditional for" do
     expect(question.conditional_for).to be_nil
   end