From f76d854ec13ae0e73fa3adc01537f438e66cb07b Mon Sep 17 00:00:00 2001 From: JG Date: Mon, 11 Jul 2022 07:56:21 +0100 Subject: [PATCH] extracted regex into initializer - part 2 --- app/models/case_log.rb | 2 +- app/models/validations/local_authority_validations.rb | 1 - app/services/imports/case_logs_import_service.rb | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index 49c3a8a73..d426e3d5d 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -585,7 +585,7 @@ private def get_inferred_la(postcode) # Avoid network calls when postcode is invalid - return unless postcode.match(Validations::PropertyValidations::POSTCODE_REGEXP) + return unless postcode.match(POSTCODE_REGEXP) postcode_lookup = nil begin diff --git a/app/models/validations/local_authority_validations.rb b/app/models/validations/local_authority_validations.rb index a7b3ed30d..0442af772 100644 --- a/app/models/validations/local_authority_validations.rb +++ b/app/models/validations/local_authority_validations.rb @@ -1,5 +1,4 @@ module Validations::LocalAuthorityValidations - POSTCODE_REGEXP = Validations::PropertyValidations::POSTCODE_REGEXP def validate_previous_accommodation_postcode(record) postcode = record.ppostcode_full diff --git a/app/services/imports/case_logs_import_service.rb b/app/services/imports/case_logs_import_service.rb index 936218838..2a3f129df 100644 --- a/app/services/imports/case_logs_import_service.rb +++ b/app/services/imports/case_logs_import_service.rb @@ -417,7 +417,6 @@ module Imports end end - POSTCODE_REGEXP = Validations::PropertyValidations::POSTCODE_REGEXP def compose_postcode(xml_doc, outcode, incode) outcode_value = string_or_nil(xml_doc, outcode) incode_value = string_or_nil(xml_doc, incode)