From f892f75631d0109fe1c81b1e834e94a53f12ab4e Mon Sep 17 00:00:00 2001
From: Rachael Booth <rachael.booth@softwire.com>
Date: Fri, 4 Oct 2024 10:52:20 +0100
Subject: [PATCH] More fixes

---
 app/models/form/question.rb                          | 1 -
 app/models/form/sales/pages/created_by.rb            | 2 +-
 spec/models/form/sales/pages/buyer_interview_spec.rb | 4 ----
 spec/models/form/sales/pages/buyer_live_spec.rb      | 4 ----
 spec/models/form/sales/pages/created_by_spec.rb      | 6 +-----
 spec/models/form/sales/pages/purchaser_code_spec.rb  | 4 ----
 6 files changed, 2 insertions(+), 19 deletions(-)

diff --git a/app/models/form/question.rb b/app/models/form/question.rb
index f64fcc0b3..9d019db1d 100644
--- a/app/models/form/question.rb
+++ b/app/models/form/question.rb
@@ -11,7 +11,6 @@ class Form::Question
   def initialize(id, hsh, page)
     @id = id
     @page = page
-    @copy_reference = nil
     if hsh
       @check_answer_label = hsh["check_answer_label"]
       @header = hsh["header"]
diff --git a/app/models/form/sales/pages/created_by.rb b/app/models/form/sales/pages/created_by.rb
index d40b522df..b84764804 100644
--- a/app/models/form/sales/pages/created_by.rb
+++ b/app/models/form/sales/pages/created_by.rb
@@ -2,7 +2,7 @@ class Form::Sales::Pages::CreatedBy < ::Form::Page
   def initialize(id, hsh, subsection)
     super
     @id = "assigned_to"
-    @copy_key = "assigned_to_id"
+    @copy_key = "sales.setup.assigned_to_id"
   end
 
   def questions
diff --git a/spec/models/form/sales/pages/buyer_interview_spec.rb b/spec/models/form/sales/pages/buyer_interview_spec.rb
index 73191593c..9065c3e57 100644
--- a/spec/models/form/sales/pages/buyer_interview_spec.rb
+++ b/spec/models/form/sales/pages/buyer_interview_spec.rb
@@ -19,10 +19,6 @@ RSpec.describe Form::Sales::Pages::BuyerInterview, type: :model do
     expect(page.id).to eq("buyer_interview")
   end
 
-  it "has the correct header" do
-    expect(page.header).to be_nil
-  end
-
   it "has the correct description" do
     expect(page.description).to be_nil
   end
diff --git a/spec/models/form/sales/pages/buyer_live_spec.rb b/spec/models/form/sales/pages/buyer_live_spec.rb
index c46908dff..a26b265ec 100644
--- a/spec/models/form/sales/pages/buyer_live_spec.rb
+++ b/spec/models/form/sales/pages/buyer_live_spec.rb
@@ -25,10 +25,6 @@ RSpec.describe Form::Sales::Pages::BuyerLive, type: :model do
     expect(page.id).to eq("buyer_live")
   end
 
-  it "has the correct header" do
-    expect(page.header).to be_nil
-  end
-
   it "has the correct description" do
     expect(page.description).to be_nil
   end
diff --git a/spec/models/form/sales/pages/created_by_spec.rb b/spec/models/form/sales/pages/created_by_spec.rb
index feb7489e2..7d9a25018 100644
--- a/spec/models/form/sales/pages/created_by_spec.rb
+++ b/spec/models/form/sales/pages/created_by_spec.rb
@@ -5,7 +5,7 @@ RSpec.describe Form::Sales::Pages::CreatedBy, type: :model do
 
   let(:page_id) { nil }
   let(:page_definition) { nil }
-  let(:subsection) { instance_double(Form::Subsection) }
+  let(:subsection) { instance_double(Form::Subsection, form: instance_double(Form, start_date: Time.zone.local(2024, 4, 1))) }
   let(:form) { instance_double(Form) }
   let(:lettings_log) { instance_double(LettingsLog) }
 
@@ -21,10 +21,6 @@ RSpec.describe Form::Sales::Pages::CreatedBy, type: :model do
     expect(page.id).to eq("assigned_to")
   end
 
-  it "has the correct header" do
-    expect(page.header).to be_nil
-  end
-
   it "has the correct description" do
     expect(page.description).to be_nil
   end
diff --git a/spec/models/form/sales/pages/purchaser_code_spec.rb b/spec/models/form/sales/pages/purchaser_code_spec.rb
index d342b1683..68a853826 100644
--- a/spec/models/form/sales/pages/purchaser_code_spec.rb
+++ b/spec/models/form/sales/pages/purchaser_code_spec.rb
@@ -19,10 +19,6 @@ RSpec.describe Form::Sales::Pages::PurchaserCode, type: :model do
     expect(page.id).to eq("purchaser_code")
   end
 
-  it "has the correct header" do
-    expect(page.header).to be_nil
-  end
-
   it "has the correct description" do
     expect(page.description).to be_nil
   end