From fc88c7da7b6890cf9bfc9c7b2d2e5118e1f7474e Mon Sep 17 00:00:00 2001
From: MadeTech Dushan <dushan@madetech.com>
Date: Fri, 28 Jan 2022 16:05:34 +0000
Subject: [PATCH] refactor tests

---
 spec/models/form_spec.rb | 81 +++++++++++++++++++++++++---------------
 1 file changed, 50 insertions(+), 31 deletions(-)

diff --git a/spec/models/form_spec.rb b/spec/models/form_spec.rb
index 8847dbe0e..ba1113382 100644
--- a/spec/models/form_spec.rb
+++ b/spec/models/form_spec.rb
@@ -39,66 +39,85 @@ RSpec.describe Form, type: :model do
     let(:later_subsection) { form.get_subsection("local_authority") }
 
     context "when a user is on the check answers page for a subsection" do
-      before do
-        case_log.tenant_code = "123"
-        case_log.age1 = 35
-        case_log.sex1 = "Male"
-        case_log.other_hhmemb = 0
-      end
-
-      it "returns the first page of the next incomplete subsection" do
-        expect(form.next_incomplete_section_redirect_path(subsection, case_log)).to eq("armed-forces")
-      end
-
-      it "returns the first page of the next incomplete subsection (skipping completed subsections)" do
+      def answer_household_needs(case_log)
         case_log.armedforces = "No"
         case_log.illness = "No"
         case_log.housingneeds_a = "Yes"
         case_log.la = "York"
         case_log.illness_type_1 = "Yes"
-        expect(form.next_incomplete_section_redirect_path(subsection, case_log)).to eq("tenancy-code")
       end
 
-      it "returns the next incomplete section by cycling back around if next subsections are completed" do
-        case_log.layear = "1 to 2 years"
-        case_log.lawaitlist = "Less than 1 year"
-        case_log.property_postcode = "NW1 5TY"
-        case_log.reason = "Permanently decanted from another property owned by this landlord"
-        case_log.previous_postcode = "SE2 6RT"
-        case_log.mrcdate = Time.zone.parse("03/11/2019")
-        expect(form.next_incomplete_section_redirect_path(later_subsection, case_log)).to eq("armed-forces")
+      def answer_tenancy_information(case_log)
+        case_log.tenancy_code = "1234"
       end
 
-      it "returns the declaration section for a completed case log" do
-        expect(form.next_incomplete_section_redirect_path(subsection, completed_case_log)).to eq("declaration")
+      def answer_property_information(case_log)
+        case_log.wchair = "No"
       end
 
-      it "returns the declaration section if all sections are complete but the case log is in progress" do
-        case_log.armedforces = "No"
-        case_log.illness = "No"
-        case_log.housingneeds_a = "Yes"
-        case_log.la = "York"
-        case_log.illness_type_1 = "Yes"
-        case_log.tenancy_code = "1234"
-        case_log.wchair = "No"
+      def answer_conditional_question(case_log)
         case_log.preg_occ = "No"
         case_log.cbl = "No"
+      end
+
+      def answer_income_and_benefits(case_log)
         case_log.earnings = 30_000
         case_log.incfreq = "Yearly"
         case_log.benefits = "Some"
         case_log.hb = "Tenant prefers not to say"
+      end
+
+      def answer_rent_and_charges(case_log)
         case_log.period = "Every 2 weeks"
         case_log.brent = 650
         case_log.scharge = 0
         case_log.pscharge = 0
         case_log.supcharg = 0
         case_log.tcharge = 650
+      end
+
+      def answer_local_authority(case_log)
         case_log.layear = "1 to 2 years"
         case_log.lawaitlist = "Less than 1 year"
         case_log.property_postcode = "NW1 5TY"
         case_log.reason = "Permanently decanted from another property owned by this landlord"
         case_log.previous_postcode = "SE2 6RT"
         case_log.mrcdate = Time.zone.parse("03/11/2019")
+      end
+
+      before do
+        case_log.tenant_code = "123"
+        case_log.age1 = 35
+        case_log.sex1 = "Male"
+        case_log.other_hhmemb = 0
+      end
+
+      it "returns the first page of the next incomplete subsection" do
+        expect(form.next_incomplete_section_redirect_path(subsection, case_log)).to eq("armed-forces")
+      end
+
+      it "returns the first page of the next incomplete subsection (skipping completed subsections)" do
+        answer_household_needs(case_log)
+        expect(form.next_incomplete_section_redirect_path(subsection, case_log)).to eq("tenancy-code")
+      end
+
+      it "returns the next incomplete section by cycling back around if next subsections are completed" do
+        answer_local_authority(case_log)
+        expect(form.next_incomplete_section_redirect_path(later_subsection, case_log)).to eq("armed-forces")
+      end
+
+      it "returns the declaration section for a completed case log" do
+        expect(form.next_incomplete_section_redirect_path(subsection, completed_case_log)).to eq("declaration")
+      end
+
+      it "returns the declaration section if all sections are complete but the case log is in progress" do
+        answer_household_needs(case_log)
+        answer_tenancy_information(case_log)
+        answer_property_information(case_log)
+        answer_conditional_question(case_log)
+        answer_income_and_benefits(case_log)
+        answer_rent_and_charges(case_log)
+        answer_local_authority(case_log)
 
         expect(form.next_incomplete_section_redirect_path(subsection, case_log)).to eq("declaration")
       end