From fe7e3ad9878e7180386d0042cb71ee18849dfe69 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 12 Mar 2025 13:14:44 +0000
Subject: [PATCH] Update error handling

---
 app/services/uprn_client.rb | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/services/uprn_client.rb b/app/services/uprn_client.rb
index 41a50e4f4..eaa9ef0c0 100644
--- a/app/services/uprn_client.rb
+++ b/app/services/uprn_client.rb
@@ -20,13 +20,13 @@ class UprnClient
   end
 
   def result
-    @result ||= begin
-      parsed_response = JSON.parse(response.body)
-      parsed_response.dig("results", 0, "DPA") || parsed_response.dig("results", 0, "LPI")
-    rescue JSON::ParserError => e
-      Rails.logger.error("Failed to parse JSON response: #{e.message}")
-      nil
-    end
+    @result ||= if response.code == 200
+                  parsed_response = JSON.parse(response.body)
+                  parsed_response.dig("results", 0, "DPA") || parsed_response.dig("results", 0, "LPI")
+                else
+                  Rails.logger.error("Unexpected response code: #{response.code}")
+                  nil
+                end
   end
 
 private