From ff4753e8c4710b48838efd7b8daa2ae6540c4edf Mon Sep 17 00:00:00 2001 From: Nat Dean-Lewis Date: Tue, 28 Jul 2026 16:34:47 +0100 Subject: [PATCH] docs: clarify comments --- app/controllers/users_controller.rb | 4 ---- config/application.rb | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 9efc48490..250d7b548 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -11,10 +11,6 @@ class UsersController < ApplicationController before_action -> { filter_manager.serialize_filters_to_session }, if: :current_user, only: %i[index] def index - # CSV requests fall through to the respond_to block below, which returns 401 - # for non-support users. Only HTML non-support users are redirected. The - # redirect must `return`: Rails 8 raises DoubleRenderError if the action then - # also renders/heads (previously the later render silently won). return redirect_to users_organisation_path(current_user.organisation) unless current_user.support? || request.format.csv? all_users = User.visible.sorted_by_organisation_and_role diff --git a/config/application.rb b/config/application.rb index a30333d43..eab518c1f 100644 --- a/config/application.rb +++ b/config/application.rb @@ -20,7 +20,7 @@ Bundler.require(*Rails.groups) module DataCollector class Application < Rails::Application - # Initialize configuration defaults for originally generated Rails version. + # Initialize configuration defaults for this Rails version. config.load_defaults 8.1 # Please, add to the `ignore` list any other `lib` subdirectories that do @@ -30,7 +30,7 @@ module DataCollector # it's strongly discouraged using add_autoload_paths_to_load_path, but rack_attack initializer can't load config files without it config.add_autoload_paths_to_load_path = true - + # Configuration for the application, engines, and railties goes here. # # These settings can be overridden in specific environments using the files