feat: set nil as default check answers card no

app/models/form/lettings/pages/max_rent_value_check.rb

@@ -1,5 +1,5 @@
 class Form::Lettings::Pages::MaxRentValueCheck < ::Form::Page
-  def initialize(id, hsh, subsection, check_answers_card_number:)
+  def initialize(id, hsh, subsection, check_answers_card_number = nil)
     super(id, hsh, subsection)
     @id = "max_rent_value_check"
     @depends_on = [{ "rent_in_soft_max_range?" => true }]

app/models/form/lettings/pages/min_rent_value_check.rb

@@ -1,5 +1,5 @@
 class Form::Lettings::Pages::MinRentValueCheck < ::Form::Page
-  def initialize(id, hsh, subsection, check_answers_card_number:)
+  def initialize(id, hsh, subsection, check_answers_card_number = nil)
     super(id, hsh, subsection)
     @id = "min_rent_value_check"
     @depends_on = [{ "rent_in_soft_min_range?" => true }]
@@ -17,7 +17,7 @@ class Form::Lettings::Pages::MinRentValueCheck < ::Form::Page
         },
       ],
     },
-                        @check_answers_card_number = check_answers_card_number
+    @check_answers_card_number = check_answers_card_number
   end
 
   def questions

app/models/form/lettings/subsections/income_and_benefits.rb

@@ -24,8 +24,8 @@ class Form::Lettings::Subsections::IncomeAndBenefits < ::Form::Subsection
       Form::Lettings::Pages::RentBiWeekly.new(nil, nil, self),
       Form::Lettings::Pages::Rent4Weekly.new(nil, nil, self),
       Form::Lettings::Pages::RentMonthly.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, 0),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, 0),
       Form::Lettings::Pages::Outstanding.new(nil, nil, self),
       Form::Lettings::Pages::OutstandingAmount.new(nil, nil, self),
     ].compact

app/models/form/lettings/subsections/property_information.rb

@@ -10,8 +10,8 @@ class Form::Lettings::Subsections::PropertyInformation < ::Form::Subsection
     @pages ||= [
       uprn_questions,
       Form::Lettings::Pages::PropertyLocalAuthority.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, 0),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, 0),
       Form::Lettings::Pages::FirstTimePropertyLetAsSocialHousing.new(nil, nil, self),
       Form::Lettings::Pages::PropertyLetType.new(nil, nil, self),
       Form::Lettings::Pages::PropertyVacancyReasonNotFirstLet.new(nil, nil, self),
@@ -22,8 +22,8 @@ class Form::Lettings::Subsections::PropertyInformation < ::Form::Subsection
       Form::Lettings::Pages::PropertyBuildingType.new(nil, nil, self),
       Form::Lettings::Pages::PropertyWheelchairAccessible.new(nil, nil, self),
       Form::Lettings::Pages::PropertyNumberOfBedrooms.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: 0),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, 0),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, 0),
       Form::Lettings::Pages::VoidDate.new(nil, nil, self),
       Form::Lettings::Pages::VoidDateValueCheck.new(nil, nil, self),
       Form::Lettings::Pages::PropertyMajorRepairs.new(nil, nil, self),

app/models/form/lettings/subsections/setup.rb

@@ -10,22 +10,22 @@ class Form::Lettings::Subsections::Setup < ::Form::Subsection
     @pages ||= [
       organisation_page,
       stock_owner_page,
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self),
       managing_organisation_page,
       created_by_page,
       Form::Lettings::Pages::NeedsType.new(nil, nil, self),
       Form::Lettings::Pages::Scheme.new(nil, nil, self),
       Form::Lettings::Pages::Location.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self),
       Form::Lettings::Pages::Renewal.new(nil, nil, self),
       Form::Lettings::Pages::TenancyStartDate.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self),
       Form::Lettings::Pages::RentType.new(nil, nil, self),
-      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
-      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self, check_answers_card_number: nil),
+      Form::Lettings::Pages::MinRentValueCheck.new(nil, nil, self),
+      Form::Lettings::Pages::MaxRentValueCheck.new(nil, nil, self),
       Form::Lettings::Pages::TenantCode.new(nil, nil, self),
       Form::Lettings::Pages::PropertyReference.new(nil, nil, self),
     ].compact