submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	3b83614ab5	CLDC-2313 add bulk upload validation buyer 1 cannot be child (#1634 ) * add a bespoke validation to the row parser when buyer 1 is uploaded with working situation child, this should be validated with a custom message. a test for this case was also created * replicate the work from the last commit for the 2023 row parser and associated test file * lint correction remove blank lines	2 years ago
kosiakkatrina	0fea8585ec	CLDC-2354 Add soft validation messages to 23/24 sales (#1627 ) * Add soft validation messages to 23/24 sales * Refactor return and tests * More flaky tests	2 years ago
natdeanlewissoftwire	da00fa73f6	CLDC-2348 Purchaser code bug fix (#1638 ) * feat: assign purchaser_code for each year * refactor: lint * feat: add test that checks purchaser code assignment without explicitly calling a field	2 years ago
kosiakkatrina	ea59d036d2	CLDC-2347 Set monthly charges for bulk upload (#1629 ) * Infer has mscharge as no if it's 0 for 22/23 * Infer has mscharge as no if it's 0 for 23/24	2 years ago
kosiakkatrina	353facc893	CLDC-2304 Deduplicate sales logs in bulk upload (#1612 ) * Deduplicate 2022 sales logs * Don't run deduplication on staging * Do not create duplicate logs * Add deduplication to the 23/24 sales	2 years ago
natdeanlewissoftwire	0d11403122	CLDC-2315 Add bulk upload inferences (#1592 ) * feat: bulk upload complete => redirect to all logs regardless of filter memory * feat: derive variables if buyer not interviewed * feat: remove redundant derivation that is overrided by other derivation * feat: update url for lettings * tests: tests inferences * tests: update * feat: update links * feat: update urls to use url helper * feat: update urls to use url helper * feat: update logic * test: update * test: update * test: update * feat: infer ecstat1 as 10 not 0 * feat: update tests	2 years ago
Phil Lee	1053607ed8	CLDC-2287 Bulk upload setup errors (#1585 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2287 - bulk upload errors on setup fields are not being categorised as setup errors # Changes - ensure errors on setup field are categorised as `setup` errors - ordering of validations tweaked, so `validate_nulls` is further down the execution order. this is so any existing validation run first and `validate_nulls` only adds errors if there aren't any existing errors on a field - removed old 16/60% tests are no longer required due to introduction of `how to fix` journey	2 years ago
kosiakkatrina	99cb26b934	CLDC-2296 Display soft validation errors on bulk upload (#1594 ) * Add affected_question_ids to pregnancy check * Update is_referrer_interruption_screen? check and naming * Use interruption_screen_question_ids to set soft validation errors on relevant fields * Add soft validations to sales bulk upload * Add soft validations to lettings logs 23/24 bulk upload * Add errors for optional soft validations * Only add soft validations once * Import helper methods * Update test based on new validation messages * Rebase fix	2 years ago
Phil Lee	45128b7250	Refactor with split of log to CSV by log type (#1593 ) # Context - Partially related to https://digital.dclg.gov.uk/jira/browse/CLDC-2316 - Comprehending sales or lettings bulk upload CSV is enough, comprehending both simultaneously is rather challenging # Changes - Split out test helper class by log type ie lettings/sales	2 years ago
kosiakkatrina	d1f21a5890	CLDC-2031 Sales bulk upload (#1574 ) * Add sales csv parser * Create log creator and update row parser for sales * Add validations * Add status_cache to sales logs * Parse completed log * Add basic validations to the row parser * Fix details known and proplen mapping * Add setup section errors * Update sales log validator * tests * Add sales resume and summary pages * send the correct emails	2 years ago
Phil Lee	35de06e324	CLDC-2067 Bulk upload for lettings 23/24 (#1417 ) * refactor questions from validator to row parser * able to switch between bulk upload parsers - depending on what year we are processing * spec tooling to support bulk upload multi year * row parser now has year in namespacing * add static data for 2023 row parser * add placeholder to log to csv for specs * bulk upload aribtrary 23/34 column ordering works * bulk upload supports 23/24 without headers * bulk upload 23/24 supports BOM + invalid chars * dupe tests * port 23/24 attributes_for_log * port 23/24 bulk upload validations * force crossover period * tweak max permitted columns * able to return column for given field * work out column for field for errors * add field_4 as 23/24 setup field * remove duplicate method * map schemes and locations correctly * handle arbitrary number of header rows * add missing fields to bulk upload support	2 years ago

11 Commits (CLDC-2390-town-not-given)