submit-social-housing-lettings-and-sales-data

3348 Commits

234 Branches

285 Tags

80 MiB

Branch: CLDC-3921-Sales-BU-bug-infers-value-as-3-if-invalid-value-given

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Arthur Campbell	47378cf7df	CLDC 3414 update homepage (#2408 ) * create presenter class to hold all the db calls and data for showing the home page plus tests, some changes to factoreis and helpers necessary this should avoid an overly bloated controller method or calling the DB from a view helper * view partial changes to accommodate design changes, decouple box with counter and blue link boxes since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page. * redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller * adjust tests and factories and address api call stub * remove view helpers that are no longer being used and remove outdated tests for home page * amend presenter and associated calls from view, tests, to ensure support user always sees sales data * write request specs for the homepage * undo unnecessary change to factory * make corrections following rebase conflicts * various minor changes following tech review * logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them * resolve rebase confusion in csv fixture files	1 year ago
natdeanlewissoftwire	5a1e5674ce	CLDC-3116 Create homepage (#2113 ) * feat: add blank homepage, update routing and tests * feat: add welcome message and thoroughly test routing * refactor: lint * feat: update tests * CLDC-3076: Make example dates consistent (#2107) * CLDC-3076: Make example dates consistent * Use example date even when some hint text provided already * Temp remove some date restrictions * Update to 2 line breaks * Revert "Temp remove some date restrictions" This reverts commit `cd7f18f9f1`. * Fix lettings log accessor in date question (#2117) * Fix lettings log accessor in date question * Remove hardcoded date example from mrcdate question (#2118) --------- Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com> * CLDC-3061 Add guidance page (#2121) * Add guidance page * Link to guidance from start page * feat: test home/start paths explicitly * CLDC-2253 Add collection resources (#2120) * Update collection resources, add to homepage * Add guidance link to an empty page * Update headings * Rebase fix * Update title * Update file names * Add section break * CLDC-2593 Add upcoming deadlines section (#2119) * Add upcoming deadlines section * Update the content to use the correct dates * Update content * lint * typos * CLDC-2252 Add homepage task section (#2115) * feat: wip add lettings, sales and schemes sections with correct text, counts, links and colouring * feat: add flex styling to match designs * CLDC-3076: Make example dates consistent (#2107) * CLDC-3076: Make example dates consistent * Use example date even when some hint text provided already * Temp remove some date restrictions * Update to 2 line breaks * Revert "Temp remove some date restrictions" This reverts commit `cd7f18f9f1`. * Fix lettings log accessor in date question (#2117) * Fix lettings log accessor in date question * Remove hardcoded date example from mrcdate question (#2118) --------- Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com> * feat: update breakpoints for responsive layout changes * lint: use hash lookup where possible * lint: erblinting * feat: improve formatting * Reuse govuk grid * Revert "Reuse govuk grid" This reverts commit `8c71f5d9ed`. * feat: test home page data boxes * refactor: lint * refactor: lint * feat: test link behaviour is correct in all user scenarios * refactor: lint * feat: update tests * feat: combine task, resources, deadlines sections --------- Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: Kat <kosiak.katrina@gmail.com> * CLDC-2255 Add homepage notifications (#2131) * feat: add notification table * feat: add notification banner, use unread gem for notification management * feat: add notifications page and remove unread_notification.rb * feat: add blank homepage, update routing and tests * feat: add welcome message and thoroughly test routing * refactor: lint * feat: update tests * CLDC-3061 Add guidance page (#2121) * Add guidance page * Link to guidance from start page * feat: test home/start paths explicitly * feat: add notification table * feat: add notification banner, use unread gem for notification management * feat: add notifications page and remove unread_notification.rb * feat: default p tag around sanitized page content * feat: add active scope * feat: use newest active unread/unauthenticated notification and update start page * feat: add tests of notification behaviour and routing and refactor * refactor: lint * feat: update Gemfile.lock * feat: add timestamps to readmark table * feat: update gemfile.lock * refactor: lint * feat: test notifications page doesn't show notifications and code simplification * feat: move notification helper methods to notifications_helper.rb --------- Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * feat: clear all no-status filters on in progress links * CLDC-2590 Add about this service section (#2124) * Add about core section * Move about core to the correct spot on start page * Update content * Add some margins --------- Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: Kat <kosiak.katrina@gmail.com>	1 year ago

Arthur Campbell

47378cf7df

CLDC 3414 update homepage (#2408 )

* create presenter class to hold all the db calls and data for showing the home page
plus tests, some changes to factoreis and helpers necessary
this should avoid an overly bloated controller method or calling the DB from a view helper

* view partial changes
to accommodate design changes, decouple box with counter and blue link boxes
since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page.

* redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller

* adjust tests and factories and address api call stub

* remove view helpers that are no longer being used and remove outdated tests for home page

* amend presenter and associated calls from view, tests, to ensure support user always sees sales data

* write request specs for the homepage

* undo unnecessary change to factory

* make corrections following rebase conflicts

* various minor changes following tech review

* logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them

* resolve rebase confusion in csv fixture files

1 year ago

natdeanlewissoftwire

5a1e5674ce

CLDC-3116 Create homepage (#2113 )

* feat: add blank homepage, update routing and tests

* feat: add welcome message and thoroughly test routing

* refactor: lint

* feat: update tests

* CLDC-3076: Make example dates consistent (#2107)

* CLDC-3076: Make example dates consistent

* Use example date even when some hint text provided already

* Temp remove some date restrictions

* Update to 2 line breaks

* Revert "Temp remove some date restrictions"

This reverts commit cd7f18f9f1.

* Fix lettings log accessor in date question (#2117)

* Fix lettings log accessor in date question

* Remove hardcoded date example from mrcdate question (#2118)

---------

Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com>

* CLDC-3061 Add guidance page (#2121)

* Add guidance page

* Link to guidance from start page

* feat: test home/start paths explicitly

* CLDC-2253 Add collection resources (#2120)

* Update collection resources, add to homepage

* Add guidance link to an empty page

* Update headings

* Rebase fix

* Update title

* Update file names

* Add section break

* CLDC-2593 Add upcoming deadlines section (#2119)

* Add upcoming deadlines section

* Update the content to use the correct dates

* Update content

* lint

* typos

* CLDC-2252 Add homepage task section (#2115)

* feat: wip add lettings, sales and schemes sections with correct text, counts, links and colouring

* feat: add flex styling to match designs

* CLDC-3076: Make example dates consistent (#2107)

* CLDC-3076: Make example dates consistent

* Use example date even when some hint text provided already

* Temp remove some date restrictions

* Update to 2 line breaks

* Revert "Temp remove some date restrictions"

This reverts commit cd7f18f9f1.

* Fix lettings log accessor in date question (#2117)

* Fix lettings log accessor in date question

* Remove hardcoded date example from mrcdate question (#2118)

---------

Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com>

* feat: update breakpoints for responsive layout changes

* lint: use hash lookup where possible

* lint: erblinting

* feat: improve formatting

* Reuse govuk grid

* Revert "Reuse govuk grid"

This reverts commit 8c71f5d9ed.

* feat: test home page data boxes

* refactor: lint

* refactor: lint

* feat: test link behaviour is correct in all user scenarios

* refactor: lint

* feat: update tests

* feat: combine task, resources, deadlines sections

---------

Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: Kat <kosiak.katrina@gmail.com>

* CLDC-2255 Add homepage notifications (#2131)

* feat: add notification table

* feat: add notification banner, use unread gem for notification management

* feat: add notifications page and remove unread_notification.rb

* feat: add blank homepage, update routing and tests

* feat: add welcome message and thoroughly test routing

* refactor: lint

* feat: update tests

* CLDC-3061 Add guidance page (#2121)

* Add guidance page

* Link to guidance from start page

* feat: test home/start paths explicitly

* feat: add notification table

* feat: add notification banner, use unread gem for notification management

* feat: add notifications page and remove unread_notification.rb

* feat: default p tag around sanitized page content

* feat: add active scope

* feat: use newest active unread/unauthenticated notification and update start page

* feat: add tests of notification behaviour and routing and refactor

* refactor: lint

* feat: update Gemfile.lock

* feat: add timestamps to readmark table

* feat: update gemfile.lock

* refactor: lint

* feat: test notifications page doesn't show notifications and code simplification

* feat: move notification helper methods to notifications_helper.rb

---------

Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>

* feat: clear all no-status filters on in progress links

* CLDC-2590 Add about this service section (#2124)

* Add about core section

* Move about core to the correct spot on start page

* Update content

* Add some margins

---------

Co-authored-by: Rachael Booth <Rachael.Booth@softwire.com>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: Kat <kosiak.katrina@gmail.com>

1 year ago

2 Commits (CLDC-3921-Sales-BU-bug-infers-value-as-3-if-invalid-value-given)