submit-social-housing-lettings-and-sales-data

3443 Commits

241 Branches

289 Tags

81 MiB

Branch: CLDC-4035-improve-our-handling-of-commas-in-price-fields

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
David May-Miller	44c9c563b2	CLDC-4074 Update tests now that 2023 is closed (#3093 ) * CLDC-4074 Updated sales log tests to use filters from the current year instead of a fixed one * CLDC-4074: Update other sales log tests to use the current year instead of a fixed one * CLDC-4074: Update more failing tests * CLDC-4074: Remove some 2024 sales log tests * CLDC-4074: Ignore a failing request test * CLDC-4074: Fix lettings log services tests * CLDC-4074: Fix merge request helper spec * CLDC-4074: Fix rake tests for 2024 logs * CLDC-4074: Fix guidance helper tests * CLDC-4074: Fix skipped tests * CLDC-4074: Update tests for 2023 edit closing (#3095) * CLDC-4074: Fix model tests * CLDC-4074: Fix requests tests * CLDC-4074: Fix services tests * CLDC-4074: Fix rake tasks tests the broken ones only make sense for 2024 logs so feels like timecop is the only option * CLDC-4074: Specify why some tests are not validated based on year --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	6 days ago
carolynbarker	b02bfcb7cd	CLDC-3939 update tests for new FY (#3010 ) * test tests in April * update tests where 2014 is assumed * update test where time moving is assumed * update rake task tests that only affect 2024 logs * update another 2024 assumption * handle null period in validation * give pages different ids in SharedOwnershipInitialPurchase and SharedOwnershipStaircasingTransaction sections * refactor to remove unnecessary method * delete some old rake tasks and tests * CLDC-3899 remove flaky date comparison from tests * CLDC-3899 fix flaky test occasionally picking bad input * fix test year setup * add relat mapping for log_to_csv * temp disable fail-fast for ease of testing * specify 2024 in 2024-specific test * Revert "temp disable fail-fast for ease of testing" This reverts commit `6993d29866`. * Revert "test tests in April" This reverts commit `f5635dba11`. * pass test in 2024 and 2025 * fix test to 2024 * temp disable fail-fast again * Revert "temp disable fail-fast again" This reverts commit `55d3e1c7d8`. --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com>	5 months ago
Manny Dinssa	c54cf11348	CLDC-3860: Bulk upload add validation, prevent reasonpref dontknow being selected (#2955 ) * Add validation on reasonpref dontknow * Add test * Update method * Update setting errors * Update test * Add tests for rake task * separate out tests * Test updated at, excluding pre 2024 * Update 2025 row parser * Clear values if rp_dontknow conflict exists * Reorder, no change just precautionary * Put back code removed	6 months ago

David May-Miller

44c9c563b2

CLDC-4074 Update tests now that 2023 is closed (#3093 )

* CLDC-4074 Updated sales log tests to use filters from the current year instead of a fixed one

* CLDC-4074: Update other sales log tests to use the current year instead of a fixed one

* CLDC-4074: Update more failing tests

* CLDC-4074: Remove some 2024 sales log tests

* CLDC-4074: Ignore a failing request test

* CLDC-4074: Fix lettings log services tests

* CLDC-4074: Fix merge request helper spec

* CLDC-4074: Fix rake tests for 2024 logs

* CLDC-4074: Fix guidance helper tests

* CLDC-4074: Fix skipped tests

* CLDC-4074: Update tests for 2023 edit closing (#3095)

* CLDC-4074: Fix model tests

* CLDC-4074: Fix requests tests

* CLDC-4074: Fix services tests

* CLDC-4074: Fix rake tasks tests

the broken ones only make sense for 2024 logs so feels like timecop is the only option

* CLDC-4074: Specify why some tests are not validated based on year

---------

Co-authored-by: Samuel Young <samuel.young@softwire.com>

6 days ago

carolynbarker

b02bfcb7cd

CLDC-3939 update tests for new FY (#3010 )

* test tests in April

* update tests where 2014 is assumed

* update test where time moving is assumed

* update rake task tests that only affect 2024 logs

* update another 2024 assumption

* handle null period in validation

* give pages different ids in SharedOwnershipInitialPurchase and  SharedOwnershipStaircasingTransaction sections

* refactor to remove unnecessary method

* delete some old rake tasks and tests

* CLDC-3899 remove flaky date comparison from tests

* CLDC-3899 fix flaky test occasionally picking bad input

* fix test year setup

* add relat mapping for log_to_csv

* temp disable fail-fast for ease of testing

* specify 2024 in 2024-specific test

* Revert "temp disable fail-fast for ease of testing"

This reverts commit 6993d29866.

* Revert "test tests in April"

This reverts commit f5635dba11.

* pass test in 2024 and 2025

* fix test to 2024

* temp disable fail-fast again

* Revert "temp disable fail-fast again"

This reverts commit 55d3e1c7d8.

---------

Co-authored-by: Carolyn <carolyn.barker@softwire.com>

5 months ago

Manny Dinssa

c54cf11348

CLDC-3860: Bulk upload add validation, prevent reasonpref dontknow being selected (#2955 )

* Add validation on reasonpref dontknow

* Add test

* Update method

* Update setting errors

* Update test

* Add tests for rake task

* separate out tests

* Test updated at, excluding pre 2024

* Update 2025 row parser

* Clear values if rp_dontknow conflict exists

* Reorder, no change just precautionary

* Put back code removed

6 months ago

3 Commits (CLDC-4035-improve-our-handling-of-commas-in-price-fields)