submit-social-housing-lettings-and-sales-data

1855 Commits

231 Branches

276 Tags

77 MiB

Branch: CLDC-908-add-validation-mortgage-lender-name-provided-if-other

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	07f345df71	CLDC-1730-stock-owning-validation (#1073 ) * feat: add error message if org doesn't own stock * feat: move org relationship errors to model * feat: use correct model for form * tests: update params in tests * feat: add specific fields for parent/child errors * test: fix params in failing tests * refactor: unrelated linting * feat: simplify controller behaviour further * test: address failing tests * feat: add copy to en.yml * feat: add updated validation message and rename related housing provider -> stock owner	2 years ago
Jack S	38f1cada5d	[CLDC-1659] Create managing agents (#956 ) * Add managing agent * tidy up specs * Address comments * linter	2 years ago
natdeanlewissoftwire	b45b98108a	Cldc 1662 add housing provider (#954 ) * wip * Rename managing_agents column * add managing relationship * f * feat: add my features branched off managing agents branch * feat: update nav behaviour * feat: simplify housing_providers view * feat: fix pluralise to default to plural rather than singular * feat: remove managing agent related code so can be merged directly * tests: update tests and add new ones for housing_providers * refactor: rubocop conciliation * tests: fix failing navigation tests * tests: one more plural test * refactor: erb linting * refactor: erb linting * feat: right-align "Remove" text * feat: update nokogiri to pass bundler-audit * feat: grey out search button * feat: remove section-break * feat: add housing provider page with details and button * feat: tidy up routing * feat: add wip housing provider behaviour without functioning search * feat: wip add housing provider functionality hard coded to add FooBar LTD as provider to DLUHC * feat: remove redundant code * feat: add data passing behaviour without accessible autocomplete * feat: use accessible autocomplete (not working) * feat: use accessible autocomplete (now working) * feat: wip commit error messages * feat: add banner always * feat: add conditional banner behaviour, back link and update logs titles * feat: add search icon to accessible autocomplete, make hint text aligned correctly * feat: use pluck not all * tests: add initial test * feat: refactor create logic * feat: add sub org title * feat: add correct no housing providers text * feat: add correct no housing providers text * tests: add tests for add housing provider page * feat: remove unnecessary line from controller * fet: simplify controller args * fet: update schema * feat: update schema * feat: remove create_managing_agent * test: add support user tests * test: add create_housing_provider tests * refactor: rubocop autocorrect * refactor: erblinting * test: fix tests * refactor: erblinting * feat: don't use !important tag Co-authored-by: Jack S <jacopo.scotti@softwire.com>	2 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

07f345df71

CLDC-1730-stock-owning-validation (#1073 )

* feat: add error message if org doesn't own stock

* feat: move org relationship errors to model

* feat: use correct model for form

* tests: update params in tests

* feat: add specific fields for parent/child errors

* test: fix params in failing tests

* refactor: unrelated linting

* feat: simplify controller behaviour further

* test: address failing tests

* feat: add copy to en.yml

* feat: add updated validation message and rename related housing provider -> stock owner

2 years ago

Jack S

38f1cada5d

[CLDC-1659] Create managing agents (#956 )

* Add managing agent

* tidy up specs

* Address comments

* linter

2 years ago

natdeanlewissoftwire

b45b98108a

Cldc 1662 add housing provider (#954 )

* wip

* Rename managing_agents column

* add managing relationship

* f

* feat: add my features branched off managing agents branch

* feat: update nav behaviour

* feat: simplify housing_providers view

* feat: fix pluralise to default to plural rather than singular

* feat: remove managing agent related code so can be merged directly

* tests: update tests and add new ones for housing_providers

* refactor: rubocop conciliation

* tests: fix failing navigation tests

* tests: one more plural test

* refactor: erb linting

* refactor: erb linting

* feat: right-align "Remove" text

* feat: update nokogiri to pass bundler-audit

* feat: grey out search button

* feat: remove section-break

* feat: add housing provider page with details and button

* feat: tidy up routing

* feat: add wip housing provider behaviour without functioning search

* feat: wip add housing provider functionality hard coded to add FooBar LTD as provider to DLUHC

* feat: remove redundant code

* feat: add data passing behaviour without accessible autocomplete

* feat: use accessible autocomplete (not working)

* feat: use accessible autocomplete (now working)

* feat: wip commit error messages

* feat: add banner always

* feat: add conditional banner behaviour, back link and update logs titles

* feat: add search icon to accessible autocomplete, make hint text aligned correctly

* feat: use pluck not all

* tests: add initial test

* feat: refactor create logic

* feat: add sub org title

* feat: add correct no housing providers text

* feat: add correct no housing providers text

* tests: add tests for add housing provider page

* feat: remove unnecessary line from controller

* fet: simplify controller args

* fet: update schema

* feat: update schema

* feat: remove create_managing_agent

* test: add support user tests

* test: add create_housing_provider tests

* refactor: rubocop autocorrect

* refactor: erblinting

* test: fix tests

* refactor: erblinting

* feat: don't use !important tag

Co-authored-by: Jack S <jacopo.scotti@softwire.com>

2 years ago

2 Commits (CLDC-908-add-validation-mortgage-lender-name-provided-if-other)