roobottom
65cac3f688
added "joint tenancy" question
3 years ago
baarkerlounger
9a754c2dd6
Time spent in LA can't be derived
3 years ago
baarkerlounger
be25e07f5f
Starter tenancy routing
3 years ago
Stéphane Meny
217ce62a82
Reduce differences between imported values and saved values ( #486 )
...
* Compare imported values and saved values
* Remove London validations
* 2021-2022 form fixes
* Code review changes
3 years ago
Dushan
2e93dd5e2b
Move privacy notice add final review ( #469 )
...
* WIP
* Unpleasant but works
* Alias is maybe better?
* WIP
* remove unneeded partial
* error and success when submitting
* add request specs for review page
* delete unneeded feature spec
* WIP
* Unpleasant but works
* Alias is maybe better?
* WIP
* remove unneeded partial
* error and success when submitting
* add request specs for review page
* delete unneeded feature spec
* 🤏 fixes
* display when log is completed
Co-authored-by: baarkerlounger <db@slothlife.xyz>
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
3 years ago
Stéphane Meny
4f1df84d36
Rename attribute irproduct_other in JSON ( #481 )
3 years ago
Stéphane Meny
b8d60a86ea
Import changes ( #470 )
3 years ago
Dushan
33aa4a226f
Fix check answers bugs ( #474 )
...
* fix issues with check answers
* lint fixes
3 years ago
kosiakkatrina
868de89234
Update soft rent validations messages ( #453 )
...
* Update soft rent validations messages
* fix suffix and to_s for check_answers symbol
* rubocop
3 years ago
baarkerlounger
50eeaa9101
Remove hint text from tenancy start date question
3 years ago
baarkerlounger
9dc7e574bf
CLDC-1116: Don't route to ecstat if age is under 16 ( #446 )
...
* Ecstat dependent on age
* Derive ecstat if age is under 16
* Test value label derivation
* Ensure derived option is still shown in check answers
3 years ago
kosiakkatrina
6c5391ad1c
Cldc 1065 soft validations ( #434 )
...
* change get_question form method to prioritise the routed to questions
* Add soft validation and interruption screen for basic rent
* get previous page that was routed to and display the same error for both soft validations
* Separate max and min error screens
* add a test for getting the previous page
* Update content and add more tests for previous page
3 years ago
baarkerlounger
49f2fbf75a
Remove org question as it doesn't apply to 1.0 ( #437 )
3 years ago
kosiakkatrina
c43e730254
Cldc 657 full postcodes ( #421 )
...
* Rename full postcode columns
* Normalise the postcodes
* Fix test
3 years ago
Dushan
b72eb9f3fc
CLDC-667 newprop derived variable ( #426 )
...
* Update keys of rsnvac for first lets
Making it match with what is in the data dictionary. It was a wuick enough
fix to be included in this branch since it pairs well with the newprop derived
variable implementation
* add newprop derived variable and tests
* fixes
* use ternary statement for newprop derivation
3 years ago
baarkerlounger
de7ab9db1c
Other household members derived ( #425 )
3 years ago
baarkerlounger
dec350e6f1
Relat data type ( #423 )
3 years ago
baarkerlounger
910f13d507
Household member validations ( #420 )
...
* Add missing ecstat validation
* Add compound validation errors to all involved fields
* Update ecstat values
* Update values in validations and tests
* Update rent rant values
* Add some helper methods for readability
3 years ago
kosiakkatrina
e34c910ad0
Change the remaining ethnic other conditional questions ( #417 )
3 years ago
baarkerlounger
0142d476ca
Reset all invalidated page questions ( #409 )
...
* Reset all invalidated page questions
* Spec
3 years ago
baarkerlounger
12e5d8165e
Fix hint text
3 years ago
baarkerlounger
8402ca36ab
Update content strings ( #407 )
3 years ago
kiddhustle
94ed1c6aae
CLDC-1050: re-add ethnic question
...
CLDC-1050: revert schema change
3 years ago
Paul Robert Lloyd
9b51ad13b7
Link to privacy policy page, not old PDF
3 years ago
Paul Robert Lloyd
da26cba8dd
Update URL slugs for 2021/22 questions
3 years ago
kosiakkatrina
c2c49924a3
Cldc 491 rent and charges validations (part 1) ( #388 )
...
* move age validation tests to shared validation spec
* Add brent/tshortfall validation
* update period mappings
* Add scharge validation
* update num of weeks from period mapping
* fix test
* change period mappings in test
* Add tests for floats
* change error message content
* add supported housing scharge validation
* add other landlord validations
* refactor
* refactor validation and tests
* Add supcharg validations and refactor
* add total charge calculations
* move constants
* Fix tests and add missing validation messages
3 years ago
baarkerlounger
ea6122fe99
CLDC-663: Weekly total shortfall derived variable ( #385 )
...
* Update HB value mappings
* Derive Weekly shortfall value
* Reset weekly total shortfall when not applicable
3 years ago
baarkerlounger
02cb31947e
Compare as float ( #384 )
3 years ago
Dushan
484bb499e6
CLDC-788 interruption screen net income soft validation ( #372 )
...
* Set up failing test for new soft validation design
* remove unneeded js controller
* remove unneeded controller and spec
* rename net income validation override column
* spec form changes (to allow tests to run)
* validation spec changes
* replace all instances of override_net_income_validatiom
* passing first test
* Add to form and import styling
* remove unneeded code from interruption screen view
* Update test & code - failing last new expectation
* Display 2 previous question answers in the informative text
* extract displaying of the informative text into a helper
* Add tests for helper
* Remove some of the previous soft validations set up
* fix some failing specs
* Fix more tests
* lint
* Reset earnings question prefix and suffix to initial values instead of nil
* make it route backwards on a no
* test and linter fixes
* refactor next_page
* stryling
* more changes
* fix specs
* update real form
* design tweaks
* delete commented out tests
* content changes
* content changes
* changes to informative/hint text
* More robust styles for interuption panel, use smart quotes
* Rubocop
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
3 years ago
kosiakkatrina
2b249c3449
consistently show prevten if it's not a renewal question ( #371 )
3 years ago
kosiakkatrina
a9b9381215
Fix prevten inferred values, revert routing change for prevten ( #369 )
...
* Fix prevten inferred values, revert routing change for prevten
* tests
3 years ago
baarkerlounger
03479199d4
Lead tenant must be at least 16 ( #365 )
3 years ago
kosiakkatrina
20337f217f
fix the question dependency for prevten ( #364 )
3 years ago
Paul Robert Lloyd
ac35fe98d8
Correct condition syntax for void/renewal date question
3 years ago
Paul Robert Lloyd
461eb0fe42
Remove ‘your’ when mentioning logs
3 years ago
Paul Robert Lloyd
b13b6d1542
Content tweaks for household needs section
3 years ago
Paul Robert Lloyd
a582a5ce42
Content tweaks for household situation section
3 years ago
Paul Robert Lloyd
a05ccdbefd
Consistent syntax format for form config JSON
3 years ago
Paul Robert Lloyd
faec67800f
Correct content and answer display for household characteristics
3 years ago
Paul Robert Lloyd
14497a6794
Updated answer labels for Household characteristics
3 years ago
Paul Robert Lloyd
d6036ca6a1
Use dash instead of hyphen in question options
3 years ago
Paul Robert Lloyd
1b9d4dba27
Correct order for lead tenant nationality questions
3 years ago
kiddhustle
bc88f3396c
CLDC-959: fix JSON typos
3 years ago
Dushan
70b6a465de
update page routing dependencies household needs ( #345 )
3 years ago
kosiakkatrina
b19dda5c23
fix depends on mapping ( #344 )
3 years ago
kiddhustle
7c228417a8
CLDC-959: add multiple tenant flow
3 years ago
kosiakkatrina
14a2a3e035
Address and mapping fixes ( #343 )
...
* Display inferred address answers
* Update mappings for the rest of the questions in the household situation section
3 years ago
kosiakkatrina
34ae256695
Update validation and db mapping for homeless ( #341 )
3 years ago
kosiakkatrina
71aa068621
only route to prevten if it's supported housing ( #340 )
3 years ago
kosiakkatrina
e7f57315a5
Update referral validation numbers and clearing of the answers ( #339 )
...
* Update referral validation numbers and clearing of the answers
* refactor is_internal_transfer
3 years ago