submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	c78f2ef5f9	CLDC-1945 numeric questions decimal letter entry (#1442 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase	2 years ago
Phil Lee	4da8758971	CLDC-2224 Bulk upload validate radio options (#1514 ) * validate radio options for bulk upload * pend tests until uprn validations fixed	2 years ago
kosiakkatrina	af6b6bc03d	CLD-1857 Update household characteristics section (#1249 ) * Update datails known numbering in the db * Update check answers card headers * Display same person pges for joint and non-joint purchase * Only display person questions once * Remove unused person class and methods * Always display person known pages and update headers * Fix depends on, show retirement validation for buyer 2 * test * Add person 5 to test * fix context description * Display person known question for appropriate number of other household members * tests * update test * Remove page id stubbing * Remove redundant tests * only put validation on the pages that are routed to * Refactor tests	2 years ago
Arthur Campbell	fbb67f5fab	CLDC-1923 amend validation message for single ended ranges (#1253 ) * replace range validation with multiple to account for single-ended ranges * add test for question with min but no max * add min and max to household count question and remove bespoke validation. Remove code allowing max and no min given this situation does not seem to exist int eh form * amend minor typo, add back a soft validation that had mysteriously gone missing	2 years ago
Arthur Campbell	648e344af6	CLDC-1786 add validations for staircasing transaction (#1235 ) * change percent to % so that suffix is consistent with other similar questions * fix rebase conflicts * add hard validation that percentage owned after a staircasing transaction cannot be less than the percentage bought in that transaction, with associated tests * add compound validation to ensure that logs of type older person shared ownership may not have a stairbought value of greater than 75% \n associated tests included * remove duplicate method and use existing version * fix rebase conflicts * ensure schema correct and test of page number correct * fix form handler test after rebase * fix tests and ensure schema correct after rebase	2 years ago
kosiakkatrina	8ca9cbfb49	Change numeric validation to display prefixes in error message (#1227 ) * change numeric validation * Fix test, add delimiter and suffix to the numeric error mesage	2 years ago
Phil Lee	af8e10764f	Validate radio values are possible (#1137 ) * validate radio values are possible * feature toggle possible radio option validation	2 years ago
James Rose	d3075e4e43	Revert to `f4e6d6d6bb` (#887 )	2 years ago
natdeanlewissoftwire	f162f880ae	Revert "Merge remote-tracking branch 'origin/main' into CLDC-1429-output-la-code" This reverts commit `626e2bd1a6`, reversing changes made to `f86e13cea7`.	2 years ago
kosiakkatrina	ac4ee2a1fb	Cldc 1600 refactor form handler (#875 ) * Add previous, current and next forms to form handler * Add current, previous and next sales forms to form handler * Implement current_lettings_form, current_sales_form and store year and form type in form * refactor lettings_forms * Use current, previous and next forms in lettings log model * Use current, previous and next forms in sales log model * use current, previous and next forms in csv service * Remove "startyear_endyear" forms from form handler * Remove name from form initializer and add an optional start year * refactor get_form * update csv test, fix form initialize * rebase fix * Refactor form_name_from_start_year method out * remove unused variable * fix typo, add date tests * rebase, fix tests * add comment to before test block * Change the FormHandler back to only contain the form objects * extract name	2 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	c2c49924a3	Cldc 491 rent and charges validations (part 1) (#388 ) * move age validation tests to shared validation spec * Add brent/tshortfall validation * update period mappings * Add scharge validation * update num of weeks from period mapping * fix test * change period mappings in test * Add tests for floats * change error message content * add supported housing scharge validation * add other landlord validations * refactor * refactor validation and tests * Add supcharg validations and refactor * add total charge calculations * move constants * Fix tests and add missing validation messages	3 years ago

12 Commits (0a78a168f3179c3c1ac7f71e3f8b8e3085088124)