submit-social-housing-lettings-and-sales-data

3517 Commits

251 Branches

297 Tags

88 MiB

Tree: 1283dee7cc

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Samuel Young	98c58cc19a	CLDC-4142: New question on gender same as sex - lettings (#3161 ) * CLDC-4142: Add new cols to database * CLDC-4142: Add questions to flow optimise household_characteristics as there's a lot of repeated code. should make the sections a bit easier to manage * CLDC-4142: Add conditional description question seems to largely just work without needing major tweaks * CLDC-4142: Ensure description if nil if not shown looks like there's no automated process for this. without this the description will be "" if not given * CLDC-4142: Add new question to log factory * CLDC-4142: Add new fields to BU parser update BU template file to match * CLDC-4142: Add new fields to BU file generator * CLDC-4142: Add new fields to xml export also improve xml export matcher to report differences * CLDC-4142: Add final question numbers * CLDC-4142: Add question specs * CLDC-4142: Add a PERSON_DETAILS override for gender_same_as_sex this ensures if details aren't known the field will be redacted * CLDC-4142: Update model tests * CLDC-4142: Update CSV export service tests * CLDC-4142: Update other tests * fixup! CLDC-4142: Update CSV export service tests update sales variable definitons too * fixup! CLDC-4142: Ensure description if nil if not shown update inferral method name and comment * CLDC-4142: Update CYA copy as requested cya for gender_same_as_sex 'no' instead of 'no, enter gender description' cya for gender_description has the label 'gender identity description' * CLDC-4142: Use label_from_value for custom CYA text this replaces @inferred_check_answers_value so it'll work in CSV export too	2 weeks ago
Nat Dean-Lewis	8c79d152b2	CLDC-4141: New sex registered at birth question for lettings logs (#3171 ) * CLDC-4177: Create new sex-at-birth question * CLDC-4177: Update database * CLDC-4177: Adds SAB form for the primary buyer. * CLDC-4177: Adds sex-at-birth question for other household members * CLCD-4177: Unit tests * CLDC-4177: Misc inclusions where sex is also used * CLDC-4177: Lint fixes * CLDC-4177: Do not include sexRAB in pre-2026 exports * CLDC-4177: Fixes bug with copy key in new page * CLDC-4177: Changes logic used to decide which fields to export * CLDC-4177: Linting fixes * CLDC-4177: Converts new field to lowercase * CLDC-4177: Satisfy bulk upload tests (not tested manually) * CLDC-4177: Rename new fields to lowercase * CLDC-4177: Rename field in bulk upload. * CLDC-4141: Update database * CLDC-4141: New question and page models * CLDC-4141: Adds the new sab questions to the form * CLDC-4141: Update locales * CLDC-4141: Export sab questions * CLDC-4141: change buyer -> lead tenant for lettings log sexrab1 * CLDC-4141: enable sexrab questions for lettings log persons 2-8 * CLDC-4141: update row parser * CLDC-4141: update csv service * Fix db casing * CLDC-4141: update schema (nonfunctional change) * CLDC-4141: update row parser expected fields * CLDC-4141: use correct lettings q * CLDC-4141: update page and question tests * CLDC-4141: update subsection test * CLDC-4141: update row parser test * CLDC-4141: linting * CLDC-4141: remove frozen string literals * CLDC-4177: remove frozen string literals * CLDC-4141: fix person casing typo * Delete redundant migration * CLDC-4141: revert fields count change * CLDC-4141: update row parser spec * CLDC-4141: revert export service change * Revert "CLDC-4141: revert export service change" This reverts commit `c43ff40006`. * CLDC-4177: Create new sex-at-birth question * CLDC-4177: Update database * CLDC-4177: Adds SAB form for the primary buyer. * CLDC-4177: Adds sex-at-birth question for other household members * CLCD-4177: Unit tests * CLDC-4177: Misc inclusions where sex is also used * CLDC-4177: Lint fixes * CLDC-4177: Do not include sexRAB in pre-2026 exports * CLDC-4177: Fixes bug with copy key in new page * CLDC-4177: Changes logic used to decide which fields to export * CLDC-4177: Linting fixes * CLDC-4177: Converts new field to lowercase * CLDC-4177: Satisfy bulk upload tests (not tested manually) * CLDC-4177: Rename new fields to lowercase * CLDC-4177: Rename field in bulk upload. * Fix db casing * CLDC-4177: remove frozen string literals * Delete redundant migration * Remove extraneous lines from schema.rb * Add new sexrab fields to the :completed trait in the Sales Log factory * CLDC-4141: partial csv download test update * CLDC-4141: update csv conversion rake task * CLDC-4141: untrack temp csv export files * CLDC-4141: update remaining csv tests * CLDC-4141: fix schema since latest changes * CLDC-4141: update schema * CLDC-4141: revert breaking export service changes * CLDC-4141: update var def spec * CLDC-4141: update var def spec * CLDC-4141: update var def spec * CLDC-4141: update BU test file * CLDC-4141: update validator specs * CLDC-4141: update csv_parser columns * CLDC-4141: linting * CLDC-4141: linting * CLDC-4141: linting * CLDC-4141: update person_n_present methods * CLDC-4141: remove redundant MAX_COLUMNS check * CLDC-4141: avoid sales changes in this PR, will leave to CLDC-4177 * CLDC-4141: use FIELDS const where can be shared * CLDC-4141: revert FIELDS sharing * CLDC-4141: update export services tests * CLDC-4141: include fields rather than omitting in lettings_log_export_service.rb * CLDC-4141: share default 2026 field count * CLDC-4141: cleanup export field filtering * CLDC-4141: simplify export year filtering * CLDC-4141: use FIELDS to check max_columns * CLDC-4141: update 2026_27 manual test fixture * CLDC-4177: remove redundant inferred CYA vals * CLDC-4141: remove redundant inferred CYA vals * CLDC-4177: update bu files * CLDC-4177: update sales log export service * CLDC-4141: remove redundant field filtering * CLDC-4141: reinstate old comment * CLDC-4141: reinstate old comment * CLDC-4141: rename var def file * CLDC-4141: update variable definitions tests * CLDC-4141: update schema * CLDC-4177: update schema * CLDC-4177: linting * CLDC-4177: linting * CLDC-4141: update csv fixtures * CLDC-4177: update sales log export constants * CLDC-4177: update factories * CLDC-4177: lint * CLDC-4177: csv parser updates * CLDC-4177: bu field updates * CLDC-4177: update var def spec * CLDC-4141: Add final question numbers (CLDC-4202) * CLDC-4141: make to_2026_row explicit * CLDC-4177: make to_2026_row explicit * CLDC-4177: use shared field count * CLDC-4177: refactor to remove max cols going forwards * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: update schema * CLDC-4141: remove X from factory options * CLDC-4177: update log var defs * CLDC-4177: use correct shared field count * CLDC-4177: remove trailing commas * CLDC-4177: update log var defs * CLDC-4177: update bulk upload csv example * CLDC-4141: update bulk upload csv example * CLDC-4177: update bulk upload csv example * CLDC-4177: remove sexrab from expected sales export for now * CLDC-4141: correct csv service expectations * CLDC-4141: don't sample X for sexrab --------- Co-authored-by: Katherine Langford <katherine.langford@softwire.com> Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com> Co-authored-by: Samuel Young <samuel.young@softwire.com>	3 weeks ago
Samuel Young	407f7d87bd	CLDC-4105: Add new working situation and long-term illness validation (#3147 ) * CLDC-4105: Add working situation illness check to log fields * CLDC-4105: Add soft validation to main flow * CLDC-4105: Add tests soft validations models add a label file for this year so the export_codes tests have authentic labels to pull the old BU completed log answers throw the new soft validation. needed to change illness to 3 to avoid the soft validation as it should be a complete log * fixup! CLDC-4105: Add working situation illness check to log fields * fixup! CLDC-4105: Add soft validation to main flow remove unneeded coalesce remove unneeded variable * fixup! CLDC-4105: Add tests fix after rebase * fixup! CLDC-4105: Add soft validation to main flow account for if hhmemb is not answered	3 weeks ago

Samuel Young

98c58cc19a

CLDC-4142: New question on gender same as sex - lettings (#3161 )

* CLDC-4142: Add new cols to database

* CLDC-4142: Add questions to flow

optimise household_characteristics as there's a lot of repeated code. should make the sections a bit easier to manage

* CLDC-4142: Add conditional description question

seems to largely just work without needing major tweaks

* CLDC-4142: Ensure description if nil if not shown

looks like there's no automated process for this. without this the description will be "" if not given

* CLDC-4142: Add new question to log factory

* CLDC-4142: Add new fields to BU parser

update BU template file to match

* CLDC-4142: Add new fields to BU file generator

* CLDC-4142: Add new fields to xml export

also improve xml export matcher to report differences

* CLDC-4142: Add final question numbers

* CLDC-4142: Add question specs

* CLDC-4142: Add a PERSON_DETAILS override for gender_same_as_sex

this ensures if details aren't known the field will be redacted

* CLDC-4142: Update model tests

* CLDC-4142: Update CSV export service tests

* CLDC-4142: Update other tests

* fixup! CLDC-4142: Update CSV export service tests

update sales variable definitons too

* fixup! CLDC-4142: Ensure description if nil if not shown

update inferral method name and comment

* CLDC-4142: Update CYA copy as requested

cya for gender_same_as_sex 'no' instead of 'no, enter gender description'

cya for gender_description has the label 'gender identity description'

* CLDC-4142: Use label_from_value for custom CYA text

this replaces @inferred_check_answers_value so it'll work in CSV export too

2 weeks ago

Nat Dean-Lewis

8c79d152b2

CLDC-4141: New sex registered at birth question for lettings logs (#3171 )

* CLDC-4177: Create new sex-at-birth question

* CLDC-4177: Update database

* CLDC-4177: Adds SAB form for the primary buyer.

* CLDC-4177: Adds sex-at-birth question for other household members

* CLCD-4177: Unit tests

* CLDC-4177: Misc inclusions where sex is also used

* CLDC-4177: Lint fixes

* CLDC-4177: Do not include sexRAB in pre-2026 exports

* CLDC-4177: Fixes bug with copy key in new page

* CLDC-4177: Changes logic used to decide which fields to export

* CLDC-4177: Linting fixes

* CLDC-4177: Converts new field to lowercase

* CLDC-4177: Satisfy bulk upload tests (not tested manually)

* CLDC-4177: Rename new fields to lowercase

* CLDC-4177: Rename field in bulk upload.

* CLDC-4141: Update database

* CLDC-4141: New question and page models

* CLDC-4141: Adds the new sab questions to the form

* CLDC-4141: Update locales

* CLDC-4141: Export sab questions

* CLDC-4141: change buyer -> lead tenant for lettings log sexrab1

* CLDC-4141: enable sexrab questions for lettings log persons 2-8

* CLDC-4141: update row parser

* CLDC-4141: update csv service

* Fix db casing

* CLDC-4141: update schema (nonfunctional change)

* CLDC-4141: update row parser expected fields

* CLDC-4141: use correct lettings q

* CLDC-4141: update page and question tests

* CLDC-4141: update subsection test

* CLDC-4141: update row parser test

* CLDC-4141: linting

* CLDC-4141: remove frozen string literals

* CLDC-4177: remove frozen string literals

* CLDC-4141: fix person casing typo

* Delete redundant migration

* CLDC-4141: revert fields count change

* CLDC-4141: update row parser spec

* CLDC-4141: revert export service change

* Revert "CLDC-4141: revert export service change"

This reverts commit c43ff40006.

* CLDC-4177: Create new sex-at-birth question

* CLDC-4177: Update database

* CLDC-4177: Adds SAB form for the primary buyer.

* CLDC-4177: Adds sex-at-birth question for other household members

* CLCD-4177: Unit tests

* CLDC-4177: Misc inclusions where sex is also used

* CLDC-4177: Lint fixes

* CLDC-4177: Do not include sexRAB in pre-2026 exports

* CLDC-4177: Fixes bug with copy key in new page

* CLDC-4177: Changes logic used to decide which fields to export

* CLDC-4177: Linting fixes

* CLDC-4177: Converts new field to lowercase

* CLDC-4177: Satisfy bulk upload tests (not tested manually)

* CLDC-4177: Rename new fields to lowercase

* CLDC-4177: Rename field in bulk upload.

* Fix db casing

* CLDC-4177: remove frozen string literals

* Delete redundant migration

* Remove extraneous lines from schema.rb

* Add new sexrab fields to the :completed trait in the Sales Log factory

* CLDC-4141: partial csv download test update

* CLDC-4141: update csv conversion rake task

* CLDC-4141: untrack temp csv export files

* CLDC-4141: update remaining csv tests

* CLDC-4141: fix schema since latest changes

* CLDC-4141: update schema

* CLDC-4141: revert breaking export service changes

* CLDC-4141: update var def spec

* CLDC-4141: update var def spec

* CLDC-4141: update var def spec

* CLDC-4141: update BU test file

* CLDC-4141: update validator specs

* CLDC-4141: update csv_parser columns

* CLDC-4141: linting

* CLDC-4141: linting

* CLDC-4141: linting

* CLDC-4141: update person_n_present methods

* CLDC-4141: remove redundant MAX_COLUMNS check

* CLDC-4141: avoid sales changes in this PR, will leave to CLDC-4177

* CLDC-4141: use FIELDS const where can be shared

* CLDC-4141: revert FIELDS sharing

* CLDC-4141: update export services tests

* CLDC-4141: include fields rather than omitting in lettings_log_export_service.rb

* CLDC-4141: share default 2026 field count

* CLDC-4141: cleanup export field filtering

* CLDC-4141: simplify export year filtering

* CLDC-4141: use FIELDS to check max_columns

* CLDC-4141: update 2026_27 manual test fixture

* CLDC-4177: remove redundant inferred CYA vals

* CLDC-4141: remove redundant inferred CYA vals

* CLDC-4177: update bu files

* CLDC-4177: update sales log export service

* CLDC-4141: remove redundant field filtering

* CLDC-4141: reinstate old comment

* CLDC-4141: reinstate old comment

* CLDC-4141: rename var def file

* CLDC-4141: update variable definitions tests

* CLDC-4141: update schema

* CLDC-4177: update schema

* CLDC-4177: linting

* CLDC-4177: linting

* CLDC-4141: update csv fixtures

* CLDC-4177: update sales log export constants

* CLDC-4177: update factories

* CLDC-4177: lint

* CLDC-4177: csv parser updates

* CLDC-4177: bu field updates

* CLDC-4177: update var def spec

* CLDC-4141: Add final question numbers (CLDC-4202)

* CLDC-4141: make to_2026_row explicit

* CLDC-4177: make to_2026_row explicit

* CLDC-4177: use shared field count

* CLDC-4177: refactor to remove max cols going forwards

* CLDC-4141: update schema

* CLDC-4141: update schema

* CLDC-4141: update schema

* CLDC-4141: update schema

* CLDC-4141: remove X from factory options

* CLDC-4177: update log var defs

* CLDC-4177: use correct shared field count

* CLDC-4177: remove trailing commas

* CLDC-4177: update log var defs

* CLDC-4177: update bulk upload csv example

* CLDC-4141: update bulk upload csv example

* CLDC-4177: update bulk upload csv example

* CLDC-4177: remove sexrab from expected sales export for now

* CLDC-4141: correct csv service expectations

* CLDC-4141: don't sample X for sexrab

---------

Co-authored-by: Katherine Langford <katherine.langford@softwire.com>
Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>
Co-authored-by: Samuel Young <samuel.young@softwire.com>

3 weeks ago

Samuel Young

407f7d87bd

CLDC-4105: Add new working situation and long-term illness validation (#3147 )

* CLDC-4105: Add working situation illness check to log fields

* CLDC-4105: Add soft validation to main flow

* CLDC-4105: Add tests

soft validations

models

add a label file for this year so the export_codes tests have authentic labels to pull

the old BU completed log answers throw the new soft validation. needed to change illness to 3 to avoid the soft validation as it should be a complete log

* fixup! CLDC-4105: Add working situation illness check to log fields

* fixup! CLDC-4105: Add soft validation to main flow

remove unneeded coalesce

remove unneeded variable

* fixup! CLDC-4105: Add tests

fix after rebase

* fixup! CLDC-4105: Add soft validation to main flow

account for if hhmemb is not answered

3 weeks ago

3 Commits (1283dee7cc8a75e9d4108ca174d9ddb29378476b)