submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	02c41333f6	Cldc 1669 add location redesign (#1034 ) * feat: wip postcode page * feat: wip add new flow * feat: add check answers page, continue updating flow * feat: add back behaviour * feat: more flow work * feat: further flow work and flash notice, name tidying * feat: add check_answers referrer linking * feat: add controller and details linking and lint * refactor: erblinting * feat: add local_authority page (currenlty separate from edit_local_authority to avoid conflict with add location to newly created scheme path, to be fixed later). also copy and routing updates * feat: add validations to controller (could later be added to model) * fix: correct date order * feat: validate on model (except startdate) * feat: copy update * refactor: railsification * feat: add date model validation * feat: add updated availability text in check_answers * feat: more updated dynamic text and linking * refactor: erblinting * refactor: cleanup of redundant code * refactor: remove redundant create * feat: use rails route * test: wip tests * test: wip tests * feat: add new back behaviour for new scheme path and tests wip * feat: add more back behaviour for new scheme path and fix local auth validation * feat: further linking behaviour with routes and referrers, don't add new location automatically to new schemes * feat: if location with no details added, route to normal path rather than check answers * test: update model and helper location tests * test: more test updates * test: more test updates and remove redundant files * test: remove redundant tests, add postcode test * test: add new #new tests * test: add test for all new controller methods * test: add more startdate tests * refactor: erblinting * test: fix failing tests * test: update scheme test * feat: respond to PR comments * feat: make postcode clear only if changed * feat: add _update methods * refactor: simplify validation and location_edit_path method * refactor: add helper method for action text * refactor: remove redundant logic * refactor: simplify routing * refactor: reintroduce location_params * refactor: use presence validation for postcode * refactor: use presence validation for la * feat: validate confirmed * tests: make tests pass with new startdate validation * WIP * refactor: simplify display attributes helpers and update tests * refactor: linting * feat: design change to save behaviour * test: fix failing tests * feat: location code copy tweak * refactor: remove redundant function * refactor: remove add_another_location and new location page * feat: simplify startdate validations to move to model, use scheme available_from date for in range validation * test: fix failing tests * refactor: linting * feat: remove name validation as a result of PO review * test: update tests * refactor: remove redundant context Co-authored-by: James Rose <james@jbpr.net>	2 years ago
Sam	f32bbaa849	CLDC-1688 scheme change mailer (#1040 ) * CLDC-1688 Affected logs mailer * CLDC-1688 Correct update_logs path * CLDC-1688 Review markups Co-authored-by: James Rose <james@jbpr.net> Update app/controllers/schemes_controller.rb Co-authored-by: James Rose <james@jbpr.net> Update app/controllers/locations_controller.rb Co-authored-by: James Rose <james@jbpr.net> * Refactor to queue messages * Update test * remove irrelevant test Co-authored-by: James Rose <james@jbpr.net> Co-authored-by: Kat <katrina@kosiak.co.uk>	2 years ago
kosiakkatrina	2cbb3080b5	Add sorting per org (#1039 ) * Add sorting per org * Pull out confirmed set to null because they're also not marked as confirmed * Create relevant tests * Extract scopes and remove wrong test	2 years ago
kosiakkatrina	497f16ba9b	Cldc 1668 update impacted logs (#1035 ) * Mark log as impacted by deactivation when location is deactivated * Display affected logs in the table * Route affected logs to tenancy start date question * Update routes to get the tenancy start date page from form * update next_page_redirect_path * rename column * Fix tests * Add next_unresolved_page_id to pages * Update unresulved when the log is corrected * Mark logs as unresolved when scheme gets deactivated * display correct content when there are no unresolved logs * mark logs resolved after the user leaves check answers page * Display link in success banner and reset banner when the link is clicked * display inset hint text for unresolved log questions * Display unresolved logs banner * update banner message * Persist the link in the banner * update inset text * Update success banner text * Add unresolved and created_by scopes * rename method * add unresolved_log_redirect_page_id to form + typo and route * Add UnresolvedLogHelper and extract flack notice message * pluralize and return early * remove flash[:notice] = nil * to keep it consistent for sales log * Extract unresolved path and fix a link * extract resolve method and fix attribute nme * update path * typo	2 years ago
kosiakkatrina	3a60c4cd02	Deactivation does not affect logs (#1018 ) * Update affected logs count and skip the confirmation page if no logs are affected for locations * Update affected logs count and skip the confirmation page if no logs are affected for schemes * refactor	2 years ago
kosiakkatrina	41c726ce9c	Add a default ordering for schemes (#1030 ) * Add a default ordering for schemes * Move ordering back to the controller * Update app/controllers/schemes_controller.rb Co-authored-by: James Rose <james@jbpr.net> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
natdeanlewissoftwire	879cdea47f	Cldc 1672 scheme reactivation (#1023 ) * feat: add scheme reactivation behaviour * test: add tests * refactor: linting * fix: find deactivation periods by scheme/location ids rather than just the first * feat: add activating_soon status to location (not to schemes as they have no startdate field) * feat: fix logic and add tests fo activating soon * fix: check for startdate presence	2 years ago
kosiakkatrina	11bb9c887c	Cldc 1670 reactivate locations (#1007 ) * route deactivated scheme to reactivation page * Render correct reactivate question content * refactor into a helper * display successful reactivation banner for default date * Save reactivation date * Add reactivation errors * lint and fix url in tests * make toggle translations generic * Add reactivation status * Reuse date validation messages * Show deactivate this location when location is reactivating soon * Display correct confirmation banner * Add validation for reactivation date before deactivation date * Improve availability label * Use current collection start date if created at is later than that * Update paths * Fix controller and don't display the previous day if location availability start afterwards * refactor availability label * Filter out active periods * lint * Refactor active_period method into the model * Allow deactivations and reactivations from available from date instead of start of the collection date * Prevent deactivations during deactivated periods * lint * typo * Remove active periods that last 1 day (because they get deactivated on the same day) * Move the active_periods into helper * extract remove_overlapping_and_empty_periods into a separate method * Remove nested deactivation periods * Make deactivate/reactvate location form use location_deactivation_period model * refactor toggle date methods * extract shared condition * update validations * refactor validations * Update schemes deactivation form to use dectivation model * Refactor * lint * remove redundant location_id and update scheme controller * update active_periods	2 years ago
kosiakkatrina	752103404f	Multiple scheme deactivations (#1004 ) * Remove deactivation date from schemes and add scheme deactivation periods table * Update affected logs when a scheme gets deactivated * Update status method * Display availability timeline * Update flash notice message	2 years ago
natdeanlewissoftwire	87793f24bd	Cldc 1671 deactivate scheme (#980 ) * feat: wip update scheme summary page * feat: wip deactivate scheme schemes page * feat: wip toggle active page * feat: wip set deactivation_date to a datetime (to be more specific times later_ * Change conditional question controller to accommodate all models * feat: add specific datetimes for deactivation * feat: correct date and add notice * feat: wip error behaviour * feat: wip errors * feat: wip errors refactoring * feat: wip errors more refactoring * refactor: linting * feat: add second error in correct position and wip date range error * feat: remove unneccessary db field * feat: change type values to strings * refactor: tidy up controller logic * refactor: use same structure as locations deactivation * feat: add general partially missing date input error * feat: add tests ("updates existing scheme with valid deactivation date and renders scheme page" still wip) and add new partially nil date behaviour to locations controller * feat: fix tests, add status tag behaviour and remove unnecessary nils * refactor: linting * refactor: erblinting * refactor: remove redundant line * refactor: respond to PR comments 1 * refactor: respond to PR comments 2 * refactor: respond to PR comments 3 * refactor: respond to PR comments 3 (locations side) * fix: remove @locations in location model * fix: remove @locations in location model * fix: update status names * feat: wip validation update * feat: add validation to model layer * feat: further separate scheme deactivation behaviour * test: update tests to new flow * feat: respond to pr comments and add dynamic success text * feat: duplicate behaviour schemes -> locations (+ tests) * refactor: linting * refactor: typo and remove unnecessary line for this PR * refactor: feature toggle simplification * Refactor locations and schemes controller actions - Rename confirmation partials to `deactivate_confirm.html.erb` so that they match the actions in which they belong to - Make all deactivation date comparision UTC time * feat: update deactivation_date validation and add tests * refactor: linting Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	ef354fada6	Update routes (#978 ) * Update routes * Remove member from routes	2 years ago
kosiakkatrina	bd0173fed0	Cldc 1394 schemes cya (#797 ) * Mark scheme location as confirmed * Route to check your answers after any changes are made to the scheme. Display change for all editable fields * Add some functionality * Display banners and redirect to check answers after editing location name * Remove a test * update locations confirmation * reuse can_change_scheme_answer? * Use path helpers * Redirect to view scheme when trying to access create form pages for the scheme (cherry picked from commit `761bf97dc2`) * add before action for confirmed schemes * update location path * lint Co-authored-by: Dushan Despotovic <dushan@madetech.com>	2 years ago
baarkerlounger	d732c59c97	Return 404 when scheme not found (#804 ) * Return not found for schemes when... not found * Redundant check * Apply to all member actions * Add not found checks for location	2 years ago
kosiakkatrina	044c4a5dc4	Cldc 1377 scheme status (#775 ) * reset managing org for sheme * only display schemes with managing org id * only display relevant answers in show scheme page * tests * check arrangement type from saved scheme if incoming params for it is nil * don't override managing org id if it's coming through as nil * convert to use values that won't change for checks * Revert "convert to use values that won't change for checks" because the value coming through from the params is the value and not a key This reverts commit 50053ec0cf233e3a6c36db9af2528c354d3d60e7. * Test * check constant values * Add test case for controller, check if the scheme is confirmed before displaying * validate all the required scheme questions are answered * fix ui * fix test * Add test, change error message wording * Display error message next to the relevant field * update context and query * lint Co-authored-by: Dushan Despotovic <dushan@madetech.com>	2 years ago
baarkerlounger	610dad81a8	CLDC-1382: Add location and search to scheme locations (#756 ) * Add search * Add "Add location" button * Add confirmed flag to schemes * Show location tab is location is being added to an existing scheme * Switch button text when scheme exists already * Remove change links for confirmed schemes * Fix spec after rebase * added title showing search results and tests for it Co-authored-by: JG <moarpheus@gmail.com>	2 years ago
Dushan	bc618e2ab9	Fix data mapping for mantype (#761 ) * Fix data mapping for mantype This was mapped to a column called support services provider which was an integer, this now maps to the arrangement type column. This should be in line with expectations for the import/export * remove unused stuff * lint fixes * changes to comparison * fix lambda checks in view * fix export test	2 years ago
J G	9d384d6b50	CLDC-1348 basic validation for scheme and location + front update (#730 ) * validation error messages for scheme * WIP for validations * fixed redirects for a correct page * expecting link to a new question * added support_services_provider * WIP for support_services_provider * WIP for support_services_provider - works concenptually * WIP passing feature tests * WIP passing feature tests * WIP validations * passing tests and working functionality * location validations * fixed after rebasing * fixed edit name * fixed after rebasing * tests for missing params * tests for validations * tests for validations locaion * tests for validation of all params for scheme * tests for location validations * What is this type of scheme? - Order options alphabetically: * Care Standards Act 2000? - Order options as follows, add missing hint text for third option * further styling * last UI changes * lmoved back button logic to the view * select options in the view * missing validation for manaing org * fixed check answers page * wip * small change * fixed * fixed check answers page ui * fixed updating * fixed tests * fixed layout * final touches * rebase * rubocop * correct condition * old test	2 years ago
J G	8c6dc56f5e	CLDC-1291 Permitted user can edit scheme name (#717 ) * feature to test editing a scheme * adding editing buttons * adding scheme_edit_name route * controller tests for editing name * edit-name template missing * edit-name controller action * edit-name controller action - leftovers * padding for checkbox fieldset * added Which organisation owns the housing stock for this scheme? to the check * testing editing name via controller * last test * lint * wrong button name * legend is gone * Save changes	3 years ago
J G	19bb7e98fd	Fixed failed scheme editing (#716 ) Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com>	3 years ago
Stéphane Meny	e77c89b46c	CLDC-1128: Scheme organisations renaming (#712 ) Rename owning and managing organisations for schemes	3 years ago
J G	5eac424384	CLDC-1337-permitted-user-can-add-location-when-creating-scheme (#704 ) * added last step * not finding postcode field * testing being direct to add locations page after submitting support questions * added route to locations controller * location controller spec * location controller * added template for new * next step in feature * added postcode * added name to locations * removed total units from schemes * moved total units to locations * changed type of unit type in db * using type of units * add locations page is finished * purged total units and added test for location create * creating location * testing creating location as data provider * fixed factory * refacotred update/create and added test creating location as a coord user * testing returning back to create page if create another location is selected * testing returning back to create page if create another location is selected - part 2 * thanks rubocop * thanks rubocop * testing back from new location * returned tests back * testing clickable locations link * testing clickable locations link under correct context * correctly looking table * table with caption * wip * fixed failing exisiting tests * fixed failing exisiting tests - part 2 * validating postcode case logs style * validating postcode specs * validating postcode specs debugger removed * navigation when editing location * spike creating new location after addition * small refactoring * added test to add another location from locations page * added test to amend a location * added test to amend a location - part 2 * testing location cell * added wheelchair adaptions to the unit tyupe * rebased * testing postcode missing * testing creating schem for a different org for coordinator * testing new scheme for a different org for coordinator * upcasing all postcodes before creation * testing edge cases around postcodes and yes or no for another location * create locations with support user * details locations specs * update locations specs * rubocop * checking raising error * fixed failed test * switched yes and no for wheelchairs * routes refactoring * fixed routing - WIP * further chanegs * feature tests passing * correct page when errros * redundant page * moving viewing locations away from schemes controller * new is fixed * create fixed * fixed locations specs * fixed tab nav specs * completed location specs * lint	3 years ago
J G	7815965af1	CLDC-1290 Permitted user can create a new scheme (#671 ) * added test to find link to create a new scheme * added button to create a new scheme * testing arriving to the new scheme form * non exsiting link to controller new action * SPIKEEEE * first page complete * posting to create * refactored scheme to enums * refactored new scheme page to use enums as well * views * SPIKE WIP * SPIKE WIP * SPIKE WIP * drawing list of scheme details * expanded on feature seeing more fields to fill in * expanded on feature seeing more fields to fill in 2nd page * refactored * working back buttons * working flash * more change in wip * default value for org * working spike * some spacing * filling answers * spike finished * correct name for details * testing fill in details * removed gem and further tests * Add has other client group field to schemes. Display it in the check answers. Fix tests and routing * remove details view and path Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * WIP change update paths * Implement changing answers (except the details one) * Add details page back for editing scheme details * added missing test for support questions and nested check answers under correct context * checking the back functionality * rubo and lint * checking the back functionality for primary gourp * checking the back functionality for confirm secondary * checking the back functionality for secondary group * checking the back functionality for support answers * checking the back functionality for returning to check answers from details page * checking the back functionality for returning to check answers from primary group page * checking the back functionality for secondary group confirm yes * checking the back functionality for secondary group confirm yes - fixed * checking the back functionality for secondary group * checking the back functionality for secondary group -fixed * checking the back functionality for returning from support page * Do not display secondary client group if the scheme doesn't have one * Add details path to schemes controller update method * Add more tests for back button * Add tests for new controller method * Add tests for creating schemes as data coordinator * fixed schema * added test for missing params when creating scheme * create for support user with or withotu required param * code to get controller render errors when required param is missing * code to implement correct validation * code to implement correct validation - part 2 * highlight missing field * doing silly dance to get correct field highlighted on the error * testing patch for schemes * testing patch for schemes - correct path * small refactoring * testing primary client group update via regular path * testing primary client group update via check answers page * testing confirm secondary group update with YES NO and returning from check answers page * testing updating secondary client group update and returning from check answers page * testing support answers and returning from check answers page * testing details and returning from check answers page * weird path when no names supplied * rubocop * lost in rebasing * started id to code refactoring * model specs remastered * fixed scheme controller specs * further refactorings * fixing feature schemes * final touches * removed code from db * remaining code purged * rubocop * included check for owning org field * checking for stock owning org selection * added stock owning org * added stock owning org on new page * added stock owning org to details * removed total units * managing related schems properly via Org * managing related schems properly via Org - rubocop * small refactoring * small refactoring - 2 * small refactoring - 3 * tests for owned_schemes and managed_schemes * rubocop * added tests for support user creating scheme * rubocop -a * tests for a primary-client-group * tests for a secondary-client-group * tests for a confirm-secondary-client-group * tests for a check-answers * tests for a details * rubocop * redundant action in controller * Trigger WF * switched to int for confirm * flashing test * flashing test for support user * flashing test rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	3 years ago
J G	0c4a81ea7a	Cldc 1307 supported housing scheme locations (#669 ) * failing test for having service and location tabs on the show page * links on the page * asking for locations in the link * created locations * linked locations to schemes * locations migration and model * testing seeing locations * rubocop * failing feature to see locations on the page * route to locations * controller action plus other bits * added facatory and view for locations * supported housing to schemes * supported housing to schemes - part 2 * supported housing to schemes - part 3 * correct route * controller test for locations * added view for locations * correct and compact view for locations * testing all attributes on the page * testing heading * testing title * refactored views * refactored views * fixed county * testing pagination * testing and coding pagy bits for locations * testing and coding pagy bits for locations page 2 * added tests for support user * small refactoring of before actions and tests for 401 and 404 * small refactoring * Trigger WF * simplified return * fixing spec failures * fixed names * testing back link * oops * required changes from comments * required changes from comments * renums * fixed failing tests * typo * Managing agent to by * tests for scheme_items	3 years ago
J G	ae377b9084	CLDC-1307 Cust Support and Coordinators can view the details of a service (#656 ) * added steps to view links to indiividual schemes * testing there are links to the schemes not just names * testing there are links to the schemes not just names -2 * added links failing due to no route * looks per spec * failing spec for tab helper * added new attributes to the scheme * added test for scheme.primary_client_group * testing clicking to individual scheme * empty template for show * testing users not signed in * testing I can see scheme details on the page * converting int to strings in scheme model * better view, seeds and factory * highlight supported housing for support user * simplified and extended sab nab logic * rubocop and redundant check removed * tests and code to make sure users are highlighted * tests and code to make sure supported housing is highlighted * full feature for support user to visit scheme show page * extended features and filing feature when coordinator viewing scheme for a different org * returning not found if coordinator user tries to see unrelated scheme * rubocop * fixed typos etc * fixed types for schemes * Trigger WF * correct expectation	3 years ago
J G	402780c53f	Cldc 1227 supported housing index (#648 ) * Added test file for supported housing schemes * Added factory bot for supported housing schemes * swapped managing agent to org for scheme * created migration for schemes * created model for scheme * added migration to add foreign key to the schemes table * missing spec and log spec for supported housing * fixed failing specs * added schemes migration * next step feature * added route * added controller * added index * added all schemes * correct test for scheme * added view * route alias for schemes * spec for index schemes * failing scheme controller spec * added simple view, scheme seed and authentication * spec for index schemes list * rubocop - thanks * better seed * added Heading to org * added feature flag to hide supported services on prod * added feature flag testing nav items * testing coordinator user can see the link to supported housing * moved toggle to a different place * moved toggle to PrimaryNavigationComponent * testing not being signed in on support pages * testing showing search bar * added search bar * testing subset of schemes for coordinator user * rubocop * failing test for title in page * code to expose title * pagination with tests without searching * partial for schemes * scoping out all but support and coord users * searching schemes code and test * searching via code and org tests * searching by org name tests * searching by org name code * search_by tests * search_by code * search_by woops must search by service * searching schemes feature * tests for data coordinator user * redirect for data coordinator user * testing org schemes for coordiantor user * schemes in org controller for coordiantor user * refactored specs moved into orgs what belongs there * view for org schemes * rubocop * accebility field * accebility field on org page * correct return when on org schemes * passing search test on the orgs page * highlight nav tab * navs helper done * rubocop * fixed failing tests for support user * correct view * how did I manage to delete this file? * checking you cant access schems unathorized * moved test * renamed service name * correct title for sup user schemes org * testing not being able to view any other orgs supported housing for coordinator user * Trigger WF * last fix * aded has many to org for schemes * rubocop Co-authored-by: Ted <ted.booton@madetech.com>	3 years ago

25 Commits (143ff51acf2922b842cb887643659b987d42e44b)