* change get_question form method to prioritise the routed to questions
* Add soft validation and interruption screen for basic rent
* get previous page that was routed to and display the same error for both soft validations
* Separate max and min error screens
* add a test for getting the previous page
* Update content and add more tests for previous page
* Show validation error if user email already exists instead of crashing
* Use translation strings
* When answer option is mapped just display directly
* Validate provider type presence
* Set up failing test for new soft validation design
* remove unneeded js controller
* remove unneeded controller and spec
* rename net income validation override column
* spec form changes (to allow tests to run)
* validation spec changes
* replace all instances of override_net_income_validatiom
* passing first test
* Add to form and import styling
* remove unneeded code from interruption screen view
* Update test & code - failing last new expectation
* Display 2 previous question answers in the informative text
* extract displaying of the informative text into a helper
* Add tests for helper
* Remove some of the previous soft validations set up
* fix some failing specs
* Fix more tests
* lint
* Reset earnings question prefix and suffix to initial values instead of nil
* make it route backwards on a no
* test and linter fixes
* refactor next_page
* stryling
* more changes
* fix specs
* update real form
* design tweaks
* delete commented out tests
* content changes
* content changes
* changes to informative/hint text
* More robust styles for interuption panel, use smart quotes
* Rubocop
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Remove enums
* Add some convenience methods to make validations more readable
* Gender chars instead of ints
* Remove incorrect API doc info for now
* More convenience methods
* Rename label from value method
* Wrapper hbrentshortfall
* Please the cop
* Change net income known question
* earnings and frequency on same page
* check answers changes and other fixes
* some fixes
* delete unnecessary test
* fix failing spec
* Refactor answer label
Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>
* test and lint fixes
* Method args
* Fix specs
* Rubocop
* Incfreq doesn't have it's own check answers display
* Add suffix to actual form
* JSON linting
* Conditional suffix only applies to check answers
* Validate that earnings and incfreq must be provided together
* Rubocop
* Fix spec
* Fix page view specs
* form fixes
* update error messages
Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Count inferred check answers answer as an answered answer :)
and remove la unknown reason field
* rename the method and add a test for gdpr completed section
* remove commented code
* fix answered questions calculation
checkbox questions were not being counted appropriately so updated the test
for the method along with the method itself
* Fix subsection status method
* change to use question completed method
Co-authored-by: Kat <katrina@madetech.com>
* Hackety hack hack
* Leave JS hooks until text conditionals are updated as well
* Fix JS errors and remove UJS
* Reload the GOV UK frontend JS
* Fix armed forces case
* Remove obsolete tests and config
* Temo fix for household members question
* Unit test
* Add helper unit test
* Correctly failing spec
* We still need stimulus to clear answers
* Fix styling issues
* Refactor style logic into helper
* Form fix
* Conditional check box questions are shown on a new page
* Update readme
* Fix date bug
* Clear conditional date fields if invalidated by top level answer
Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com>
* Add hidden text to change links
This was missing, the hidden text users the check answer label so that the
two will be consistent with each other.
* update chsnge link test
* Update app/models/form/question.rb
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* Update app/models/form/question.rb
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* update change link test
* update answer links too
* add hidden text for answer links
* fix failing tests
* update answer link with hidden text creation is now less repetetive
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* Hide total field by default
* Total charge is inferred
* We don't need to reload if we're fetching from DB anyway
* Rubocop
* Add prefixes and suffixes
* Don't count read-only questions for section status
* Add feature test for progressive enhancement
* Progressively enhance the progressive enhancement spec
* Add custom guidance partials
* Add a test for the partial being rendered
* Add some unit tests for this
* Rubocop
* Don't introduce heisenspecs
* Use component
* Add comment
* Update check values
* Make net_income_known enum
* Show inferred postcode
* Filter out the answers that were not inferred
* Refactor if statement
* Add a failing test for check answers page
* Do not show the postcode known question in check answers
* WIP - fix failing test
* Display inferred check answers value if the value is not set
* update test json
* Fix a check and method name
* Extract check for hiddent in check answers from displayed to the user
Co-authored-by: MadeTech Dushan <dushan@madetech.com>
* Refactor feature specs into smaller units
* DRY spec helpers
* Bump Turbo
* Use database ID assignment everywhere we need ID to reduce flakiness
* Update gemfile.lock
* Email is unique
* Selenium deprecation
* Don't need let bang
* Remove the uneeded extra options
* Remove flaky test mitigations that didn't work
* Use lockstep to remove test flakiness
* Dry up condition evaluation
* Spec admin user edit form
* Test income refused derivation
* Set valid incref
* Test Case Log deletion failures
* Test other household member age validations
* Test all reasonable preference validation paths
* Spec case logs admin table
* Spec admin user admin index
* Dashboard controller panel specs
* Spec panel contents
* Add create specs
* Don't assign non db ids if we don't need them
* Fix specs for new section
* Fix up fields
Paul Robert Lloyd
Dushan
Stéphane Meny
baarkerlounger
kosiakkatrina
kiddhustle
baarkerlounger