submit-social-housing-lettings-and-sales-data

3687 Commits

267 Branches

309 Tags

88 MiB

Tree: 1edf4ad979

Commit Graph

Author	SHA1	Message	Date
Samuel Young	6a655e7210	CLDC-4325: Check tests will run on go live day (#3250 ) * CLDC-4325: Set date to 2026 * CLDC-4325: Fix sale information % tests I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests * CLDC-4325: Fix check answers spec * CLDC-4325: Fix old rake task tests * CLDC-4325: Fix sales soft validations * CLDC-4325: Fix collection resources controller spec * CLDC-4325: Only add noms and org to CSV row if prp in most cases this was done by default but some tests construct an invalid log * CLDC-4325: Fix lettings household validations spec * CLDC-4221: Add 2026 collection deadlines * CLDC-4325: Fix remaining model specs * CLDC-4325: Fix form controller spec * CLDC-4325: Fix hhmemb spec * CLDC-4325: Fix duplicate logs controller spec also introduce a new helper for a dynamic way of setting year * CLDC-4325: Fix sales BU validator spec * CLDC-4325: Fix check answers summary component * CLDC-4325: Remove 2024 rake * CLDC-4325: Use or later in all touched tests * CLDC-4325: Fix guidance helper spec * CLDC-4325: Run all tests now and in 2026 * CLDC-4325: Turn off 2026 override * CLDC-4325: Add a corresponding return to timecop missing one * CLDC-4325: Fix sales log spec in 2025 need to use let rather than let! so the timecop can run first * CLDC-4325: Fix lettings log derived spec in 2025 timecop required for the start dates to work * CLDC-4325: Turn the 2026 override on again * fixup! CLDC-4325: Fix check answers summary component * CLDC-4325: Delete recalculate_reasonpref_dontknow rake only needed for 2024 logs * fixup! CLDC-4325: Fix lettings household validations spec Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> * fixup! CLDC-4325: Fix sales log spec in 2025 * fixup! CLDC-4325: Fix sales log spec in 2025 * CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests in current day * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 2nd april * CLDC-4325: Properly run tests on current day * fixup! CLDC-4325: Fix sales soft validations * fixup! CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 1st april * CLDC-4325: Run tests on 2nd april * CLDC-4325: Revert time travel --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>	4 months ago
Manny Dinssa	9f6c1d55ef	CLDC-3980: Add ability to change organisation's name with a startdate (#3058 ) * Separate change organisations name from organisation edit view * Remove change_name action from organisations_controller for unauthorized access handling * Add migration for organisation name changes * Implement organisation name change feature with history tracking * Update organisation label methods to accept date parameter for accurate historical representation * Rename change_name view to new and move it for clarity and consistency * Refactor organisation name change logic to ensure visibility and uniqueness of change dates * Refactor organisation name changes to use integer for change_type and date for change_date * Update validation error message for duplicate change dates in organisation name changes * Update validation logic for change dates to handle immediate changes * Rename change_date to startdate in organisation name changes and update related logic * Make change_type nullable in organisation name changes table * Remove debug logging for organisation name change parameters * Update conditional question data-info to use startdate instead of scheduled_date * Bug fix - ensure startdate is set only if not already defined for immediate changes * Fix immediate_change parameter type casting in organisation name change params * Refactor name_changes_with_dates method to streamline fetching and status assignment * Enhance layout in new.html.erb by adding additional grid columns for improved structure * Update status assignment logic in organisation.rb to reflect active state when no changes exist * Add validation to ensure start date is before organisation's merge date if present * Drop organisation_name_changes table if it exists * Remove organisation_name_changes table from schema * Add organisation_name_changes table * Lint fixes * Lint fixes * Add FactoryBot definition for organisation_name_change * Add tests for organisation name changes * Enhance validations and add tests for organisation name changes * Lint * Add tests for OrganisationNameChangesController actions * Add comments in OrganisationNameChange * Refactor organisation name change validations to use I18n for error messages * Fix name method to allow nil date parameter and default to current time * Update organisation name retrieval to support date parameter in exports * Remove change_type attribute from organisation name changes * Lint fix * Update organisation status logic to account for future start dates of the first change * Refactor name history display into a partial for better code organization * Add cancel functionality for scheduled name changes with confirmation page * lint * lint	1 year ago

Author

SHA1

Message

Date

Samuel Young

6a655e7210

CLDC-4325: Check tests will run on go live day (#3250 )

* CLDC-4325: Set date to 2026

* CLDC-4325: Fix sale information % tests

I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests

* CLDC-4325: Fix check answers spec

* CLDC-4325: Fix old rake task tests

* CLDC-4325: Fix sales soft validations

* CLDC-4325: Fix collection resources controller spec

* CLDC-4325: Only add noms and org to CSV row if prp

in most cases this was done by default but some tests construct an invalid log

* CLDC-4325: Fix lettings household validations spec

* CLDC-4221: Add 2026 collection deadlines

* CLDC-4325: Fix remaining model specs

* CLDC-4325: Fix form controller spec

* CLDC-4325: Fix hhmemb spec

* CLDC-4325: Fix duplicate logs controller spec

also introduce a new helper for a dynamic way of setting year

* CLDC-4325: Fix sales BU validator spec

* CLDC-4325: Fix check answers summary component

* CLDC-4325: Remove 2024 rake

* CLDC-4325: Use or later in all touched tests

* CLDC-4325: Fix guidance helper spec

* CLDC-4325: Run all tests now and in 2026

* CLDC-4325: Turn off 2026 override

* CLDC-4325: Add a corresponding return to timecop missing one

* CLDC-4325: Fix sales log spec in 2025

need to use let rather than let! so the timecop can run first

* CLDC-4325: Fix lettings log derived spec in 2025

timecop required for the start dates to work

* CLDC-4325: Turn the 2026 override on again

* fixup! CLDC-4325: Fix check answers summary component

* CLDC-4325: Delete recalculate_reasonpref_dontknow rake

only needed for 2024 logs

* fixup! CLDC-4325: Fix lettings household validations spec

Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>

* fixup! CLDC-4325: Fix sales log spec in 2025

* fixup! CLDC-4325: Fix sales log spec in 2025

* CLDC-4325: Make start controller spec not year specific

* CLDC-4325: Run tests in current day

* CLDC-4325: Run tests on 31st march

* CLDC-4325: Run tests on 2nd april

* CLDC-4325: Properly run tests on current day

* fixup! CLDC-4325: Fix sales soft validations

* fixup! CLDC-4325: Make start controller spec not year specific

* CLDC-4325: Run tests on 31st march

* CLDC-4325: Run tests on 1st april

* CLDC-4325: Run tests on 2nd april

* CLDC-4325: Revert time travel

---------

Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>

4 months ago

Manny Dinssa

9f6c1d55ef

CLDC-3980: Add ability to change organisation's name with a startdate (#3058 )

* Separate change organisations name from organisation edit view

* Remove change_name action from organisations_controller for unauthorized access handling

* Add migration for organisation name changes

* Implement organisation name change feature with history tracking

* Update organisation label methods to accept date parameter for accurate historical representation

* Rename change_name view to new and move it for clarity and consistency

* Refactor organisation name change logic to ensure visibility and uniqueness of change dates

* Refactor organisation name changes to use integer for change_type and date for change_date

* Update validation error message for duplicate change dates in organisation name changes

* Update validation logic for change dates to handle immediate changes

* Rename change_date to startdate in organisation name changes and update related logic

* Make change_type nullable in organisation name changes table

* Remove debug logging for organisation name change parameters

* Update conditional question data-info to use startdate instead of scheduled_date

* Bug fix - ensure startdate is set only if not already defined for immediate changes

* Fix immediate_change parameter type casting in organisation name change params

* Refactor name_changes_with_dates method to streamline fetching and status assignment

* Enhance layout in new.html.erb by adding additional grid columns for improved structure

* Update status assignment logic in organisation.rb to reflect active state when no changes exist

* Add validation to ensure start date is before organisation's merge date if present

* Drop organisation_name_changes table if it exists

* Remove organisation_name_changes table from schema

* Add organisation_name_changes table

* Lint fixes

* Lint fixes

* Add FactoryBot definition for organisation_name_change

* Add tests for organisation name changes

* Enhance validations and add tests for organisation name changes

* Lint

* Add tests for OrganisationNameChangesController actions

* Add comments in OrganisationNameChange

* Refactor organisation name change validations to use I18n for error messages

* Fix name method to allow nil date parameter and default to current time

* Update organisation name retrieval to support date parameter in exports

* Remove change_type attribute from organisation name changes

* Lint fix

* Update organisation status logic to account for future start dates of the first change

* Refactor name history display into a partial for better code organization

* Add cancel functionality for scheduled name changes with confirmation page

* lint

* lint

1 year ago

2 Commits (1edf4ad9794e01a3c905cd85d595fa51f19d2822)