submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	020b8a4f4c	CLDC-3686 Extract lettings soft validations copy (#2735 ) * Extract household characteristics soft validations * Extract household needs soft validations * Extract household situation soft validations * Extract income and benefits soft validations * Extract property information soft validations * Update tests and 2024 soft validations * Update some test forms * Re-add sales validation * Update BU tests * Fixes * Change higher to longer * Update model test * Update model test * Add 2025 translations copied from 2024 * Update pregnancy and retirement copy --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Co-authored-by: Rachael Booth <rachael.booth@softwire.com>	12 months ago
kosiakkatrina	51bc0cffeb	CLDC-3665 Extract sale information copy (#2711 ) * Extract shared ownership copy * Extract discounted ownership copy * rename files * CLDC-3665 Extract sale information soft validations (#2712) * Extract shared ownership copy * Extract shared ownership soft validations * Extract discounted ownership validations * Fix mappings * Update some translations * Remove full stops	1 year ago
Aaron Spencer	9662b14bde	CLDC 2439: apply 22/23 rent range soft validation to 23/24 (#1718 ) * CLDC-2439: min and max rent value check questions created * CLDC-2439: Informative removed, check pages fixed. * CLDC-2439: removed informative info tests and rent value check * CLDC-2439: fixed informative missing test failure * CLDC-2439: Text moved to en.yml * CLDC-2439: tests added, copy moved to en.yml * CLDC-2439: tests added, copy moved to en.yml * CLDC-2439: content change for bulk upload errors WIP * CLDC-2439: informative rendering change, content change, test updated * CLDC-2439: failing test fix. * CLDC-2439: display_informative_text test added for strings * CLDC-2439: string as var in test	2 years ago
kosiakkatrina	745e1e7e4b	CLDC-2248 Improve soft validations (#1584 ) * Update interruption screen page * Update routing and add flash * Only display routed to affected questions * Add affected_question_ids to pregnancy check * lint * Add skip link and lint * Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids * typo * Fix button wording * Update action href links * Change how we route back to interruption screen * Update affected_question_ids for lettings * Update sales soft validations * Update title texts * Update styling * Update is_referrer_interruption_screen? check and naming * Add interuption screen helper specs * Add request test for fixing soft validation * Add tests for geting soft validation page * Extract interruption screen banner * Update action_href to be reusable * Extract questions out of check answers summary list * Reuse check_answers_summary_list for interruption screen * refactor string parse * Rename attribute * fix test * Add tests for sales paths * typo * Update validation message: void date, major repairs date * Update validation message: rent_value_check, 2022 * Update validation message: buyer live in * Update validation message: staircase * Update validation message: purchase price * Update validation message: income * Update validation message: savings * Update validation message: extra borrowing * Update validation message: extra borrowing * Update validation message: wheelchair * Update validation message: monthly charge * Update validation message: mortgage * Update validation message: old persons shared ownership * Update validation message: discount * Update validation: min retirement * Wording in tests and time test * Update missing question * Refactor is referrer methods * Update validation message: net income * Update validation message: deposit and savings * Update validation message: mortgage, discount and deposit * Fix test validation messages * Fix the retirement check showing on the card 8, fix tests * test * return the user back to the check_your_answers after fixing a validation from check_your_anwers * pr comments	3 years ago
David May-Miller	4a31906d45	CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>	3 years ago
natdeanlewissoftwire	d254ef8c62	CLDC-868 Add purchase price validations (#1225 ) * feat: wip behaviour * feat: hide in cya * feat: show in cya * feat: purchase price range service and rake task * feat: fix hodate validation and use purchase price ranges * db:update * feat: more saledate -> exdate fixing * feat: add min and max conditional text * refactor: linting * refactor: remove duplicated behaviour * refactor: linting * feat: update tests * test: add validation tests * test: add purchase price rangeimport service tests * refactor: linting * feat: allow translation text and title text to display currency formatting even when not a log field * feat: use i18n * feat: update i18n * refactor: pratical -> practical * refactor: linting * refactor: revert unnecessary change * feat: respond to PR comments * tests: update after merge * feat: improve currency interruption screen display * feat: update docs * feat: fix typo * feat: missing end after merge * feat: respond to PR comments * feat: add soft validation to beds and la pages * db:update * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: PO comment responses * tests: update * refactor: linting * refactor: simplification * refactor: railsification * test: fix * refactor: use number_to_currency units * refactor: remove duplicated copy * db:update	3 years ago
natdeanlewissoftwire	d89e03cc62	Cldc 1675 rent validations (#959 ) * feat: add 2022 rent range data, update rake task for population of this * feat: change file format so ranges_rent_id is recognised * feat: add updated error messages and casing * tests: make tests pass * feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations * feat: fix general needs validation behaviour * feat: add local authorities enum to location.rb * feat: ensure case when beds > 4 is accounted for * feat: add error messages on property postcode page as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: null coalescing and validations on changing las to one that invalidates rent in supported housing * feat: nil protection * refactor: linting * refactor: combining duplicated logic * tests: add hard validation tests split by needstype * feat: update validations when beds > 4 * feat: update validations when beds > 4 * refactor: simplification, use preivous la method * refactor: response to PR comments, fixing beds.negative validation * feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location	3 years ago
natdeanlewissoftwire	b83c6c0b27	Cldc 1675 rent validations (#946 ) * feat: add 2022 rent range data, update rake task for population of this * feat: change file format so ranges_rent_id is recognised * feat: add updated error messages and casing * tests: make tests pass	3 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	3 years ago
kosiakkatrina	de2d86a8ca	check if title text exists in display_title_text (#633 ) * check if title text exists in display_title_text * lint * Remove all strings from title text in interruption screen	3 years ago
Ted-U	970c9afcf7	Cldc 1217 retirement soft validation (#570 ) * Interruption screen refactor * Add test for retirement_age_for_person Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com> * Rubocop * update 22-23 form * fix failures * lint fixes * remove whitespace * remove commented code * make spec file use translations instead of content * update content * lint fixes * fix typo * fix question wording * fix failing spec * add full stop Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com> Co-authored-by: Dushan Despotovic <dushan@madetech.com>	3 years ago

11 Commits (2b63801939511396b929744fafc251404aee2909)