submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	745e1e7e4b	CLDC-2248 Improve soft validations (#1584 ) * Update interruption screen page * Update routing and add flash * Only display routed to affected questions * Add affected_question_ids to pregnancy check * lint * Add skip link and lint * Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids * typo * Fix button wording * Update action href links * Change how we route back to interruption screen * Update affected_question_ids for lettings * Update sales soft validations * Update title texts * Update styling * Update is_referrer_interruption_screen? check and naming * Add interuption screen helper specs * Add request test for fixing soft validation * Add tests for geting soft validation page * Extract interruption screen banner * Update action_href to be reusable * Extract questions out of check answers summary list * Reuse check_answers_summary_list for interruption screen * refactor string parse * Rename attribute * fix test * Add tests for sales paths * typo * Update validation message: void date, major repairs date * Update validation message: rent_value_check, 2022 * Update validation message: buyer live in * Update validation message: staircase * Update validation message: purchase price * Update validation message: income * Update validation message: savings * Update validation message: extra borrowing * Update validation message: extra borrowing * Update validation message: wheelchair * Update validation message: monthly charge * Update validation message: mortgage * Update validation message: old persons shared ownership * Update validation message: discount * Update validation: min retirement * Wording in tests and time test * Update missing question * Refactor is referrer methods * Update validation message: net income * Update validation message: deposit and savings * Update validation message: mortgage, discount and deposit * Fix test validation messages * Fix the retirement check showing on the card 8, fix tests * test * return the user back to the check_your_answers after fixing a validation from check_your_anwers * pr comments	2 years ago
kosiakkatrina	ae9a4d0638	Fix collection year shift issues (#1506 ) * Fix possible bulk upload years * Initialise 2021/22 form routes for tests * Return test routes from form handler * Fix some tests * fix bulk upload tests - change from mocks to actual code calls * update years for bulk upload form * Fix some uprn tests * Set the scheme as available from previous year if the collection is in crossover * Update location available_from * Update location and scheme tests * Refactor and comment out a scheme test * Some uprn and export tests * Fix lettings logs controller tests and comment out previous collection message test * fix tests for new collection year * fix bulk upload tests for some reason tenancylength must not be given for validation to pass * update bulk upload tests for new year * More fixes * Undo location changes * Fix remaining uprn * further new collection year test fixes --------- Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	2 years ago
kosiakkatrina	cf46ae46fe	CLDC-2131 Update pregnancy validation (#1458 ) * Remove hard pregnancy validation and update soft validation * Remove validate_pregnancy references * Don't care about the age in gender validation	2 years ago
kosiakkatrina	1acd3b3aaf	CLDC-2074 Change care home charges validation (#1410 ) * Add carehome charges value check field * Add carehome charges soft validation to 23/24 forms * Update care_home_charge_expected_not_provided? * Add care_home_charges_value_check to 22/23 * Update csv * Add care_home_charges_value_check to 21/22 form * Update import to set value_chech to yes	2 years ago
natdeanlewissoftwire	f758d598c4	CLDC-1917 Add Startdate Validation (#1378 ) * feat: add validation with feature flag, typo fix and update tests * feat: flip feature toggle * feat: update feature toggle name * feat: fix form handler inequality * refactor: linting * refactor: use between in form handler * feat: remove feature toggle * feat: add dynamic date to lettings log factory * feat: fix log_summary_component_spec.rb tests * feat: update lettings_log.rb and start fixing lettings_log_spec.rb * feat: fix more tests * feat: fix more tests * feat: fix lettings log import service * refactor: linting * feat: fix checkboxes_spec.rb * feat: fix interruption_screen_helper_spec.rb * feat: fix check_answers_helper_spec.rb * feat: fix page_routing_spec.rb * feat: fix lettings_logs_field_import_service_spec.rb * feat: fix lettings_log_spec.rb * feat: fix question_spec.rb * feat: fix lettings_logs_controller_spec.rb * feat: fix check_answers_page_lettings_logs_spec.rb * feat: fix tenancy_validations_spec.rb * feat: fix validations_spec.rb * feat: fix accessible_autocomplete_spec.rb * feat: fix form_navigation_spec.rb * feat: fix soft_validations_spec.rb * feat: fix lettings_log_export_service_spec.rb * feat: fix saving_data_spec.rb * feat: fix page_spec.rb * feat: fix form_controller_spec.rb * refactor: linting * feat: fix subsection_spec.rb * feat: fix lettings_log_spec.rb * feat: fix financial_validations_spec.rb * feat: fix tasklist_page_spec.rb * feat: fix conditional_questions_spec.rb * feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb * feat: fix lettings_log_csv_service_spec.rb * feat: fix tasklist_helper_spec.rb * refactor: linting * refactor: linting * feat: fix lettings_log_spec.rb * refactor: linting * refactor: replace financial year with collection yaer * feat: respond to PR comments pt. 1 * feat: respond to PR comments pt. 2	2 years ago
kosiakkatrina	ea58c8ba95	CLDC-845 Update validation type from hard validation to soft validation (#1224 ) * Add old_persons_shared_ownership_value_check to sales table * Move hard validation method to soft validation * Add old persons shared ownership value check page and question * Add pages to the household characteristics * Add soft validation after ownership type * update a test * make old_persons_shared_ownership_value_check optional because it's in the setup section * typo	2 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	0ff0aa31fe	Cldc 1338 dates validation (#820 ) * Change property major repairs date validation from 2 years to 10 * add voiddate_date_in_soft_range? and major_repairs_date_in_soft_range? methods * update error messages for hard validations * Add property_major_repairs_value_check to the form * add void_date_value_check and fix some namings * Update value_check hidden in check answers to depend on whether the questions is answered * Remove a schema key * extract constants for number of days * change error messages wording * update schema and csv files	2 years ago
baarkerlounger	4a2c08e05c	Fix rent value check (#785 ) * Fix clearing of rent_value_check due to order of soft validation vs derived * Remove logger stub	2 years ago
kosiakkatrina	88fec8e5ab	Cldc 1223 pregnancy soft validations (#602 ) * update hard validation limits for pregnancy age, remove hard validation if there are no females at all * Add soft validations for pregnancy * make the error message consistent * Only check the values for the members with details known in the household * Show interruption screen when resident details are updated * Route back to check answers after an interruption screen and back to previous page if no is selected on the interruption screen Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * update validation messages * fix a test * fix a typo Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	3 years ago
baarkerlounger	116a1b12f4	CLDC-1217: Retirement soft validation (#586 ) * Don't trigger soft validation if tenant prefers not to say * Update gender content * Fix spec description	3 years ago
kosiakkatrina	6c5391ad1c	Cldc 1065 soft validations (#434 ) * change get_question form method to prioritise the routed to questions * Add soft validation and interruption screen for basic rent * get previous page that was routed to and display the same error for both soft validations * Separate max and min error screens * add a test for getting the previous page * Update content and add more tests for previous page	3 years ago

12 Commits (2dcafc8ecd0fa2e9a23a0bc1b9e2a76d30a1284f)