submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	6717eb6275	CLDC-3181 Update question numbers for 2024 (#2252 ) * Update question numbers for 2024 * Stub form in tests * Stub form start_date for pages * Add a default question number * Fix a typo * Update rebase test * Refactor default question number * Refactor person question numbers * Display managing org for sales correctly in CYA * Rebase fix * More tweaks	8 months ago
Robert Sullivan	8bfdbef3f3	CLDC-2046: Use 'Buyer 1' consistently in error messages (#2264 )	8 months ago
Arthur Campbell	720f7ca0e2	CLDC-1945 numeric questions decimal letter entry (#1558 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase * amend step value on earnings	2 years ago
Arthur Campbell	f57b93045d	Revert "CLDC-1945 numeric questions decimal letter entry (#1442 )" (#1555 ) This reverts commit `c78f2ef5f9`.	2 years ago
Arthur Campbell	c78f2ef5f9	CLDC-1945 numeric questions decimal letter entry (#1442 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase	2 years ago
natdeanlewissoftwire	c862423adf	CLDC-1864 single log numbering (#1381 ) * feat: add initial question number behaviour * feat: add initial CYA behaviour * feat: number sales setup section * refactor: lint * feat: property information numbering * feat: household characteristics section and typo fix * feat: household characteristics numbering * feat: household situation numbering * feat: other household info numbering * feat: income, benefits and outgoings numbering * feat: shared ownership scheme numbering * feat: shared, discount and outright numbering * feat: fix income duplication bug, add numbers to other questions * feat: typo fix * feat: add lettings setup numbering * feat: add property info numbering * feat: add household char numbering * feat: add household needs numbering * feat: add household situ numbering * feat: add income numbering * feat: update tests * refactor: cleanup and disable on 2022 and before logs * feat: add test for q numbers in 23/24 year only * refactor: highlight multiplication in brackets * feat: show rent and charge questions individually on cya * feat: number new previous tenure q * feat: delete old prevten file * feat: update card numbers after merge * feat: add q60 ands 61 sales * refactor: delete empty files --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	2 years ago
kosiakkatrina	7e176bba34	CLDC-845 Add sales household details validations (#1191 ) * Add min and max for age 1 validation * Add retirement value check column to the sales table * Add retirement value check question and page * Add retirement value check pages to household characteristics * Reuse soft validations for retirement in sales * Update person_indexes * Add old_persons_shared_ownership validation * Display the retirement value check in correct places depending on the joinpur value * Update page IDs * It's always joint purchase if age 2 is displayed * lint * lint	2 years ago
kosiakkatrina	d9a57ec1cb	CLDC-1627 Enable multiple inferred answers (#1077 ) * Enable multiple inferred check answers values * lint and add new conditions to check answers for age1 * Rename method * Refactor inferred answer value * rebase update * update inferred_check_answers_value after rebase * Move the method to private * Add a missing test * rebase changes * Add prefers not to say as the displayed value for all household members * update [0] to .first * replace [0] with .first	2 years ago
kosiakkatrina	c339ffda1f	Cleanup the form (#1166 ) * Remove empty descriptions from pages * remove empty headers from pages * Remove redundant subsection assignment from pages * Remove redundant page assignement from questions * Remove redundant section assignment from subsections * Remove redundant form assignments from sections * Remove empty hint texts from questions * lint	2 years ago
kosiakkatrina	266bf3fda5	Cldc 1627 update age in check answers and put persons on different check answers cards (#1068 ) * Display person 2, 3, 4 age question if their details are known * Infer check answers value for age questions as 'Not known' * Hide age known question in check answers if it is answered yes or no * Add card numbers to household characteristics question * Update gender identity depends on * lint * Add a field to completed sales log in factory * Update person 1 gender identity to depend on the people count * Do not show buyer 2 questions if it is not a joint purchase	2 years ago
bibblobcode	3b2b207c71	[CLDC-1484] Add Buyer 1 age question (#898 ) * [CLDC-1484] Add buyer 1 questions to Sales form * [CLDC-1484] Add Age1 page and sections * [CLDC-1484] Enable rspec --only-failures * Rubocop lint	2 years ago

11 Commits (30bb983e78e97f721c754831bbd29b3180d04600)