submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Manny Dinssa	a0fda9ed07	Fix lint	11 months ago
Manny Dinssa	9bbc0fb7e4	Extract more question information	11 months ago
Manny Dinssa	80f15e489e	Extract some uprn copy	11 months ago
natdeanlewissoftwire	fedbc6acad	CLDC-2069 Find UPRNs by address (#2278 ) * feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint * feat: build out alternative routes through the address lookup flow * refactor: lint * refactor: remove commented lines * feat: make nil safe * feat: test address client * feat: store address input separately * feat: add migration * feat: display inputs in answer label * feat: update data presenter and test * feat: revert precicions schema update * feat: revert precision schema update * feat: migrate new fields to sales logs * feat: update shared log examples tests * feat: use -1 for not listed address for extensibility * feat: add service error to address_selection * feat: handle case when no addresses are found * feat: allow re-entering different uprns * feat: improve error handling and don't accept "no match" precisions * feat: add page tests * feat: confirm uprn on address update * feat: add question tests * feat: don't set minimum match for initial search * feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint * feat: build out alternative routes through the address lookup flow * refactor: lint * refactor: remove commented lines * feat: make nil safe * feat: test address client * feat: store address input separately * feat: add migration * feat: display inputs in answer label * feat: update data presenter and test * feat: revert precision schema update * feat: migrate new fields to sales logs * feat: update shared log examples tests * feat: use -1 for not listed address for extensibility * feat: add service error to address_selection * feat: handle case when no addresses are found * feat: allow re-entering different uprns * feat: improve error handling and don't accept "no match" precisions * feat: add page tests * feat: confirm uprn on address update * feat: add question tests * feat: don't set minimum match for initial search * feat: add no address found page * feat: allow uprn known to be skipped, and set 0.4 min precision * feat: accept best "good" match in bulk upload * feat: update validations and test * refactor: avoid stubbing using any_instance_of * refactor: use change_table in migrations * feat: add lettings behaviour to sales logs * feat: update sales tests * feat: xit test that is xited in lettings * feat: stub os api in sales row parser * feat: stub os api in sales row parser * feat: add address line 1 to required attributes * feat: update matching details and fix row parser validation * refactor: improve readability * feat: set uprns as option IDs to avoid multiple lookups * feat: add sales uprn_selection * feat: update schema * feat: update tests * feat: remove redundant methods * feat: update error message and fix tests * feat: update tests * feat: update tests and error behaviour * feat: update tests	2 years ago
natdeanlewissoftwire	31e5215735	CLDC-3133 Remove times offered from 24/25 (#2162 ) * feat: remove offered form 24 onwards * feat: add test * feat: update test * refactor: lint	2 years ago
natdeanlewissoftwire	240e8a03b5	Cldc 2445 increase offered max (#1692 ) * feat: update max and add new spec * feat: update previous years * feat: combine identical offered questions * feat: update tests * feat: add test for property_number_of_times_relet	2 years ago
natdeanlewissoftwire	87d4497558	CLDC-2199 Fix LA/rent soft validation bugs (#1538 ) * feat: unrelated currency formatting * Revert "feat: unrelated currency formatting" This reverts commit `75bd3efbf8`. * feat: add soft val pages to property information section (not to setup) * feat: update tests * feat: update tests * feat: add validation to setpu section * refactor: lint * test: update * feat: set nil as default check answers card no * feat: use : to define more explicitly * feat: make optional as affects setup * feat: update tests * feat: put la in nil card with rest of uprn/address qs * feat: route to uprn confirmation from check answers changes to uprn even though not an interruption screen * feat: update tests * feat: update tests * refactor: lint * feat: update tests * feat: update tests * feat: wip blank fields and dependent fields on upload tos ee if valid and can upload with missing info - this is not the exact ac on the ticket yet * Revert "feat: wip blank fields and dependent fields on upload tos ee if valid and can upload with missing info - this is not the exact ac on the ticket yet" This reverts commit `136e5f6f12`. * feat: fix uprn hidden in check answers * feat: fix tests * feat: fix tests	2 years ago
Jack	37fab3fe25	[CLDC-2260] Move UPRN Known and UPRN questions to same page (#1537 ) * Set uprn_known to 1 when setting UPRN * Move fake to dev+test gemfile block So that we can use factories in local * Move UPRN known and UPRN questions to single UPRN page	2 years ago
natdeanlewissoftwire	330c7b9595	CLDC-1792 Update void date question (#1440 ) * feat: add void date guidance partial * feat: set guidance pos bottom for 22/23 log * feat: add tests * refactor: linting * Update app/models/form/question.rb Co-authored-by: Phil Lee <asmega@users.noreply.github.com> * feat: smart quotes * feat: respond to po comments * feat: add voiddate/mrcdate validation to mrcdate too * feat: add ten year validations to startdate too * feat: fix tests --------- Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	3 years ago
Jack	1a5d9fc14b	[CLDC-2068] Add UPRN questions to lettings (#1432 ) * Update CYA page * Update UPRN derived fields * Update sales' UPRN questions * Add UPRN lettings questions * Fix spec	3 years ago
Arthur Campbell	f3e7d2c62b	CLDC-2073 app crashing if needs type is changed (#1368 ) * add some methods on lettings log and use them and already existing methods to make depends on human readbale for pages in property information subsection * reformat answer options for neatness * ensure that property information subsection is conditionally not shown under correct conditions * amend method to find the path for the next question to answer so that if no questions in the next section are currently routed to, it goes to the section after that * make amendments for failing test and linting * remove unnecessary method * remove unnecessary conditions from depends on, the displayed in tasklist method override is sufficient * test the change to the method creating a link to the next subsection * minor refactor to displayed_is_tasklist condition and changes in testing * implement the fix on 22/23 form also * write a test covering the fix * removal not_renewal? method and tweak depends on for all pages using that method * linty fluff begone * correct some errors in tests after changes to factories * minor testing amendments after rebase	3 years ago
kosiakkatrina	7f76fffcce	CLDC-1911 Add form definition for 23/24 lettings (#1254 ) * Spike for generating form * Add remaining field mappings * Add question attributes conditionally * Display page attributes conditionally * update subsection formatting * Update section formatting * fix generator * Fix generator * Update the form handler and form to create post 2021 forms programatically * Initially generated and linted form * Cover lettings sections and subsections wiht tests * Cover age pages and questions with tests * Add reusable age questions and adjust the tests * Add a generic person age page using generic questions and adjust specs * Multiline arrays in subsections * Use generic person age page in household characteristics and remove unused pages/questions * Combine and reduce tests * Backfill duplicate rsnvac question * Backfill repeating question * Backfill repeating voiddate * Backfill repeating tenancy question * Backfill ethnic questions * Backfill reason question * Backfill prevten question * Backfill referral questions * Backfill chcharges questions * Backfill brent questions * Backfill scharge * Backfill pscharge * Backfill supcharg * Backfill tcharge * Backfill retirement value check question * Make person known questions generic * Make person gender identity questions generic * Make relationship questions generic * Make working situation questions generic * make retirement check generic * make pregnant household check generic * Make pregnancy value checks generic, again * Undo for and form handler changes * Remove generate form task and service * Remove empty headers, descriptions and initializers from pages * Fix tests * lint	3 years ago

12 Commits (3464984ded9dcd92e9babae02f1ddd2e1fcdec2a)