submit-social-housing-lettings-and-sales-data

3681 Commits

265 Branches

309 Tags

88 MiB

Tree: 3e77343d5d

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Samuel Young	a3ad64f6dc	CLDC-3857 add new questions to organisation setup (#3075 ) * Add questions to page, wip * Add select as conditional question in radio like in logs * Add existing value * Add blank default * Add values to about this organisation page * Move grabbing values out of view * Update new org page with js * Selecting the profit status dependent on the provider type * Add to org edit page for support users * Add group logic * Fix bug on existing orgs when group remains unchanged * Clear group details if no longer part of a group * Lint * JS Lint * Restore schema * Remove manual_address_selected * Revert "Remove manual_address_selected" This reverts commit `812787fd09`. * Revert "Revert "Remove manual_address_selected"" This reverts commit `8ebd56036f`. * Update migration * Remove file * Move update after save * Move methods to controller * Update xml export * Lint * Update test xml file * Update current user logic * Lint * Lint * Reorder org js controller * Lint * Add tests to helper * Some tests on the organisation pages * Fix label text for profit status question in forms * Add CSV task to update organisation profit status and group member fields * only associate group on update if validation passes * Update import raketask to use provided csv looking into it I couldn't see a use for skip_group_member_validation. it temporarily disables validation but since it's not saved to database it'll make the organisation invalid in the future opted instead to make all properties valid when importing * Update tests to check more cases of organisation import * Make XML tests check unordered file contents stops tests flakily failing on the order of cols which is not important in xml * Fix final failing tests * restore manual_address_selected migration * fix it's to its * show the user the group they originally selected if possible when editing group else fallback to any (oldest) org in the group * update csv for ingest --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>	1 year ago

Samuel Young

a3ad64f6dc

CLDC-3857 add new questions to organisation setup (#3075 )

* Add questions to page, wip

* Add select as conditional question in radio like in logs

* Add existing value

* Add blank default

* Add values to about this organisation page

* Move grabbing values out of view

* Update new org page with js

* Selecting the profit status dependent on the provider type

* Add to org edit page for support users

* Add group logic

* Fix bug on existing orgs when group remains unchanged

* Clear group details if no longer part of a group

* Lint

* JS Lint

* Restore schema

* Remove manual_address_selected

* Revert "Remove manual_address_selected"

This reverts commit 812787fd09.

* Revert "Revert "Remove manual_address_selected""

This reverts commit 8ebd56036f.

* Update migration

* Remove file

* Move update after save

* Move methods to controller

* Update xml export

* Lint

* Update test xml file

* Update current user logic

* Lint

* Lint

* Reorder org js controller

* Lint

* Add tests to helper

* Some tests on the organisation pages

* Fix label text for profit status question in forms

* Add CSV task to update organisation profit status and group member fields

* only associate group on update if validation passes

* Update import raketask to use provided csv

looking into it I couldn't see a use for skip_group_member_validation. it temporarily disables validation but since it's not saved to database it'll make the organisation invalid in the future

opted instead to make all properties valid when importing

* Update tests to check more cases of organisation import

* Make XML tests check unordered file contents

stops tests flakily failing on the order of cols which is not important in xml

* Fix final failing tests

* restore manual_address_selected migration

* fix it's to its

* show the user the group they originally selected if possible when editing group

else fallback to any (oldest) org in the group

* update csv for ingest

---------

Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>

1 year ago

1 Commits (3e77343d5da1fb371b8e0b9b40dc59f4fc692af5)