submit-social-housing-lettings-and-sales-data

3340 Commits

228 Branches

285 Tags

79 MiB

Tree: 3e90910e90

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Arthur Campbell	461b46bc4a	rake task to create rent period associations for orgs that have none (#2443 )	11 months ago
Arthur Campbell	1ebf71129e	Revert "Cldc 3114 enable support control of rent periods per organisation (#2…" (#2439 ) This reverts commit `eda367afb0`.	11 months ago
Arthur Campbell	eda367afb0	Cldc 3114 enable support control of rent periods per organisation (#2389 ) * write helper method to support having the correct rent period checkboxes checked * update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this * small changes to models * enable editing rent period in the UI display change button on org details page display rent periods question on edit page * enable updating org rent periods update logic in #update related tests * alter redirect after support user creates an organisation * adjust various UI elements: ordering of rows, copy changes, label size and associated tests * rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update * amend failing tests and resolve linting complaints * changes following review * disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method * update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions * rake task to create rent period associations for orgs that have none * revert mistaken copy changes in designs * create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods * stub api call for factory value, update csv tests and fixtures accordingly * extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests * remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code * escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db * further refactoring of various tests to reduce database interactions and improve speed * remove outdated distinction between unitletas mappings from before 23/24 * remove tests that seem to be testing active record and/or ruby Date class	11 months ago

Arthur Campbell

461b46bc4a

rake task to create rent period associations for orgs that have none (#2443 )

11 months ago

Arthur Campbell

1ebf71129e

Revert "Cldc 3114 enable support control of rent periods per organisation (#2…" (#2439 )

This reverts commit eda367afb0.

11 months ago

Arthur Campbell

eda367afb0

Cldc 3114 enable support control of rent periods per organisation (#2389 )

* write helper method to support having the correct rent period checkboxes checked

* update new and create in organisations controller and view to enable creation of relevant organisation rent periods
write tests for this

* small changes to models

* enable editing rent period in the UI
display change button on org details page
display rent periods question on edit page

* enable updating org rent periods
update logic in #update
related tests

* alter redirect after support user creates an organisation

* adjust various UI elements: ordering of rows, copy changes, label size and associated tests

* rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update

* amend failing tests and resolve linting complaints

* changes following review

* disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid
hint text added to the question to explain this
I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method

* update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods
update tests adding both cases and removing unnecessary additional db additions

* rake task to create rent period associations for orgs that have none

* revert mistaken copy changes in designs

* create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods

* stub api call for factory value, update csv tests and fixtures accordingly

* extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests

* remove before(:context) and associated patterns.
use assign_attributes in various places for cleaner code

* escape . in regex for API call stubs to satisfy codeQL
remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db

* further refactoring of various tests to reduce database interactions and improve speed

* remove outdated distinction between unitletas mappings from before 23/24

* remove tests that seem to be testing active record and/or ruby Date class

11 months ago

3 Commits (3e90910e90fdf54f77ae2fabff9a98c194d02a02)