submit-social-housing-lettings-and-sales-data

3504 Commits

250 Branches

297 Tags

87 MiB

Tree: 40fca2865e

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	cec1208b35	CLDC-2290 implement delete multiple logs story (#1657 ) * add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active * correct indentation from 4 spaces to 2 in view file * test appearance of delete logs button on index page for lettings logs * write a happy path feature test for the entire journey * create basic tests for the view component for listing logs to delete * create request tests for the GET delete-logs path * create request tests for the GET delete-logs-confirmation path * create request tests for the DELETE delete-logs path * comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings * alter config to allow creating controllers from the command line with associated spec files that matches how we test * extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly * implement same work for sales as for lettings * implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model * merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content * minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method * extract tables for lettings and sales to own partials * refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab * remove unnecessary untested arguments * test new helper methods * implement dirty fiddle to get the checkboxes smaller and also not misaligned * ensure delete logs button is always visible on log lists when in the organisations tab * minor linting corrections * revert change, causing errors and outside the scope of this ticket * simplify tests for whether delete logs button appears on index page * replicate request specs from lettings for sales and organisations controllers * minor refactor of lettings log feature spec setup, replicate happy path for sales * minor refactors after rebasing onto Nat's work * temp * write tests for the delete logs form object * lint: add new line at end of file * respond to PO feedback the log id in the delte logs table should be a link to the log the delete logs button should be visible when the user is in a bulk upload journey updated associated tests	3 years ago

Author

SHA1

Message

Date

Arthur Campbell

cec1208b35

CLDC-2290 implement delete multiple logs story (#1657 )

* add a button to the logs list to delete multiple logs
style and position of button
helpers for displaying the button conditionally depending on user role and what filters and search are active

* correct indentation from 4 spaces to 2 in view file

* test appearance of delete logs button on index page for lettings logs

* write a happy path feature test for the entire journey

* create basic tests for the view component for listing logs to delete

* create request tests for the GET delete-logs path

* create request tests for the GET delete-logs-confirmation path

* create request tests for the DELETE delete-logs path

* comprehensive reworking after code review
ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length,
adjust tests accordingly,
do not attempt to reuse the same table for sales and lettings

* alter config to allow creating controllers from the command line with associated spec files that matches how we test

* extract controller methods and associated tests to do with the delete logs feature into their own controller,
    amend routes accordingly

* implement same work for sales as for lettings

* implement the story for lettings and sales logs under the organisation tab
routing and controller methods
testing for deleting sales logs, lettings or sales logs for an organisation
move storage of relevant routes inside the form object as a comprehensive view model

* merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content

* minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method

* extract tables for lettings and sales to own partials

* refactor delete logs controller after tech review
improve the private method that builds the form object so that it has the flexibility to do so for all controller methods
ensure that the search term is passed to the delete logs controller when navigating through the organisations tab
ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab

* remove unnecessary untested arguments

* test new helper methods

* implement dirty fiddle to get the checkboxes smaller and also not misaligned

* ensure delete logs button is always visible on log lists when in the organisations tab

* minor linting corrections

* revert change, causing errors and outside the scope of this ticket

* simplify tests for whether delete logs button appears on index page

* replicate request specs from lettings for sales and organisations controllers

* minor refactor of lettings log feature spec setup, replicate happy path for sales

* minor refactors after rebasing onto Nat's work

* temp

* write tests for the delete logs form object

* lint: add new line at end of file

* respond to PO feedback
the log id in the delte logs table should be a link to the log
the delete logs button should be visible when the user is in a bulk upload journey
updated associated tests

3 years ago

1 Commits (40fca2865ed135820df38f66971708c902de7a7c)