submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	cec1208b35	CLDC-2290 implement delete multiple logs story (#1657 ) * add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active * correct indentation from 4 spaces to 2 in view file * test appearance of delete logs button on index page for lettings logs * write a happy path feature test for the entire journey * create basic tests for the view component for listing logs to delete * create request tests for the GET delete-logs path * create request tests for the GET delete-logs-confirmation path * create request tests for the DELETE delete-logs path * comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings * alter config to allow creating controllers from the command line with associated spec files that matches how we test * extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly * implement same work for sales as for lettings * implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model * merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content * minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method * extract tables for lettings and sales to own partials * refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab * remove unnecessary untested arguments * test new helper methods * implement dirty fiddle to get the checkboxes smaller and also not misaligned * ensure delete logs button is always visible on log lists when in the organisations tab * minor linting corrections * revert change, causing errors and outside the scope of this ticket * simplify tests for whether delete logs button appears on index page * replicate request specs from lettings for sales and organisations controllers * minor refactor of lettings log feature spec setup, replicate happy path for sales * minor refactors after rebasing onto Nat's work * temp * write tests for the delete logs form object * lint: add new line at end of file * respond to PO feedback the log id in the delte logs table should be a link to the log the delete logs button should be visible when the user is in a bulk upload journey updated associated tests	2 years ago
natdeanlewissoftwire	f758d598c4	CLDC-1917 Add Startdate Validation (#1378 ) * feat: add validation with feature flag, typo fix and update tests * feat: flip feature toggle * feat: update feature toggle name * feat: fix form handler inequality * refactor: linting * refactor: use between in form handler * feat: remove feature toggle * feat: add dynamic date to lettings log factory * feat: fix log_summary_component_spec.rb tests * feat: update lettings_log.rb and start fixing lettings_log_spec.rb * feat: fix more tests * feat: fix more tests * feat: fix lettings log import service * refactor: linting * feat: fix checkboxes_spec.rb * feat: fix interruption_screen_helper_spec.rb * feat: fix check_answers_helper_spec.rb * feat: fix page_routing_spec.rb * feat: fix lettings_logs_field_import_service_spec.rb * feat: fix lettings_log_spec.rb * feat: fix question_spec.rb * feat: fix lettings_logs_controller_spec.rb * feat: fix check_answers_page_lettings_logs_spec.rb * feat: fix tenancy_validations_spec.rb * feat: fix validations_spec.rb * feat: fix accessible_autocomplete_spec.rb * feat: fix form_navigation_spec.rb * feat: fix soft_validations_spec.rb * feat: fix lettings_log_export_service_spec.rb * feat: fix saving_data_spec.rb * feat: fix page_spec.rb * feat: fix form_controller_spec.rb * refactor: linting * feat: fix subsection_spec.rb * feat: fix lettings_log_spec.rb * feat: fix financial_validations_spec.rb * feat: fix tasklist_page_spec.rb * feat: fix conditional_questions_spec.rb * feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb * feat: fix lettings_log_csv_service_spec.rb * feat: fix tasklist_helper_spec.rb * refactor: linting * refactor: linting * feat: fix lettings_log_spec.rb * refactor: linting * refactor: replace financial year with collection yaer * feat: respond to PR comments pt. 1 * feat: respond to PR comments pt. 2	3 years ago
James Rose	d3075e4e43	Revert to `f4e6d6d6bb` (#887 )	3 years ago
natdeanlewissoftwire	f162f880ae	Revert "Merge remote-tracking branch 'origin/main' into CLDC-1429-output-la-code" This reverts commit `626e2bd1a6`, reversing changes made to `f86e13cea7`.	3 years ago
Dushan	67ce147fc9	Extract base log and create sales log (#858 ) * Add abstract log class and sales log class Created a parent log class for sales log and lettings log. Any bits common to both sales and lettings can live in the parent class. As the sales log functionality is built up any commonalities with lettings log can be extracted into the parent log class. The sales log model is set up without a json form and instead the form is defined in code - like the setup section of the lettings log. * update sales logs controller * update lettings controller specs * update filter method name * update organisations controller * use lettings method * Add deleted tests back * lint Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Kat <kosiak.katrina@gmail.com>	3 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	3 years ago
baarkerlounger	cbdcde2bcd	Hash syntax	4 years ago
Paul Robert Lloyd	9b51ad13b7	Link to privacy policy page, not old PDF	4 years ago
Dushan	484bb499e6	CLDC-788 interruption screen net income soft validation (#372 ) * Set up failing test for new soft validation design * remove unneeded js controller * remove unneeded controller and spec * rename net income validation override column * spec form changes (to allow tests to run) * validation spec changes * replace all instances of override_net_income_validatiom * passing first test * Add to form and import styling * remove unneeded code from interruption screen view * Update test & code - failing last new expectation * Display 2 previous question answers in the informative text * extract displaying of the informative text into a helper * Add tests for helper * Remove some of the previous soft validations set up * fix some failing specs * Fix more tests * lint * Reset earnings question prefix and suffix to initial values instead of nil * make it route backwards on a no * test and linter fixes * refactor next_page * stryling * more changes * fix specs * update real form * design tweaks * delete commented out tests * content changes * content changes * changes to informative/hint text * More robust styles for interuption panel, use smart quotes * Rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com> Co-authored-by: baarkerlounger <db@slothlife.xyz>	4 years ago
Stéphane Meny	55a29832a3	Case logs export (#288 )	4 years ago
Dushan	6360c56da5	CLDC-933 update household income questions (#273 ) * Change net income known question * earnings and frequency on same page * check answers changes and other fixes * some fixes * delete unnecessary test * fix failing spec * Refactor answer label Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * test and lint fixes * Method args * Fix specs * Rubocop * Incfreq doesn't have it's own check answers display * Add suffix to actual form * JSON linting * Conditional suffix only applies to check answers * Validate that earnings and incfreq must be provided together * Rubocop * Fix spec * Fix page view specs * form fixes * update error messages Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> Co-authored-by: baarkerlounger <db@slothlife.xyz>	4 years ago
Stéphane Meny	95880f641a	Rubocop rspec fixes (#264 )	4 years ago
baarkerlounger	3134ed1d10	CLDC-822: GDPR declined page content (#201 ) * GDPR declined page content * Add more tests * Use real words	4 years ago
baarkerlounger	348cb183eb	CLDC-825: Support suffixes and prefixes for numeric fields (#198 ) * Income frequency is derived rather than asked * Render prefix and suffix * Set header and suffix based on previous answer * Readme	4 years ago
baarkerlounger	8134c2db7d	CLDC-827: Add custom guidance partials (#192 ) * Add custom guidance partials * Add a test for the partial being rendered * Add some unit tests for this * Rubocop * Don't introduce heisenspecs * Use component * Add comment * Update check values * Make net_income_known enum	4 years ago

15 Commits (4694c202d7b771f7cd92444fde2c99bc690c7dc6)