Rachael Booth
469f1574fb
More years in request spec
2 years ago
Rachael Booth
884f547b16
Fix linting
2 years ago
Rachael Booth
05e11c1a27
Fix field number row identifier
2 years ago
Rachael Booth
84e5e6adda
Refactor BU processor tests
2 years ago
Rachael Booth
1dc5ddedd8
Sales log to csv fix
2 years ago
Rachael Booth
1b18096a05
Fix 2023 lettings row parser spec
2 years ago
Rachael Booth
8a466b4ed3
Further fixes
2 years ago
Rachael Booth
a2ca03b227
Tweak bulk upload error row component tests for year changes
2 years ago
Rachael Booth
2052ea4649
Fix lint
2 years ago
Rachael Booth
7017793ebe
More use of bulk_upload.year_combo in request tests
2 years ago
Rachael Booth
39756f5a72
Remove pre 2023 test
2 years ago
Rachael Booth
0bb6810355
More work on bu validator specs - mostly sales
2 years ago
Rachael Booth
ee22a41652
More fixes
2 years ago
Rachael Booth
0d389eaf8e
Refactor lettings validator_spec
2 years ago
Rachael Booth
10fb71e2e3
Use year combo function in bulk upload mailer tests
2 years ago
Rachael Booth
ae23749ae8
Update BU log creator specs for 2024
2 years ago
Rachael Booth
2ce8fe7d96
Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy
2 years ago
Rachael Booth
ebb1d58dce
Set 2024 date in form_handler_spec to be during crossover period as needed
2 years ago
Rachael Booth
5db0480bfd
Update validator_spec
2 years ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
2 years ago
Arthur Campbell
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
Rachael Booth
b5d38c5444
Remove one off reinfer_local_authority task
2 years ago
Rachael Booth
a8eb01e5aa
Temporarily disable test marked to delete at year end
2 years ago
Arthur Campbell
f423ec1cd5
CLDC-3505 further fixes to tests for year hard end ( #2493 )
...
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf0 .
* Make use of :ignore-validation-errors trait
* Try with end dates in past
* Revert "Try with end dates in past"
This reverts commit 6b87938d70 .
---------
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
2 years ago
kosiakkatrina
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
2 years ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
2 years ago
kosiakkatrina
8dcd80e4f8
Strip scheme ID ( #2487 )
2 years ago
Rachael Booth
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
kosiakkatrina
905f869460
CLDC-2939 Link to organisations from user pages ( #2489 )
...
* Link to organisations from user pages
* Fix test
2 years ago
Arthur Campbell
0ecd82bf8f
more tests fixed ( #2491 )
2 years ago
kosiakkatrina
5947a2027a
CLDC-3496 Move period creation to log ( #2490 )
...
* Move period creation to log
* Allow adding rent periods to organisations
* Update more tests
2 years ago
Rachael Booth
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
2 years ago
kosiakkatrina
30b86f5a86
CLDC-3289 Avoid freezing time in tests (part 2) ( #2432 )
...
* Refactor tests #1
* Refactor model form tests
* Update tasklist helper tests
* Update task list helper
* Fix test
* Udate model/forms tests
* Update model/validations tests
* Update a few more model specs
* Update bulk request tests
* Update policy tests
* lint
* Refactor
* More fixes
* Rabase fixes
* Refactor
* lint
2 years ago
Arthur Campbell
8f65fd35fd
Cldc 3505 fix tests that will break on rollover ( #2485 )
...
* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log
* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations
* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids
* fix a wide range of tests affected by the changes in log factories completed traits
2 years ago
kosiakkatrina
9dc4f0bbb6
CLDC-3523 Only count visible logs on CSV downloads page ( #2477 )
...
* Only count visible logs
* Refactor
* Update csv count for sales
2 years ago
kosiakkatrina
4c0c0d15eb
CLDC-3508 Search both datasets for UPRN ( #2479 )
...
* Search both datasets for UPRN
* Update presenter
* Update request stubs
2 years ago
Rachael Booth
0718c10847
CLDC-3522: Correct logic around BU address search and address not found errors ( #2476 )
...
* CLDC-3522: Correct logic around BU address search and address not found errors
* Fix lint errors
2 years ago
kosiakkatrina
4b218e759f
Update upcoming deadlines dates ( #2462 )
2 years ago
Arthur Campbell
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
2 years ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
2 years ago
Arthur Campbell
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
2 years ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
2 years ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
2 years ago
Rachael Booth
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
2 years ago
kosiakkatrina
310d31a61c
CLDC-3483 Update logger statements ( #2468 )
...
* Update logger statements
* Update test
2 years ago
kosiakkatrina
9f623e0cb2
CLDC-3274 Display organisation merges for a longer period ( #2456 )
...
* Display organisation merges for a longer period
* Refactor
2 years ago
kosiakkatrina
dbca9323ae
Do not display deleted schemes in homepage count ( #2458 )
2 years ago
Rachael Booth
4a5a912816
CLDC-3483: Prevent/fix missing letting allocation values ( #2453 )
...
* CLDC-3483: Enforce that all lettings allocation method fields are present for bulk uploads
* CLDC-3483: Add task to fix existing nil letting allocation values
* Better capitalisation
* Keep previous punctuation
* Use find_each for task
2 years ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
2 years ago
kosiakkatrina
9ed93efc58
CLDC-3474 Correctly construct dates for template validation ( #2447 )
...
* Correctly construct dates
* Update tests
2 years ago