submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	dc92466139	CLDC-3092 Update nationality question for 24/25 (#2193 ) * Add new nationality columns * Add nationality questions to lettings * Add nationality questions to sales * Infer nationality where appropriate * Add synonyms * Update csv exports * Export nationality_all for 24/25 * Update prefers not to say value * Set 24/25 nationality fields from BU * Undo the export (there's a separate ticket) * Correctly display answers * Rebase fixes, tests and lint * Set nationality from lettings BU 24/25 * Rename files, add synonyms and accents * Fix sales csvs * Extract constant	11 months ago
kosiakkatrina	8280d860cb	CLDC-2964 Save and export duplicate logs (#2141 ) (#2205 ) * Set and clear duplicate log references * Export duplicate_log_reference_id for lettings * Export duplicate_log_reference_id for sales * Export duplicate_log_reference_id in xml * Update existing duplicate log references * Add missing sales deduplication steps * Set duplicate_set_id straight on logs * Do not update updated_at to prevent export * Increment duplicate_set_id * Update duplicates when they change sets * Remove duplicates when deleting logs	11 months ago
kosiakkatrina	57a1b263d5	Revert "CLDC-2964 Save and export duplicate logs (#2141 )" (#2196 ) This reverts commit `71d78a6fde`.	11 months ago
kosiakkatrina	71d78a6fde	CLDC-2964 Save and export duplicate logs (#2141 ) * Create DuplicateLogReference * Set and clear duplicate log references * Export duplicate_log_reference_id for lettings * Export duplicate_log_reference_id for sales * Export duplicate_log_reference_id in xml * Update tests * Update existing duplicate log references * Rename a field * Add missing sales deduplication steps * Set duplicate_set_id straight on logs * Do not update updated_at to prevent export * Increment duplicate_set_id * Update duplicates when they change sets * Remove duplicates when deleting logs * correctly update duplicate set IDs when answer is changed through normal form flow	11 months ago
natdeanlewissoftwire	925d30868f	feat: use find_each everywhere to speed up file generation time (#2092 )	1 year ago
natdeanlewissoftwire	858de4913e	CLDC-3014 scheme csv download improvements (#2091 ) * feat: optimise locations count * feat: use each to preserve ordering, and optimise scheme downloads	1 year ago
kosiakkatrina	7d4e9bcef7	CLDC-2938 sales managing organisation (#2077 ) * Correctly route to sales owning organisation page * Display correct owning organisation options * Set managing organisation as user organisation * Add managing organisation question for sales * Display managing organisation users in created_by * set managing org to be same as owning org in BU * Add managed by filter to sales * Display reported by, correctly update owning org * Update factory and 2022 BU * refactor * Merge managed sales logs * test * Update managing organisation for sales bulk upload * Rebase tests * skip a test as it is not relevant as the rake task would have already been ran * PO fixes * Remove old collection managed sales validation * Update question header and filters conditions * remove feature toggle	1 year ago
natdeanlewissoftwire	d4d93ee44c	CLDC-2671 Update duplicate logs routing (#1983 ) * feat: add param to banner duplicate logs route * feat: pass org id param through for support user case * feat: update tests * feat: lint * feat: add one more org id param to change links * feat: add duplicate logs controller tests * feat: update duplicate log tests * feat: tests no duplicates page * feat: test params passed correctly on delete * refactor: lint * refactor: lint	1 year ago
natdeanlewissoftwire	2bc8501ffe	CLDC-2773 Update lettings (and sales) csv date format (#1954 ) * feat: update datetime format in csv services * feat: update tests * feat: keep system date fields in iso8601 format * feat: merge fix * feat: update tests	1 year ago
natdeanlewissoftwire	52cf157242	CLDC-2799 Lettings and Sales CSV export updates and sales bug fix (#1951 ) * feat: wip commit add person details to sales log csv service * feat: add comments * feat: update regex to include agen_known fields * feat: revert * feat: reject age_known fields and map codes and values to age fields instead * feat: add age1_known * feat: combine age not known and details not known fields * feat: update tests * refactor: lint * feat: update tests * feat: update lettings tests * feat: update question test	1 year ago
kosiakkatrina	f447939336	CLDC-2663 Import sales form id (#1851 ) * Add old form id column * Import old for id * Export old_form_id instead of old_id * Add old_form_id import task and service * rename a spec file	1 year ago
Arthur Campbell	8c34719987	CLDC-2291 refactor and minor updates to lettings log csv service (#1719 ) * form handler to return all questions from lettings forms for all years with ordering interleaved functionality and tests * refactor lettings log csv service and all associated tests remove methods on log models when we can call them directly on associated models update job to call the service directly with the collection of logs rather minor modifications to the sales log csv service update many test files to test the appropriate logic in the appropriate place * tidying final amendments to tests remove commented code rename variable * change the position of the rent value check field in the headers * CLDC-2492 add creation method field to logs (#1738) * create migrations to add creation method fields to both log types * add enum definition to logs for creation method * upadte csv export services to retrieve creation method values direct from the log, remove methods previously used from the log model * run migrations to update schema * ensure that logs created via bulk upload have this set correctly when created	2 years ago
Arthur Campbell	40cf0c10c2	CLDC-1633 build feature csv download of sales logs (#1568 ) * create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form * update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made * write tests to cover the desired functionality of the SalesLogCsvService * create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export * add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation * correct various linter complaints and tech review suggestions * minor amendment to add old_id and reorder early columns * undo my 'clever' refactor that broke things * refactoring of csv service after some tech review and some UI testing in review app * update tests to include a test of a full export and all values in teh csv * correct minor routing error to ensure correct url is shown and tab selected after requesting csv email * update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing * write request tests for the new functionality in the sales log controller, define authorisation in the controller * minor correction after rubocop's kind suggestion' * various corrections from first pass at PO, tech review, linter, etc * refactor :ordered_sales_questions_for_all_years * first pass at implementing flexible code-based form fixtures for testing * second pass * refactor all tests of :ordered_sales_questions_for_all_years to use new factories * some refactoring in the testing of the csv service * use that fact that params is always available in controllers and don't pass it around, inline some methods calls * correct minor bug to ensure that "Return to logs" link returns to the correct index page * remove reminder comments * write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions * fix linter complaints * minor alterations after rebase to account for changes made on other branches * refactor after code review * tweak fixtures after rebase containing alterations to the factory defaults	2 years ago

13 Commits (48a18627c4e01a7d4dcf6a2153712d6bc586199d)