submit-social-housing-lettings-and-sales-data

3064 Commits

265 Branches

309 Tags

88 MiB

Tree: 4a8e717a74

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	8f65fd35fd	Cldc 3505 fix tests that will break on rollover (#2485 ) * update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log * use completed trait rather than completed2024 trait from factories skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations * remove sale and start dates from logs in tests where that should not be important build rather than create to reduce db interactions in order that the setup is complete, build the necessary user and organisation with ids * fix a wide range of tests affected by the changes in log factories completed traits	2 years ago
Arthur Campbell	47378cf7df	CLDC 3414 update homepage (#2408 ) * create presenter class to hold all the db calls and data for showing the home page plus tests, some changes to factoreis and helpers necessary this should avoid an overly bloated controller method or calling the DB from a view helper * view partial changes to accommodate design changes, decouple box with counter and blue link boxes since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page. * redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller * adjust tests and factories and address api call stub * remove view helpers that are no longer being used and remove outdated tests for home page * amend presenter and associated calls from view, tests, to ensure support user always sees sales data * write request specs for the homepage * undo unnecessary change to factory * make corrections following rebase conflicts * various minor changes following tech review * logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them * resolve rebase confusion in csv fixture files	2 years ago

Author

SHA1

Message

Date

Arthur Campbell

8f65fd35fd

Cldc 3505 fix tests that will break on rollover (#2485 )

* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log

* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations

* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids

* fix a wide range of tests affected by the changes in log factories completed traits

2 years ago

Arthur Campbell

47378cf7df

CLDC 3414 update homepage (#2408 )

* create presenter class to hold all the db calls and data for showing the home page
plus tests, some changes to factoreis and helpers necessary
this should avoid an overly bloated controller method or calling the DB from a view helper

* view partial changes
to accommodate design changes, decouple box with counter and blue link boxes
since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page.

* redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller

* adjust tests and factories and address api call stub

* remove view helpers that are no longer being used and remove outdated tests for home page

* amend presenter and associated calls from view, tests, to ensure support user always sees sales data

* write request specs for the homepage

* undo unnecessary change to factory

* make corrections following rebase conflicts

* various minor changes following tech review

* logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them

* resolve rebase confusion in csv fixture files

2 years ago

2 Commits (4a8e717a74dfc88291e9af37295c1b585c21d73e)