545c748576
Don't expect unexpected cashdis error
10 months ago
8bd36b15eb
Fix lint
10 months ago
2499f2aab7
Fix sale information validations tests
10 months ago
3881b5b674
Fix tests
10 months ago
9763013ac1
Extract sale information validations into a separate translations file ( #2699 )
10 months ago
469211ce65
CLDC-3661 Update year format ( #2713 )
...
* Update year combo format
* lint
* Update tests and validations
* update model tests
* Update bu list year format
* Update test
10 months ago
443a19f42d
Update household validations ( #2708 )
10 months ago
f766388e48
CLDC-3666: Pull sales financial validations into translations file
10 months ago
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
11 months ago
eb355d6829
Update equity validation for resale ( #2559 )
12 months ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
1 year ago
636e40fc9d
CLDC-3505: Fix tests for hard year end part 4 ( #2509 )
...
* Add in past end dates for testing
* Temporarily disable test marked to delete at year end
* Remove one off reinfer_local_authority task
* Update validator_spec
* Set 2024 date in form_handler_spec to be during crossover period as needed
* Use bulk_upload.year_combo for comparison in request tests to avoid year dependancy
* Update BU log creator specs for 2024
* Use year combo function in bulk upload mailer tests
* Refactor lettings validator_spec
* More fixes
* More work on bu validator specs - mostly sales
* Remove pre 2023 test
* More use of bulk_upload.year_combo in request tests
* Fix lint
* Tweak bulk upload error row component tests for year changes
* Further fixes
* Fix 2023 lettings row parser spec
* Sales log to csv fix
* Refactor BU processor tests
* Fix field number row identifier
* Fix linting
* More years in request spec
* fix
* Don't use db unnecessarily in financial validations spec
* Fix sale date changing 2024 -> 2023 test
* Add tests for bulk_upload.year_combo
* Update bu factory year specification
* Refactoring
* Linting
* Don't use helper in factory
* Remove new 2023 specific test
* Remove dummy end dates
1 year ago
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
1 year ago
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
1 year ago
0ecd82bf8f
more tests fixed ( #2491 )
1 year ago
30b86f5a86
CLDC-3289 Avoid freezing time in tests (part 2) ( #2432 )
...
* Refactor tests #1
* Refactor model form tests
* Update tasklist helper tests
* Update task list helper
* Fix test
* Udate model/forms tests
* Update model/validations tests
* Update a few more model specs
* Update bulk request tests
* Update policy tests
* lint
* Refactor
* More fixes
* Rabase fixes
* Refactor
* lint
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
1 year ago
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
1 year ago
06d0b574b8
CLDC-NONE: Remove duplicate word in error message ( #2402 )
1 year ago
d15a11bda8
Update time dependant tests ( #2361 )
...
* Update feature tests
* Remove old rake tasks
* Update some unit tests
* Update more tests
* More tests
* Fix failing sales household validation test
---------
Co-authored-by: Robert Sullivan <robert.sullivan@softwire.com>
1 year ago
4baf0bcdfc
CLDC-3350: Add validation for mortgage+deposit for outright sales ( #2349 )
1 year ago
6d7a319b4f
CLDC-3338: Add tolerance to discounted sale calculations ( #2333 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
1 year ago
e52a8238cc
CLDC-3343 Check relat fields for people we collect data for ( #2335 )
...
* Check relat fields for people we collect data for
* rename
1 year ago
999a33e0f7
CLDC-3313 Update financial sale validations ( #2313 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
1 year ago
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
1 year ago
aca9eb6301
CLDC-3300 Update BU mortgageused error ( #2310 )
...
* Don't allow don't know as 2023 mortgageused
* Don't allow don't know as 2023 mortgageused for discounted ownership
* Allow mortgageused don't know if stairowned 100
* Update row parser test
* Move mortgageused validations onto the log model
* Allor outright sale mortgageused 3, don't allow non staircaseing shared ownership mortgageused 3
* Rebase fix
1 year ago
8693037132
CLDC-1944: Replace soft date validation with hard date validation for 2024 and allow dates before 2000 ( #2280 )
...
* CLDC-1944: Replace soft date validation with hard date validation for 2024 and allow dates before 2000 in cases of soft validation failure
1 year ago
ff55bed2b2
CLDC-2220 Update buyer pluralisation ( #2272 )
...
* Pluralise buyer in household characteristics/setup
* Pluralise buyer in sales information sections
* Pluralise buyer in savings
* Pluralise other buyers, update privacy notice test
* Pluralise buyer in validations and translations
* Route to pages when joint purchase is not answered
* Fix apostrophes
* Update translations
* More updates
1 year ago
36553f4777
CLDC-1970: Use more relevant error message for shared ownership income below 0 ( #2270 )
1 year ago
3856a175af
Add tolerance to soft validation ( #2240 )
1 year ago
2cf55470d0
CLDC-3177 Validate staircasing mortgage ( #2239 )
...
* Validate staircasing mortgage
* Fix BU tests
2 years ago
f266099e19
Update non staircasing mortgage validation ( #2238 )
2 years ago
ac16c74303
CLDC-3179 Update routing for previous postcode ( #2207 )
...
* Update routing for previous postcode
* Infer ppostcode_full for discounted sales
* Escape characters
* Update previous la routing
* Set prevloc
* Move postcode inferance
* Remove validation for 2024
* Update postgres in dockerfile
2 years ago
ea1a7b7f54
CLDC-3176 Make deposit dynamically optional ( #2210 )
...
* Update optional hint text for deposit in 24/25
* Make deposit dynamically optional, update BU
* Refactor conditional page
* Add validation
2 years ago
46aae6e774
Validate non staircasing mortgage value ( #2223 )
2 years ago
140e55d313
CLDC-3184 Add value/discount validation ( #2222 )
...
* Add value/discount validation
* fix postcode field
2 years ago
a3fb5313c0
CLDC-3175 Add max stairbought validation ( #2204 )
...
* Add max stairbought validation
* refactor tests
2 years ago
5bcd677961
CLDC-3178 Update grant validation type ( #2209 )
...
* Remove soft grant validation for 2024 onwards
* Validate grant amount for 24/25 onwards
* Only run the hard validation for Social HomeBuy and RTA
* Fix soft validation
2 years ago
5302889417
CLDC-3173 Add equity and staircase validation ( #2201 )
...
* Add equity and staircase validation
* Update BU tests
2 years ago
44abe22ea9
CLDC-3183 Validate previous tenure for discounted sales ( #2206 )
...
* Validate previous tenure for discounted sales
* typo
2 years ago
869bb45438
CLDC-3174 Validate stairowned is not equal stairbought ( #2198 )
...
* Validate stairowned is not equal stairbought
* Update BU tests
* Update error message
2 years ago
8f5acc55ce
CLDC-3164 Change discounted ownership value to hard validation ( #2176 )
...
* Move soft validation to hard for 2024
* Update a date on a test
* Update validation message
* Deduplicate validations
2 years ago
b791d7be85
CLDC-3165 Update shared ownership validation ( #2184 )
...
* Do not trigger soft validation for 2024
* Add hard shared ownership deposit validation
* Remove irrelevant test
* Update validation message content
2 years ago
7dcbfb1341
CLDC-3228 Age validation update ( #2197 )
...
* feat: unrelated nil safe notifications tweak
* feat: update under 16 validations and copy
* feat: include person_num in error text
* feaT: update copy for relat
* feat: update tests
2 years ago
b50f7899f6
Only trigger savings validation if mortgage used ( #2180 )
2 years ago
3eacbcb0d8
CLDC-2951 Display postcodes error on ownership type ( #2111 )
...
* Display postcodes error on ownership type
* Add error to uprn
2 years ago
4de6003f5f
CLCD-2836 Use available from date for absorbing organisations validations ( #2000 )
...
* Use available from date for absorbing organisations validations
* Update sales validations
* typo
* Display correct date in the error message
2 years ago
f4bb3e2610
Correctly map equity ranges ( #1964 )
2 years ago
9ae32ac266
remove validate_years_living_in_property_before_purchase ( #1878 )
2 years ago
1ffe8a4b8b
CLDC-2109 Add merged org validations to sales log ( #1826 )
...
* Add merged orgs sale dat validations
* Add organisation validation to sales log
* Adjust dates
* Update error message
2 years ago
Rachael Booth
kosiakkatrina
Manny Dinssa
Arthur Campbell
Robert Sullivan
natdeanlewissoftwire