* feat: assign simultaneously
* feat: assign simultaneously
* feat: revert
* feat: fix back persistence behaviour and update similar issues elsewhere, also remove redundant back text in govuk back links
* feat: add previous_page_redirect_paths to avoid infinite loops
* feat: leave here to avoid possible loops
* feat: leave here to avoid possible loops
* feat: add check answers page behaviour
* refactor: tweak
* feat: make tests pass, simplify code and incorporate tasklist/check answers back routing
* feat: update tests
* refactor: lint
* CLDC-1849 Add hint to discounted ownership purchase price
* Use PurchasePriceDiscountedOwnership in rtb page
* show question with updated hint to certain types of answers
* rubocop
* Only display shared ownership hint in some occations
* Add abstract log class and sales log class
Created a parent log class for sales log and lettings log. Any bits common
to both sales and lettings can live in the parent class. As the sales log
functionality is built up any commonalities with lettings log can be extracted
into the parent log class. The sales log model is set up without a json form
and instead the form is defined in code - like the setup section of the lettings
log.
* update sales logs controller
* update lettings controller specs
* update filter method name
* update organisations controller
* use lettings method
* Add deleted tests back
* lint
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Kat <kosiak.katrina@gmail.com>
This renames the case_log to lettings_log as everything we've written so
far has been geared towards lettings of social housing so it makes sense to
have the name describe this. This is also a precursor to adding in stuff for
sales logs (whatever shape that takes)
Co-authored-by: James Rose <james@jbpr.net>
* Set up failing test for new soft validation design
* remove unneeded js controller
* remove unneeded controller and spec
* rename net income validation override column
* spec form changes (to allow tests to run)
* validation spec changes
* replace all instances of override_net_income_validatiom
* passing first test
* Add to form and import styling
* remove unneeded code from interruption screen view
* Update test & code - failing last new expectation
* Display 2 previous question answers in the informative text
* extract displaying of the informative text into a helper
* Add tests for helper
* Remove some of the previous soft validations set up
* fix some failing specs
* Fix more tests
* lint
* Reset earnings question prefix and suffix to initial values instead of nil
* make it route backwards on a no
* test and linter fixes
* refactor next_page
* stryling
* more changes
* fix specs
* update real form
* design tweaks
* delete commented out tests
* content changes
* content changes
* changes to informative/hint text
* More robust styles for interuption panel, use smart quotes
* Rubocop
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Add a non temp accommocation validation for vacancy reason
* Only show errors relevant to the page questions
* Add referral question/field
* Add validation for referrals and vacancy reasons
* change error message content
* Hackety hack hack
* Leave JS hooks until text conditionals are updated as well
* Fix JS errors and remove UJS
* Reload the GOV UK frontend JS
* Fix armed forces case
* Remove obsolete tests and config
* Temo fix for household members question
* Unit test
* Add helper unit test
* Correctly failing spec
* We still need stimulus to clear answers
* Fix styling issues
* Refactor style logic into helper
* Form fix
* Conditional check box questions are shown on a new page
* Update readme
* Fix date bug
* Clear conditional date fields if invalidated by top level answer
Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com>
* Only enhance select element once
* Add test for disabled select option
* Select by key
* Test for selected option
* Rubocop
* Instance vars
* Don't turbo cache page to make js function act each time
* Add page titles and lint
* Make github use Node 14
(cherry picked from commit 86baa53972aa87676bb720a9f772620afa9a1be9)
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Check answers to tasklist
* Fix status display
* Fix case log status
* Update footer
* Update spec
* Fix spec
* Make form pages 2/3 width
* Make spec failures less likely
* Working except for selenium checkbox issues
* Remove old debug message
* Make sure we only run the stimulus init once per page load
* Revert that
* Rubocop
* Use data targets rather than id lookup, so that coupling is explicit
* Use fetch
* Schema update
* No schema changes introduced here
* Add a request spec for the new controller
* Schema order did change
* map over forEach
* Update factory fields
* Int for booleans :(
* Fix spec fields
* Lazy create
* Init
* Add some tests
* Add failing spec
* Move soft validations into a module
* Update test
* Rubocop
* Scope are auto created by enums
* Rename folder to validations
* No instance variable
* Commit both lines
* Add error indication
* Make partial slightly more generic
* Fix back link
* Write failing test
* All specs currently passing. Can this be real?
* Check page should have an override question
* Fix back button for check answers pages
* Don't really need a wrapper method for the validations
* We're really validating a page here not a question
* Dup variable
* Bit of a nasty hack but maybe better than deriving back link?
* Set a no cache header instead of reloading
* Move a teeny bit of logic out of the controller
* Rubocop
* Extract method
* Add next page path method with conditional routing
* Rename method
* Fix the tests and add files to .gitignore
* Make get_next_page_path a private method
* WIP test for total question count
* Change back button to use rails navigation
* Make total number of questions work with conditional routing and run rubocop
* Add tests for conditional question displaying
* Add conditional routing to the check answers page
* push 1 failure
* make total_questions step over the form like a user would and gather relevand questions
* Fix the tests
* fixed checks answers labels
* small refactors and rubocop
* remove unused code from get next page path
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: magicmilo <milobascombe@gmail.com>
* Form with model so that we can validate (hypothetically)
* Put turbo frame back
* Turbo can update form errors if submitting returns 422
* Refactor and fix specs
* String interpolation over concatenation
kosiakkatrina
natdeanlewissoftwire
Jack
James Rose
natdeanlewissoftwire
Dushan
Ted-U
Paul Robert Lloyd
kiddhustle
Paul Robert Lloyd
baarkerlounger
baarkerlounger
Matthew Phelan