submit-social-housing-lettings-and-sales-data

3216 Commits

243 Branches

294 Tags

82 MiB

Tree: 5a5463083c

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	b4cd777897	CLDC-2972 Warn users about answers that will be cleared in bulk upload (#2142 ) * Empty commit * feat: base lettings behaviour * feat: formatting improvements * Empty commit * Empty commit * Empty commit * refactor: lint * feat: more page styling * feat: update tests * refactor: lint * feat: add requests spec * refactor: simplify * feat: add tests * feat: copy change to reflect that the count in the header is not necessarily as large as the errors shown (it excludes duplicate errors on fields, and not_answered errors) * feat: copy changes to sales as well * feat: remove LegacyBulkUpload MVC * feat: fix typo * feat: update tests * feat: mark additional not_answered sales q * feat: update routing and only display warnign text when errors will be cleared * feat: update copy and error rows * refactor: lint * feat: don't show soft validations in deletion report * feat: update routing so deletion report is not shown once logs uploaded * feat: update tests * feat: make unique count track repeated errors across rows * refactor: lint	2 years ago
Phil Lee	443ad2cd82	CLDC-2195 Back to button CTA (#1613 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2195 - to allow users to continue their journey after completing logs adding a CTA link on completed logs # Changes - when a completed bulk uploaded log shown link back to logs for that bulk upload - if all those logs are completed interstitial is shown which links back to all logs - when a completed lettings or sales log show, link back to lettings or sales logs index # Screenshots ![Screenshot 2023-05-10 at 13 34 32](https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/assets/92580/0eecbe4a-1ffd-4de8-8493-9754fd7de0b5)	3 years ago
Phil Lee	c7db5102f6	CLDC-2294 Add authorization to bulk upload results (#1591 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2294 - When bulk upload returns a results page it would be useful if colleagues of the uploader can see this page to help fix errors - It would also be useful if support users can see these reports to help diagnose bulk upload errors # Changes - Added `pundit` gem to handle authorization - Bulk upload results previously only accessible to the bulk uploader. Now they can be seen by users in the same org as the uploader and also support users	3 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

b4cd777897

CLDC-2972 Warn users about answers that will be cleared in bulk upload (#2142 )

* Empty commit

* feat: base lettings behaviour

* feat: formatting improvements

* Empty commit

* Empty commit

* Empty commit

* refactor: lint

* feat: more page styling

* feat: update tests

* refactor: lint

* feat: add requests spec

* refactor: simplify

* feat: add tests

* feat: copy change to reflect that the count in the header is not necessarily as large as the errors shown (it excludes duplicate errors on fields, and not_answered errors)

* feat: copy changes to sales as well

* feat: remove LegacyBulkUpload MVC

* feat: fix typo

* feat: update tests

* feat: mark additional not_answered sales q

* feat: update routing and only display warnign text when errors will be cleared

* feat: update copy and error rows

* refactor: lint

* feat: don't show soft validations in deletion report

* feat: update routing so deletion report is not shown once logs uploaded

* feat: update tests

* feat: make unique count track repeated errors across rows

* refactor: lint

2 years ago

Phil Lee

443ad2cd82

CLDC-2195 Back to button CTA (#1613 )

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-2195
- to allow users to continue their journey after completing logs adding a CTA link on completed logs

# Changes

- when a completed bulk uploaded log shown link back to logs for that bulk upload
- if all those logs are completed interstitial is shown which links back to all logs 
- when a completed lettings or sales log show, link back to lettings or sales logs index

# Screenshots

![Screenshot 2023-05-10 at 13 34 32](https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/assets/92580/0eecbe4a-1ffd-4de8-8493-9754fd7de0b5)

3 years ago

Phil Lee

c7db5102f6

CLDC-2294 Add authorization to bulk upload results (#1591 )

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-2294
- When bulk upload returns a results page it would be useful if colleagues of the uploader can see this page to help fix errors
- It would also be useful if support users can see these reports to help diagnose bulk upload errors

# Changes

- Added `pundit` gem to handle authorization
- Bulk upload results previously only accessible to the bulk uploader. Now they can be seen by users in the same org as the uploader and also support users

3 years ago

3 Commits (5a5463083c6fc641c7bd707e090ca6757633330b)