Daniel Baark
81ff68bb11
CLDC-510: Income range soft validations ( #72 )
...
* Init
* Add some tests
* Add failing spec
* Move soft validations into a module
* Update test
* Rubocop
* Scope are auto created by enums
* Rename folder to validations
* No instance variable
* Commit both lines
* Add error indication
* Make partial slightly more generic
* Fix back link
* Write failing test
* All specs currently passing. Can this be real?
* Check page should have an override question
* Fix back button for check answers pages
* Don't really need a wrapper method for the validations
* We're really validating a page here not a question
* Dup variable
* Bit of a nasty hack but maybe better than deriving back link?
* Set a no cache header instead of reloading
* Move a teeny bit of logic out of the controller
* Rubocop
* Extract method
3 years ago
baarkerlounger
d92dd2d8b1
Rubocop
3 years ago
Matthew J. Phelan
7397483078
Merge pull request #74 from communitiesuk/CLDC-467/validate_other_household_members
...
Cldc 467/validate other household members
3 years ago
Matthew Phelan
4a4ffd90f2
Merge branch 'main' into CLDC-467/validate_other_household_members
3 years ago
Matthew Phelan
ba9cdd31a2
Code review updates
3 years ago
magicmilo
ec130db9ac
add select box and pages, waiting for naming convetion meeting
3 years ago
Milo
f52f498f2c
Merge pull request #70 from communitiesuk/CLDC-497-SharedAccomodationBedrooms
...
Cldc 497 shared accomodation bedrooms
3 years ago
magicmilo
6ca1fa1bc2
fix merge
3 years ago
magicmilo
a83a0c53fd
fix merge and move validation
3 years ago
magicmilo
31b594d51c
switched to between for range
3 years ago
magicmilo
654d4ae8e5
add select
3 years ago
Milo
f7a7987f2b
Merge branch 'main' into CLDC-497-SharedAccomodationBedrooms
3 years ago
magicmilo
ee2323a805
Switch to household number of other members
3 years ago
baarkerlounger
d240e299bd
Add some test for our validations
3 years ago
baarkerlounger
656c7bda26
Specs passing
3 years ago
Matthew Phelan
c3e1f07797
validate_other_household_members refactor
...
Co-authored-by: Daniel Baark <baarkerlounger@users.noreply.github.com>
3 years ago
Matthew Phelan
bdefe35caa
Merge branch 'main' into CLDC-467/validate_other_household_members
3 years ago
Daniel Baark
fff5da304e
Refactor validations into modules ( #73 )
...
* Refactor validations into modules
* PropertyValidations
* Add financial and tenancy validations
* Shorten comment
* Simplify
3 years ago
Matthew Phelan
971c3909ee
validate_other_household_members
3 years ago
kosiakkatrina
c7cd48c2e8
CLDC-513: Refused income validation ( #71 )
...
* Add net income known field
* only require the income if it is known
* fix a typo
3 years ago
Daniel Baark
f372a4727e
Hard validation ( #69 )
3 years ago
Milo
5c8a306cf2
Merge branch 'main' into CLDC-497-SharedAccomodationBedrooms
3 years ago
magicmilo
2367ad16d5
tests and tweaks
3 years ago
kosiakkatrina
055cbf8fc5
CLDC-464: Other tenancy type validation ( #68 )
...
* Add other_tenancy_type conditional field
* Extract private validdate_other_field_method
* Implement other tenancy type validation
* Add missing migration file and update API doc
3 years ago
baarkerlounger
fba2474747
rubocop
3 years ago
Milo
a78a9a0e13
Merge pull request #64 from communitiesuk/CLDC-469-if-served-did-leave-validation
...
added armed forces active response validation
3 years ago
Milo
f8a460b424
Merge branch 'main' into CLDC-469-if-served-did-leave-validation
3 years ago
Milo
562883495d
Merge pull request #65 from communitiesuk/CLDC-493-OutstandingRentAmount-Validation
...
added simple validation for outstanding rent
3 years ago
magicmilo
073ccfe633
rubocop
3 years ago
Milo
de4d58b711
Merge branch 'main' into CLDC-469-if-served-did-leave-validation
3 years ago
magicmilo
512e3a5a82
added required armed forces fields to example
3 years ago
magicmilo
d3de1f660d
Merge branch 'CLDC-493-OutstandingRentAmount-Validation' of https://github.com/communitiesuk/mhclg-data-collection-beta into CLDC-493-OutstandingRentAmount-Validation
3 years ago
magicmilo
096cb8fae7
replace tenant to person_1 in examples and required of API Json
3 years ago
Milo
3a7935ec5c
Merge branch 'main' into CLDC-493-OutstandingRentAmount-Validation
3 years ago
magicmilo
1cf1197096
tests
3 years ago
Daniel Baark
c5e6506e48
Database Cleaner ( #67 )
3 years ago
kosiakkatrina
c39271d486
CLDC-466: Add fixed term tenancy validation ( #66 )
...
* Add fixed term tenancy validation
* refactor validate_fixed_term_tenancy
* add fixed_term_tenancy pattern to api docs and make it dynamically not required
3 years ago
magicmilo
d4497883ae
rubocop
3 years ago
magicmilo
bea7c54e5a
inital
3 years ago
kosiakkatrina
2c1f246350
CLDC-473: Add net income uc proportion validation ( #62 )
...
* Add validate_net_income_uc_proportion validation/
* refactor validation method;
* Update net income options in doc
* rubocop
* refactor validate_net_income_uc_proportion and increase the persons checked to 8
* rename tenant economic status field
3 years ago
Milo
7f76b9c18e
Merge branch 'main' into CLDC-493-OutstandingRentAmount-Validation
3 years ago
magicmilo
3d2699e557
added simple validation for outstanding rent
3 years ago
magicmilo
c1596817d2
fix conflicts
3 years ago
Milo
db346f7cca
Merge pull request #63 from communitiesuk/CLDC-471-pregnancy-validation
...
Cldc 471 pregnancy validation
3 years ago
magicmilo
938c5b9807
updated age and gender field person_1 in docs
3 years ago
magicmilo
c6fb2580df
rubocop
3 years ago
magicmilo
ede51029e9
rubocop
3 years ago
magicmilo
4520b3a1cc
added armed forces active response validation
3 years ago
magicmilo
88043a9386
made validator private method
3 years ago
magicmilo
62ce94d8cc
fix bad migration
3 years ago