submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	ac4ee2a1fb	Cldc 1600 refactor form handler (#875 ) * Add previous, current and next forms to form handler * Add current, previous and next sales forms to form handler * Implement current_lettings_form, current_sales_form and store year and form type in form * refactor lettings_forms * Use current, previous and next forms in lettings log model * Use current, previous and next forms in sales log model * use current, previous and next forms in csv service * Remove "startyear_endyear" forms from form handler * Remove name from form initializer and add an optional start year * refactor get_form * update csv test, fix form initialize * rebase fix * Refactor form_name_from_start_year method out * remove unused variable * fix typo, add date tests * rebase, fix tests * add comment to before test block * Change the FormHandler back to only contain the form objects * extract name	2 years ago
Dushan	67ce147fc9	Extract base log and create sales log (#858 ) * Add abstract log class and sales log class Created a parent log class for sales log and lettings log. Any bits common to both sales and lettings can live in the parent class. As the sales log functionality is built up any commonalities with lettings log can be extracted into the parent log class. The sales log model is set up without a json form and instead the form is defined in code - like the setup section of the lettings log. * update sales logs controller * update lettings controller specs * update filter method name * update organisations controller * use lettings method * Add deleted tests back * lint Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Kat <kosiak.katrina@gmail.com>	2 years ago
baarkerlounger	7de5558295	Refactor log setup into code (#672 ) * Refactor log setup into code * Fix remaining tests * Revert schema changes * Add tests for setup section Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * rename spec Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	3 years ago
baarkerlounger	eb72bc6ffd	Refactor log setup into it's own form (#663 ) * Refactor log setup into it's own form * Use factory * Run workflow on push to PR * Array matcher on heisenspec	3 years ago
baarkerlounger	6139866565	Improve DB seeding (#556 ) * Improve DB seeding * Don't seed LA Rent Ranges in test	3 years ago
baarkerlounger	6f6496ceaa	Unit test	3 years ago
baarkerlounger	d55a028719	Have form handler class decide the current form	3 years ago
baarkerlounger	daf1211510	Data collection windows don't follow the calendar year (#209 )	3 years ago
baarkerlounger	c568dcdf3d	Iterate over all forms (#176 ) * Iterate over all forms * Re-lookup page to ensure we have the definition for the right form * Match form naming convention for spec and real * Add test for case log form	3 years ago
baarkerlounger	5248a96db3	Linting	3 years ago
Dushan	beccd74f83	CLDC-530 reduce test dependency on form definition (#46 ) * use test_form.json in tests * Pass in form to view from controller for check_answers * reduce test json length for household section * Further shorten the test json * Remove extra radio questions from test json household section * Trim test form and fix tests * do some method extraction * Extract creation of form into a formHandler * rubocop * redefine form model to use filepaths instead * Check test env var in form handler * remove singleton and make get_all_forms a private method * refactor get_all_forms Co-authored-by: Kat <katrina@madetech.com>	3 years ago

11 Commits (624f33389b44d27de466f9a44f90499c23bbc8b4)