kosiakkatrina
6310a48610
CLDC-2795 Confirm scharge, pscharge and supcharge soft validations ( #1915 )
...
* Confirm scharge, pscharge and supcharge soft validations for completed logs
* This test seems flaky, likely because of the order, so reducing #of logs
1 year ago
natdeanlewissoftwire
647f9fbc59
Update internal transfer validation ( #1924 )
...
* feat: remove residential care home from internal transfer validation
* feat: update tests
* feat: update tests
* feat: update tests
1 year ago
kosiakkatrina
ea9c84e2a1
Display old log id in the missing answers examples ( #1914 )
1 year ago
kosiakkatrina
2f986fe111
CLDC-2795 Update charges validations ( #1912 )
...
* Update charges hard maximums
* Add charges value check fields
* Add 2023 charges value check pages and questions
* add scharge_over_soft_max method
* add LA cases
* Add pscharge_over_soft_max method
* Add supcharg_over_soft_max method
* Add pages to subsections (2023) and update content
* Confirm soft validations when importing
* csv tests
* Fix copy for 2022
1 year ago
kosiakkatrina
7a64cb7f56
CLDC-2776 Add referral option to general needs logs ( #1910 )
...
* Add option to referral PRP general needs questions
* Add referral value check
* Add referral value check to 2023
* Update soft validation content
* Add referral value check to 2022
* Confirm soft validation on import
* Tests
1 year ago
kosiakkatrina
3da6416950
Set income and savings not known for in progress logs ( #1911 )
1 year ago
natdeanlewissoftwire
20337fde59
Migration use kebab org fields ( #1913 )
...
* feat: use kebab case org fields
* feat: update tests
1 year ago
kosiakkatrina
d3dec60f39
Only set soc tenant fields for 2022 or if they're given ( #1908 )
...
* Only set soc tenant fields for 2022 or if they're given
* Refactor
1 year ago
kosiakkatrina
a1cc9d7863
Move person details if some persons are skipped ( #1903 )
...
* Move person details if some persons are skipped
* Check that undesired person details don't get saved
* Make sure we don't repeat people details
1 year ago
kosiakkatrina
077390bb5b
CLDC-2699 Update values updated at when updating reason field ( #1909 )
...
* Update values updated at
* Update tests
1 year ago
natdeanlewissoftwire
c80565a54d
Make saledate nil safe(r) ( #1904 )
...
* feat: allow missing day/month/year values if CompletionDate exists as we don't always receive these from old core
* feat: make safe string as decimal nil safer too
* feat: add test
1 year ago
natdeanlewissoftwire
213a4bf229
Blank invalid combined income and proplen values on migration ( #1907 )
...
* feat: clear invalid combine incomes
* feat: clear out of range proplen values
1 year ago
kosiakkatrina
564fa9ebb5
Mark hodate value check confirmed ( #1906 )
...
* Mark hodate value check confirmed
* Add other missing value_checks for sales
1 year ago
kosiakkatrina
c049089684
CLDC-2725 Add missing sales data report ( #1893 )
...
* Add missing sales answers reporting
* Fix log name
1 year ago
kosiakkatrina
bda7bc7d08
Only blank tenancy length when it is invalid for tenancy type ( #1902 )
...
* Only blank tenancy lenght when it is invalid for tenancy type
* Update spec/services/imports/lettings_logs_import_service_spec.rb
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
---------
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
1 year ago
kosiakkatrina
f59c67b651
Add reimport reason update_field case ( #1896 )
1 year ago
kosiakkatrina
11ca1bbcff
CLDC-2724 Add missing data reporting for imported lettings logs ( #1892 )
...
* Add generate_missing_answers_report task and method
* Create example report
* change task description
* refactor
* Report old form id instead of old id
1 year ago
natdeanlewissoftwire
19ad92c21d
feat: don't raise "no matching location" error ( #1900 )
1 year ago
natdeanlewissoftwire
41228e2295
Fix hundredth error on migration of very small scharge values ( #1898 )
...
* feat: round all decimal values to 2dp in safe_string_as_decimal
* refactor: lint
1 year ago
natdeanlewissoftwire
e5e6e1e21a
Enforce offered as integer ( #1897 )
...
* feat: ensure offered is an integer (decimal 0 was triggering validation errors)
* feat: allow decimals but clear when not integer equivalent as per new requirements
1 year ago
kosiakkatrina
c3636c1286
CLDC-2696 Add reimport addresses task ( #1891 )
...
* Add update address service for lettings
* Only process collections 2023 onwards
* Update app/services/imports/lettings_logs_field_import_service.rb
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
* Refactor postcode_known
* test
---------
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
1 year ago
kosiakkatrina
719321945b
Set unassigned user if legacy user belongs to a different organisation ( #1894 )
...
* Set user to unassigned in lettings logs if the legacy user exists but belongs to a different organisation
* Set user to unassigned in sales logs if the legacy user exists but belongs to a different organisation
* Lint
1 year ago
kosiakkatrina
2920917292
Create an unassigned user per organisation ( #1885 )
1 year ago
kosiakkatrina
3b53e3e696
Remove homelessness validation ( #1877 )
1 year ago
kosiakkatrina
4d275a5c02
CLDC-2689 Export migrated logs ( #1873 )
...
* Add imported_at columns
* Set imported at date for lettings logs
* Set imported at for sales logs
* Export logs migrated since the previous partial export
* Rename column
* rebase changes
* Re-add test
1 year ago
kosiakkatrina
3437f9725e
CLDC-2753 Add unassigned user for imported logs ( #1883 )
...
* Add unassigned user if we can't find a legacy user for a log
* Add generate_unassigned_logs_report
* Log user email address if validation fails on user import
1 year ago
natdeanlewissoftwire
2256cc9d73
Migration fixes ( #1881 )
...
* feat: make offered unsafe as 0.00 is an expected value
* feat: add correct refused options for sex and relat questions
* refactor: lint
* feat: use safe_string_as_decimal
1 year ago
kosiakkatrina
3bd6cab5c5
CLDC-2684 Allow full export per year ( #1875 )
...
* Allow full export for specific year
* Update production manifest
* Call export_xml_lettings_logs with nil if no year is given
* Rename method
1 year ago
natdeanlewissoftwire
ef08519de2
feat: update org importer to handle xmls without institution namespace ( #1879 )
...
* feat: update org importer to handle xmls without institution namespace
* refactor: lint
* refactor: lint
* feat: remove erroneously added file
1 year ago
Jack
abf9aa07a9
CLDC-2665 Switch lettings ppcodenk ( #1854 )
...
* Switch lettings ppcodenk
* Address Kat's comment
* separate process postcode methods
* tests
* Update row parsers
* Update conditionals
* Add rake task to update ppcodenk
* Bring back value_is_no?
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
1 year ago
kosiakkatrina
f447939336
CLDC-2663 Import sales form id ( #1851 )
...
* Add old form id column
* Import old for id
* Export old_form_id instead of old_id
* Add old_form_id import task and service
* rename a spec file
1 year ago
kosiakkatrina
5ec33c7938
CLDC-2642 Make other client group mandatory ( #1871 )
...
* Make has_other_client_group a mandatory question
* Add a rake task to update has_other_client_group
* test and lint
* Set has_other_client group on import
1 year ago
kosiakkatrina
3b13dcc62f
CLDC-2702 Prioritise addresses over UPRN on import ( #1866 )
...
* Prioritise addresses over UPRN
* Prioritise addresses over UPRN - sales
* Add test case
1 year ago
kosiakkatrina
fae4b04cef
CLDC-2662 Add incomplete locations validation ( #1867 )
...
* Add incomplete location validation
* Clear incomplete locations on import
* tests
* Update copy
1 year ago
kosiakkatrina
07a6e5a719
Add more logging for the exports ( #1862 )
1 year ago
kosiakkatrina
e88e1bae8a
CLDC-2684 Retrieve recent export before creating new one ( #1860 )
...
* Retrieve recent export before creating new ones
* remove comment
1 year ago
kosiakkatrina
b922752cea
Export additional id fields ( #1841 )
1 year ago
natdeanlewissoftwire
8448b559a8
Add owning org id to field import task for sales ( #1850 )
...
* feat: add field import service and test
* feat: use old visible org id
* feat: tweak test
* feat: update rake task
* feat: split sales and lettings rake tasks
* feat: update rake task
* feat: PR comment tweaks
* feat: rename and update tests
* refactor: lint
1 year ago
kosiakkatrina
c3b3c6200a
CLDC-2602 Only log errors into the s3 ( #1843 )
...
* Only log errors into the s3
* lint
1 year ago
kosiakkatrina
b93a6456d4
CLDC-2602 Save import logs to S3 ( #1829 )
...
* Add logger that writes to s3 file
* Add logger for logs import
* remove unused method
* Update organisation import service spec
* Partition log files per org
1 year ago
kosiakkatrina
4891897fdc
Bump commonmarker from 0.23.9 to 0.23.10 in /docs ( #1832 )
...
* Bump commonmarker from 0.23.9 to 0.23.10 in /docs
Bumps [commonmarker](https://github.com/gjtorikian/commonmarker ) from 0.23.9 to 0.23.10.
- [Release notes](https://github.com/gjtorikian/commonmarker/releases )
- [Changelog](https://github.com/gjtorikian/commonmarker/blob/v0.23.10/CHANGELOG.md )
- [Commits](https://github.com/gjtorikian/commonmarker/compare/v0.23.9...v0.23.10 )
---
updated-dependencies:
- dependency-name: commonmarker
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* test
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
kosiakkatrina
ccefc3169b
CLDC-2656 Import location code ( #1833 )
...
* Import location code
* escape the dots
* Add all LA mappings
1 year ago
kosiakkatrina
8a3f18d3ac
CLDC-2621 Flag orgs without coordinators ( #1818 )
...
* Add import report service
* Call ImportReportService from rake task
* Move generate_logs_report to import service
* Add organisations without active data coordinators to the report
* pluralize method names
* update suffixes
1 year ago
natdeanlewissoftwire
fb389414a0
CLDC-2504 Add owning org select to sales if there are stock owning absorbed orgs ( #1815 )
...
* feat: wip update sales org select
* feat: update routing and hidden in check answers methods
* feat: set sales org id as derived
* feat: update tests
* refactor: linting
* feat: update tests and radio options
* feat: update test
* feat: add value helper test for non-constant value question
* refactor: lint
* feat: freeze time in unrelated test
* refactor: linting
1 year ago
kosiakkatrina
9abde36f94
CLDC-2570 Add merge organisations service and rake task ( #1801 )
...
* Create merge_organisations_service
* Refactor tests
* update schemes merge
* rename scope
* merge letings logs
* Merge sales logs
* refactor merge organisations service
* Rollback transaction if there's an error merging orgs
* Add logging
* add merge_organisations rake task
* mark organisations as merged
* update rake task
* Update rake task add tests for multiple merging orgs
* Add more tests for merging relationships
* Update merge logging
* set absorbing organisation relationship
1 year ago
kosiakkatrina
6e8acbc927
Set housingneeds other to no if any of the housing needs are given ( #1812 )
1 year ago
Jack
87a5265c05
CLDC-2168 Bugfix - handle empty file ( #1795 )
...
* Bugfix - handle empty file
* Count rows without headers
* Add host to sentry tags
* Add test for blank file with headers
* Fix sales validator
* Validate also content of rows
* Use compact
* Add 2023-2024 lettings empty file spec
* Update sales template
1 year ago
kosiakkatrina
bd300cae04
CLDC-2592 Clear import fields ( #1810 )
...
* Clear brent below absolute minimum
* Clear beds over the max for the number of tenants
1 year ago
Rachael Booth
b8c01e0caa
CLDC-2591: Rewrite import task ( #1803 )
...
* Rewrite import task
* Fix lettings log import service test
1 year ago
kosiakkatrina
1fbd3c90dd
Update allowed lead tenants age in foster care validation ( #1786 )
1 year ago