baarkerlounger/submit-social-housing-lettings-and-sales-data - submit-social-housing-lettings-and-sales-data - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
carolynbarker	944b4f4f1f	CLDC 3899 fix deactivation period edge case bugs (#2995 ) * rename variable for clarity * remove unused variable * make reactivating_soon message refer to the soonest, not most recently created * status check all deactivation periods instead of just one * handle no open period to reactivate * test deactivation period related behaviour * fix reactivation message variable syntax * use before do instead of let for unreferenced variables * fix reactivation message syntax for location * fix test indentation * remove unused variable - part 2 * lint * handle edge case of overlapping periods * end unclosed Timecop freeze causing flaky tests * remove unused around blocks superseded by befores * tidying up * reinstate setup needed to test default date * fix typo * explain deactivation period validation logic * fix setup to test default date --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	10 months ago
Manny Dinssa	53c3b3e61a	CLDC-3633 Full stops in error messages (#2628 ) * Make full stops consistent in error messages * Fix test * Update few hardcoded errors * Update join in remaining row parsers * Update some more tests * Update more hard coded BU errors * Fix typo I introduced - bedrooms to bedroom --------- Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	1 year ago
kosiakkatrina	30b86f5a86	CLDC-3289 Avoid freezing time in tests (part 2) (#2432 ) * Refactor tests #1 * Refactor model form tests * Update tasklist helper tests * Update task list helper * Fix test * Udate model/forms tests * Update model/validations tests * Update a few more model specs * Update bulk request tests * Update policy tests * lint * Refactor * More fixes * Rabase fixes * Refactor * lint	2 years ago
Arthur Campbell	9bbc2c2e17	CLDC-1687 allow deactivation or reactivation of last year schemes and locations in crossover period (#1396 ) * create method to test whether we are currently in the crossover period and associated tests * update copy, use method for testing whether we are in the crossover period, remove focus from test file * reuse existing method to determine whether we are in a collection period * use the existing method and update validations * fix test broken by changes * update location in same way as scheme * create method on FormHandler that finds the start date of the earliest collection period * ensure that default deactivation and reactivation dates also reflect the changes * create tests for the new validations * lint correction * minor copy change * minor logic change * amend naming error after rebase conflict remove test that is no longer correct after change on another branch to functionality update a test after a copy change	3 years ago