submit-social-housing-lettings-and-sales-data

2333 Commits

233 Branches

250 Tags

74 MiB

Tree: 677714c336

Commit Graph

Author	SHA1	Message	Date
Jack	cff4cc45bc	CLDC-2068 request, validate UPRN and retrieve address (#1370 ) * Add OS_DATA_KEY env var * Add new UPRN and address columns to logs * Bugfix: use dynamic optional fields * Update optional fields * Add UPRN validation * Add UPRN Client * Add UPRN Presenter * UPRN questions and flows * Skip to non addresss questions if UPRN unknown * Address PO review comments and add missing specs * Display LA correctly	2 years ago
SamSeed-Softwire	92029ea2a0	CLDC-859 Sales validation - bedsits cannot have more than 1 bed (#1188 ) * feat: add sales validation to check bedsits have <=1 beds * test: sales validation to check bedsits have <=1 beds * fix: typo in property validation method name * feat: add same bedsit validation to number of bedrooms question * test: fix typo propert -> property in property validations tests * test: add test for validate_property_number_of_bedrooms (sales) * feat: update wording for 'number of bedrooms' validation when bedsit * test: condense sales property validations tests * test: strengthen sales property validations error addition test * refactor: simplify sales property validations into one method * fix: update error message content to match Beth's choices * chore: lint * test: add requests test for invalid sales log params when posting * refactor: use if rather than unless... not in property validation * refactor: write method is_bedsit? on SalesLog * test: check bedsit error not added if proptype or beds is nil * lint: use update! not update * feat: update validation messages to improve readability * fix: provide valid date in request test for invalid proptype/beds * feat: make is_bedsit and validate_bedsit_number_of_beds more readable	2 years ago
Arthur Campbell	d2afa46946	CLDC-1461 add validation ensure postcodes match if discounted ownership purchase (#1200 ) * new property validation file for sales logs with postcode validation regarding discounted ownership, tests also * linting problem	2 years ago

Author

SHA1

Message

Date

Jack

cff4cc45bc

CLDC-2068 request, validate UPRN and retrieve address (#1370 )

* Add OS_DATA_KEY env var

* Add new UPRN and address columns to logs

* Bugfix: use dynamic optional fields

* Update optional fields

* Add UPRN validation

* Add UPRN Client

* Add UPRN Presenter

* UPRN questions and flows

* Skip to non addresss questions if UPRN unknown

* Address PO review comments and add missing specs

* Display LA correctly

2 years ago

SamSeed-Softwire

92029ea2a0

CLDC-859 Sales validation - bedsits cannot have more than 1 bed (#1188 )

* feat: add sales validation to check bedsits have <=1 beds

* test: sales validation to check bedsits have <=1 beds

* fix: typo in property validation method name

* feat: add same bedsit validation to number of bedrooms question

* test: fix typo propert -> property in property validations tests

* test: add test for validate_property_number_of_bedrooms (sales)

* feat: update wording for 'number of bedrooms' validation when bedsit

* test: condense sales property validations tests

* test: strengthen sales property validations error addition test

* refactor: simplify sales property validations into one method

* fix: update error message content to match Beth's choices

* chore: lint

* test: add requests test for invalid sales log params when posting

* refactor: use if rather than unless... not in property validation

* refactor: write method is_bedsit? on SalesLog

* test: check bedsit error not added if proptype or beds is nil

* lint: use update! not update

* feat: update validation messages to improve readability

* fix: provide valid date in request test for invalid proptype/beds

* feat: make is_bedsit and validate_bedsit_number_of_beds more readable

2 years ago

Arthur Campbell

d2afa46946

CLDC-1461 add validation ensure postcodes match if discounted ownership purchase (#1200 )

* new property validation file for sales logs with postcode validation regarding discounted ownership, tests also

* linting problem

2 years ago

3 Commits (677714c336e95069ddf6817146f34a5c00f45f45)