submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	f4bb3e2610	Correctly map equity ranges (#1964 )	1 year ago
natdeanlewissoftwire	759dccda31	CLDC-2455 Add soft validation on percentage owned (#1722 ) * feat: add soft validation page with dynamic copy * feat: add migration * feat: add specs * feat: update test	1 year ago
Arthur Campbell	a08c9d6134	CLDC-2017-monthly-charges-validation (#1448 ) * add a validation against the case where monthly leashold charges are zero, test this, remove unnecessary validation on cash discount as this is covered by validate_numeric_min_max * remove focus: true from describe block * minor changes for testing and linting * correct minor bug found in PO * make minor amendments to failing tests	2 years ago
Arthur Campbell	97bbf1924d	CLDC-2016 mortgage validation (#1445 ) * add method to sales log and use in depends on to increase readability * increase minimum allowed value for mortgage * write tests and add validation error to config for new validation * write validation * adjust validation so it doesn't trigger when mortgage value is derived as 0 * correct linting problem and update tests to account for change in validation	2 years ago
kosiakkatrina	81765d857d	CLDC-2143 Address import validations (#1425 ) * Do not run discounted ownership validation if mortgageused is don't know * Clear previuos postcode if import hits postcodes_not_matching error * Remove child income validation for 22/23 * Remove invalid exchange date * Clear income 1 if it's over allowed non london threshold	2 years ago
natdeanlewissoftwire	5606d06491	CLDC-1917 test flakiness fix (#1437 ) * feat: add validation with feature flag, typo fix and update tests * feat: flip feature toggle * feat: update feature toggle name * feat: fix form handler inequality * refactor: linting * refactor: use between in form handler * feat: remove feature toggle * feat: add dynamic date to lettings log factory * feat: fix log_summary_component_spec.rb tests * feat: update lettings_log.rb and start fixing lettings_log_spec.rb * feat: fix more tests * feat: fix more tests * feat: fix lettings log import service * refactor: linting * feat: fix checkboxes_spec.rb * feat: fix interruption_screen_helper_spec.rb * feat: fix check_answers_helper_spec.rb * feat: fix page_routing_spec.rb * feat: fix lettings_logs_field_import_service_spec.rb * feat: fix lettings_log_spec.rb * feat: fix question_spec.rb * feat: fix lettings_logs_controller_spec.rb * feat: fix check_answers_page_lettings_logs_spec.rb * feat: fix tenancy_validations_spec.rb * feat: fix validations_spec.rb * feat: fix accessible_autocomplete_spec.rb * feat: fix form_navigation_spec.rb * feat: fix soft_validations_spec.rb * feat: fix lettings_log_export_service_spec.rb * feat: fix saving_data_spec.rb * feat: fix page_spec.rb * feat: fix form_controller_spec.rb * refactor: linting * feat: fix subsection_spec.rb * feat: fix lettings_log_spec.rb * feat: fix financial_validations_spec.rb * feat: fix tasklist_page_spec.rb * feat: fix conditional_questions_spec.rb * feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb * feat: fix lettings_log_csv_service_spec.rb * feat: fix tasklist_helper_spec.rb * refactor: linting * refactor: linting * feat: fix lettings_log_spec.rb * refactor: linting * refactor: replace financial year with collection yaer * feat: respond to PR comments pt. 1 * feat: respond to PR comments pt. 2 * feat: unfreeze all timecop freezes	2 years ago
natdeanlewissoftwire	18f40d5c15	CLDC-2025 Add equity range validation to sales logs (#1400 ) * feat: add validation behaviour * feat: add tests * feat: respond to pr comments * refactor: lint * feat: fix tests * feat: fix tests * feat: respond to PR comments	2 years ago
SamSeed-Softwire	d695c2fc64	CLDC-2026 Add minimum staircasing validation for shared ownership sales (#1404 ) * feat: add validation that staircase % is >= threshold * refactor: dry out validation * refactor: correctly order shared ownership types in array * test: add tests for stairbought threshold validation * chore: lint * feat: all staircasing transactions must have stairbought >= 1% * feat: add validation to shared ownership type as well * chore: lint * refactor: simplify no errors tests * refactor: simplify tests by using iteration	2 years ago
David May-Miller	4a31906d45	CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>	2 years ago
Arthur Campbell	648e344af6	CLDC-1786 add validations for staircasing transaction (#1235 ) * change percent to % so that suffix is consistent with other similar questions * fix rebase conflicts * add hard validation that percentage owned after a staircasing transaction cannot be less than the percentage bought in that transaction, with associated tests * add compound validation to ensure that logs of type older person shared ownership may not have a stairbought value of greater than 75% \n associated tests included * remove duplicate method and use existing version * fix rebase conflicts * ensure schema correct and test of page number correct * fix form handler test after rebase * fix tests and ensure schema correct after rebase	2 years ago
kosiakkatrina	7bd76c4d32	CLDC-1575 Add shared ownership validations (#1217 ) * Add income error to ownership type and ecstat fields * Add shared_ownership_deposit_value_check field * Add shared_ownership_deposit_invalid? soft validation * Add shared ownership deposit check pages and questions * Add pages to the subsection and update validation message * tests * Update validation to only trigger if la is given * Run the soft validation when mortgage isn't used or cash discount isn't given * test	2 years ago
Arthur Campbell	1cced31e27	hard validation on value of cash discount (#1221 )	2 years ago
kosiakkatrina	514552934d	Sales financial validations (#1079 ) * Include shared validations in sales log model and run validate_numeric_min_max method * Add non london hard max income validation * Add london income validation * Remove child vlidation because buyer cannot be a child * Add income1_value_check column * Add buyer_1_income_value_check question and page * Update income1_under_soft_min? * Add mortgage and value check column * Add mortgage value check page * Update mortgage_over_soft_max? in soft validateions * Remove unused error message	2 years ago

13 Commits (6b1aeb4c7fd32ba809a7da5d2188670ba150bfb3)