submit-social-housing-lettings-and-sales-data

296 Commits

240 Branches

289 Tags

81 MiB

Tree: 73906100dd

Commit Graph

Author	SHA1	Message	Date
Daniel Baark	3a753364eb	Soft validations with controllers (#77 ) * Working except for selenium checkbox issues * Remove old debug message * Make sure we only run the stimulus init once per page load * Revert that * Rubocop * Use data targets rather than id lookup, so that coupling is explicit * Use fetch * Schema update * No schema changes introduced here * Add a request spec for the new controller * Schema order did change * map over forEach * Update factory fields * Int for booleans :( * Fix spec fields * Lazy create	4 years ago
kosiakkatrina	5ae2f120a8	Db migration (#79 ) * migration wip * change field names to lowercase and fix the tests * Change national and ethnic field types and map to correct enums * change ecstat column types * Change prevten field type * Change homeless field type * Change benefit cap field type * Put db enums in one folder and add a few new field changes" * change field type for housing needs * Change illness field type * display checkbox answers * cbl, chr, cap * Change tenancy and tenancylength field types * Change landlord and rsnvac field types * Change unittype_gn field type * Reasonble preference displaying on check answers * update more field types * Fix typo in comumn name * Change more types * Test fixes * Add adr * fix some tests * run migration * Fix tests Co-authored-by: Matthew Phelan <matthew.phelan@madetech.com>	4 years ago
Daniel Baark	81ff68bb11	CLDC-510: Income range soft validations (#72 ) * Init * Add some tests * Add failing spec * Move soft validations into a module * Update test * Rubocop * Scope are auto created by enums * Rename folder to validations * No instance variable * Commit both lines * Add error indication * Make partial slightly more generic * Fix back link * Write failing test * All specs currently passing. Can this be real? * Check page should have an override question * Fix back button for check answers pages * Don't really need a wrapper method for the validations * We're really validating a page here not a question * Dup variable * Bit of a nasty hack but maybe better than deriving back link? * Set a no cache header instead of reloading * Move a teeny bit of logic out of the controller * Rubocop * Extract method	4 years ago

Author

SHA1

Message

Date

Daniel Baark

3a753364eb

Soft validations with controllers (#77 )

* Working except for selenium checkbox issues

* Remove old debug message

* Make sure we only run the stimulus init once per page load

* Revert that

* Rubocop

* Use data targets rather than id lookup, so that coupling is explicit

* Use fetch

* Schema update

* No schema changes introduced here

* Add a request spec for the new controller

* Schema order did change

* map over forEach

* Update factory fields

* Int for booleans :(

* Fix spec fields

* Lazy create

4 years ago

kosiakkatrina

5ae2f120a8

Db migration (#79 )

* migration wip

* change field names to lowercase and fix the tests

* Change national and ethnic field types and map to correct enums

* change ecstat column types

* Change prevten field type

* Change homeless field type

* Change benefit cap field type

* Put db enums in one folder and add a few new field changes"

* change field type for housing needs

* Change illness field type

* display checkbox answers

* cbl, chr, cap

* Change tenancy and tenancylength field types

* Change landlord and rsnvac field types

* Change unittype_gn field type

* Reasonble preference displaying on check answers

* update more field types

* Fix typo in comumn name

* Change more types

* Test fixes

* Add adr

* fix some tests

* run migration

* Fix tests

Co-authored-by: Matthew Phelan <matthew.phelan@madetech.com>

4 years ago

Daniel Baark

81ff68bb11

CLDC-510: Income range soft validations (#72 )

* Init

* Add some tests

* Add failing spec

* Move soft validations into a module

* Update test

* Rubocop

* Scope are auto created by enums

* Rename folder to validations

* No instance variable

* Commit both lines

* Add error indication

* Make partial slightly more generic

* Fix back link

* Write failing test

* All specs currently passing. Can this be real?

* Check page should have an override question

* Fix back button for check answers pages

* Don't really need a wrapper method for the validations

* We're really validating a page here not a question

* Dup variable

* Bit of a nasty hack but maybe better than deriving back link?

* Set a no cache header instead of reloading

* Move a teeny bit of logic out of the controller

* Rubocop

* Extract method

4 years ago

3 Commits (73906100dd93abc3d503a216358c0291b69800c2)