submit-social-housing-lettings-and-sales-data

2131 Commits

223 Branches

266 Tags

68 MiB

Tree: 74d1797ee5

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	f3e7d2c62b	CLDC-2073 app crashing if needs type is changed (#1368 ) * add some methods on lettings log and use them and already existing methods to make depends on human readbale for pages in property information subsection * reformat answer options for neatness * ensure that property information subsection is conditionally not shown under correct conditions * amend method to find the path for the next question to answer so that if no questions in the next section are currently routed to, it goes to the section after that * make amendments for failing test and linting * remove unnecessary method * remove unnecessary conditions from depends on, the displayed in tasklist method override is sufficient * test the change to the method creating a link to the next subsection * minor refactor to displayed_is_tasklist condition and changes in testing * implement the fix on 22/23 form also * write a test covering the fix * removal not_renewal? method and tweak depends on for all pages using that method * linty fluff begone * correct some errors in tests after changes to factories * minor testing amendments after rebase	2 years ago
natdeanlewissoftwire	c862423adf	CLDC-1864 single log numbering (#1381 ) * feat: add initial question number behaviour * feat: add initial CYA behaviour * feat: number sales setup section * refactor: lint * feat: property information numbering * feat: household characteristics section and typo fix * feat: household characteristics numbering * feat: household situation numbering * feat: other household info numbering * feat: income, benefits and outgoings numbering * feat: shared ownership scheme numbering * feat: shared, discount and outright numbering * feat: fix income duplication bug, add numbers to other questions * feat: typo fix * feat: add lettings setup numbering * feat: add property info numbering * feat: add household char numbering * feat: add household needs numbering * feat: add household situ numbering * feat: add income numbering * feat: update tests * refactor: cleanup and disable on 2022 and before logs * feat: add test for q numbers in 23/24 year only * refactor: highlight multiplication in brackets * feat: show rent and charge questions individually on cya * feat: number new previous tenure q * feat: delete old prevten file * feat: update card numbers after merge * feat: add q60 ands 61 sales * refactor: delete empty files --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	2 years ago
kosiakkatrina	7f76fffcce	CLDC-1911 Add form definition for 23/24 lettings (#1254 ) * Spike for generating form * Add remaining field mappings * Add question attributes conditionally * Display page attributes conditionally * update subsection formatting * Update section formatting * fix generator * Fix generator * Update the form handler and form to create post 2021 forms programatically * Initially generated and linted form * Cover lettings sections and subsections wiht tests * Cover age pages and questions with tests * Add reusable age questions and adjust the tests * Add a generic person age page using generic questions and adjust specs * Multiline arrays in subsections * Use generic person age page in household characteristics and remove unused pages/questions * Combine and reduce tests * Backfill duplicate rsnvac question * Backfill repeating question * Backfill repeating voiddate * Backfill repeating tenancy question * Backfill ethnic questions * Backfill reason question * Backfill prevten question * Backfill referral questions * Backfill chcharges questions * Backfill brent questions * Backfill scharge * Backfill pscharge * Backfill supcharg * Backfill tcharge * Backfill retirement value check question * Make person known questions generic * Make person gender identity questions generic * Make relationship questions generic * Make working situation questions generic * make retirement check generic * make pregnant household check generic * Make pregnancy value checks generic, again * Undo for and form handler changes * Remove generate form task and service * Remove empty headers, descriptions and initializers from pages * Fix tests * lint	2 years ago

Author

SHA1

Message

Date

Arthur Campbell

f3e7d2c62b

CLDC-2073 app crashing if needs type is changed (#1368 )

* add some methods on lettings log and use them and already existing methods to make depends on human readbale for pages in property information subsection

* reformat answer options for neatness

* ensure that property information subsection is conditionally not shown under correct conditions

* amend method to find the path for the next question to answer so that if no questions in the next section are currently routed to, it goes to the section after that

* make amendments for failing test and linting

* remove unnecessary method

* remove unnecessary conditions from depends on, the displayed in tasklist method override is sufficient

* test the change to the method creating a link to the next subsection

* minor refactor to displayed_is_tasklist condition and changes in testing

* implement the fix on 22/23 form also

* write a test covering the fix

* removal not_renewal? method and tweak depends on for all pages using that method

* linty fluff begone

* correct some errors in tests after changes to factories

* minor testing amendments after rebase

2 years ago

natdeanlewissoftwire

c862423adf

CLDC-1864 single log numbering (#1381 )

* feat: add initial question number behaviour

* feat: add initial CYA behaviour

* feat: number sales setup section

* refactor: lint

* feat: property information numbering

* feat: household characteristics section and typo fix

* feat: household characteristics numbering

* feat: household situation numbering

* feat: other household info numbering

* feat: income, benefits and outgoings numbering

* feat: shared ownership scheme numbering

* feat: shared, discount and outright numbering

* feat: fix income duplication bug, add numbers to other questions

* feat: typo fix

* feat: add lettings setup numbering

* feat: add property info numbering

* feat: add household char numbering

* feat: add household needs numbering

* feat: add household situ numbering

* feat: add income numbering

* feat: update tests

* refactor: cleanup and disable on 2022 and before logs

* feat: add test for q numbers in 23/24 year only

* refactor: highlight multiplication in brackets

* feat: show rent and charge questions individually on cya

* feat: number new previous tenure q

* feat: delete old prevten file

* feat: update card numbers after merge

* feat: add q60 ands 61 sales

* refactor: delete empty files

---------

Co-authored-by: Kat <katrina@kosiak.co.uk>

2 years ago

kosiakkatrina

7f76fffcce

CLDC-1911 Add form definition for 23/24 lettings (#1254 )

* Spike for generating form

* Add remaining field mappings

* Add question attributes conditionally

* Display page attributes conditionally

* update subsection formatting

* Update section formatting

* fix generator

* Fix generator

* Update the form handler and form to create post 2021 forms programatically

* Initially generated and linted form

* Cover lettings sections and subsections wiht tests

* Cover age pages and questions with tests

* Add reusable age questions and adjust the tests

* Add a generic person age page using generic questions and adjust specs

* Multiline arrays in subsections

* Use generic person age page in household characteristics and remove unused pages/questions

* Combine and reduce tests

* Backfill duplicate rsnvac question

* Backfill repeating question

* Backfill repeating voiddate

* Backfill repeating tenancy question

* Backfill ethnic questions

* Backfill reason question

* Backfill prevten question

* Backfill referral questions

* Backfill chcharges questions

* Backfill brent questions

* Backfill scharge

* Backfill pscharge

* Backfill supcharg

* Backfill tcharge

* Backfill retirement value check question

* Make person known questions generic

* Make person gender identity questions generic

* Make relationship questions generic

* Make working situation questions generic

* make retirement check generic

* make pregnant household check generic

* Make pregnancy value checks generic, again

* Undo for and form handler changes

* Remove generate form task and service

* Remove empty headers, descriptions and initializers from pages

* Fix tests

* lint

2 years ago

3 Commits (74d1797ee5cb467e41ce94f6c12f29c3f2ec7679)