submit-social-housing-lettings-and-sales-data

1713 Commits

233 Branches

272 Tags

75 MiB

Tree: 79d16d82c4

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	d89e03cc62	Cldc 1675 rent validations (#959 ) * feat: add 2022 rent range data, update rake task for population of this * feat: change file format so ranges_rent_id is recognised * feat: add updated error messages and casing * tests: make tests pass * feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations * feat: fix general needs validation behaviour * feat: add local authorities enum to location.rb * feat: ensure case when beds > 4 is accounted for * feat: add error messages on property postcode page as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: add error messages on scheme_id and location_id as well as la page * feat: null coalescing and validations on changing las to one that invalidates rent in supported housing * feat: nil protection * refactor: linting * refactor: combining duplicated logic * tests: add hard validation tests split by needstype * feat: update validations when beds > 4 * feat: update validations when beds > 4 * refactor: simplification, use preivous la method * refactor: response to PR comments, fixing beds.negative validation * feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location	2 years ago
natdeanlewissoftwire	9a51f7261c	Cldc 1390 la lookup fallback (#861 ) * feat: add la manual edit page * feat: make autocomplete accesible and la readable * feat: add correct skip and linking behaviour, also rename fallback page * feat: add page not found and tidy la list * feat: add redirection behaviour * feat: add coping with nil add_another_location query string * test: add postcodes mocks to return local authorities * feat: validate local authority to not be nil or "Select an option" * feat: persist add_another_location even on validation failure * feat: remove url query parsing, put validation before values added to db * refactor: spacing * tests: add new tests for edit-local-authority * tests: remove redundant bangs	2 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

d89e03cc62

Cldc 1675 rent validations (#959 )

* feat: add 2022 rent range data, update rake task for population of this

* feat: change file format so ranges_rent_id is recognised

* feat: add updated error messages and casing

* tests: make tests pass

* feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations

* feat: fix general needs validation behaviour

* feat: add local authorities enum to location.rb

* feat: ensure case when beds > 4 is accounted for

* feat: add error messages on property postcode page as well as la page

* feat: add error messages on scheme_id and location_id as well as la page

* feat: add error messages on scheme_id and location_id as well as la page

* feat: null coalescing and validations on changing las to one that invalidates rent in supported housing

* feat: nil protection

* refactor: linting

* refactor: combining duplicated logic

* tests: add hard validation tests split by needstype

* feat: update validations when beds > 4

* feat: update validations when beds > 4

* refactor: simplification, use preivous la method

* refactor: response to PR comments, fixing beds.negative validation

* feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location

2 years ago

natdeanlewissoftwire

9a51f7261c

Cldc 1390 la lookup fallback (#861 )

* feat: add la manual edit page

* feat: make autocomplete accesible and la readable

* feat: add correct skip and linking behaviour, also rename fallback page

* feat: add page not found and tidy la list

* feat: add redirection behaviour

* feat: add coping with nil add_another_location query string

* test: add postcodes mocks to return local authorities

* feat: validate local authority to not be nil or "Select an option"

* feat: persist add_another_location even on validation failure

* feat: remove url query parsing, put validation before values added to db

* refactor: spacing

* tests: add new tests for edit-local-authority

* tests: remove redundant bangs

2 years ago

2 Commits (79d16d82c4e7c39ce7562d6232c0053f072f45de)