kosiakkatrina
c19291c948
Add mini profiler ( #2513 )
4 months ago
kosiakkatrina
8ce22d37c0
CLDC-3289 Avoid freezing time (part 3) ( #2445 )
...
* Refactor tests #1
* Update tasklist helper tests
* Update task list helper
* Fix test
* Rabase fixes
* Update model/validations tests
* Update som sales log specs
* Remove missing addresses csv tasks
* Update some tests for 2023 collection close
* More fixes
* Revert sales shared examples change
* Fix test
* Update test nemes, remove time stub
4 months ago
Arthur Campbell
3adfb29143
CLDC-3290 Update some test setup ( #2466 )
...
* test prof in test context
* time reduced from ~1.4 to 0.27
* time reduced from ~1.1 to 0.7
* time reduced from ~0.13 to 0.07
* add testprof env variables to spec helper
* reorder gems for linting copmlaint
* Remove test-prof gem
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
4 months ago
Manny Dinssa
9e35b26dcf
Just use visible locations ( #2506 )
4 months ago
kosiakkatrina
fe82a8e8b4
Split tests into more jobs ( #2505 )
...
* Split tests into more jobs
* Make request tests run in parallel
4 months ago
Arthur Campbell
f423ec1cd5
CLDC-3505 further fixes to tests for year hard end ( #2493 )
...
* further fixes
* Fix date / crossover issues
* Try changing form end dates
* Revert "Try changing form end dates"
This reverts commit e027e29cf0
.
* Make use of :ignore-validation-errors trait
* Try with end dates in past
* Revert "Try with end dates in past"
This reverts commit 6b87938d70
.
---------
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
4 months ago
kosiakkatrina
42f89680e5
CLDC-3495 Reduce persisted models in tests ( #2507 )
...
* Remove legacy user from user factory
* Build instead of creating in some model tests
* Do not create a new DPO for orgs created within user factories
* Add original setup doc
* Update documentation with updated factories
* Fix up DSA creations
4 months ago
kosiakkatrina
ab4915c2aa
CLDC-2480 Allow deleting organisations ( #2459 )
...
* Add delete confirmation page
* Allow deleting organisation
* Add delete button
* Do not display deleted organisations as an option
* Update policy
* Display informative text and delete org resources
* lint
* Update organisation labels to show when deleted
* Refactor organisation label
* Update more labels
* Remove deleted orgs from schemes and autorize delete_confirmation
* Fix tests
4 months ago
kosiakkatrina
8dcd80e4f8
Strip scheme ID ( #2487 )
4 months ago
Rachael Booth
356d652db1
CLDC-3532: Make BU guidance back link depend on referrer ( #2482 )
...
* CLDC-3532: Make BU guidance back link depend on referrer
* Add tests for back_path
* Add guidance to homepage
* CLDC-3526: Update back_path
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
4 months ago
Rachael Booth
032cecf3f8
CLDC-3482: Task to recalculate status for 2023 logs missing la ( #2495 )
4 months ago
Rachael Booth
8d9f30610c
CLDC-3543: Don't validate logs when discarding them in handle unpended logs task ( #2504 )
4 months ago
Rachael Booth
b553ec031a
CLDC-3543: Fix args reference in allow live run of handle unpended logs task ( #2503 )
4 months ago
Rachael Booth
ababb3894c
CLDC-3543: Allow live run of handle unpended logs task ( #2496 )
4 months ago
dependabot[bot]
f6a0cc67e5
Bump rails_admin from 3.1.2 to 3.1.3 ( #2500 )
...
Bumps [rails_admin](https://github.com/sferik/rails_admin ) from 3.1.2 to 3.1.3.
- [Changelog](https://github.com/railsadminteam/rails_admin/blob/v3.1.3/CHANGELOG.md )
- [Commits](https://github.com/sferik/rails_admin/compare/v3.1.2...v3.1.3 )
---
updated-dependencies:
- dependency-name: rails_admin
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 months ago
kosiakkatrina
905f869460
CLDC-2939 Link to organisations from user pages ( #2489 )
...
* Link to organisations from user pages
* Fix test
4 months ago
Rachael Booth
0994794b25
CLDC-3543: Task to handle unpended logs - dry runs only ( #2494 )
...
* CLDC-3543: Task to handle unpended logs
* Enforce dry run only
4 months ago
Arthur Campbell
0ecd82bf8f
more tests fixed ( #2491 )
4 months ago
kosiakkatrina
5947a2027a
CLDC-3496 Move period creation to log ( #2490 )
...
* Move period creation to log
* Allow adding rent periods to organisations
* Update more tests
4 months ago
Rachael Booth
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
4 months ago
kosiakkatrina
30b86f5a86
CLDC-3289 Avoid freezing time in tests (part 2) ( #2432 )
...
* Refactor tests #1
* Refactor model form tests
* Update tasklist helper tests
* Update task list helper
* Fix test
* Udate model/forms tests
* Update model/validations tests
* Update a few more model specs
* Update bulk request tests
* Update policy tests
* lint
* Refactor
* More fixes
* Rabase fixes
* Refactor
* lint
4 months ago
Arthur Campbell
8f65fd35fd
Cldc 3505 fix tests that will break on rollover ( #2485 )
...
* update factory completed traits using an after build hook so that trait does what it says regardless of start or sale date of log
* use completed trait rather than completed2024 trait from factories
skip validation on saving logs from previous years so that logs created too far in the past do not trigger validations
* remove sale and start dates from logs in tests where that should not be important
build rather than create to reduce db interactions
in order that the setup is complete, build the necessary user and organisation with ids
* fix a wide range of tests affected by the changes in log factories completed traits
4 months ago
kosiakkatrina
9dc4f0bbb6
CLDC-3523 Only count visible logs on CSV downloads page ( #2477 )
...
* Only count visible logs
* Refactor
* Update csv count for sales
4 months ago
kosiakkatrina
4c0c0d15eb
CLDC-3508 Search both datasets for UPRN ( #2479 )
...
* Search both datasets for UPRN
* Update presenter
* Update request stubs
4 months ago
Rachael Booth
0718c10847
CLDC-3522: Correct logic around BU address search and address not found errors ( #2476 )
...
* CLDC-3522: Correct logic around BU address search and address not found errors
* Fix lint errors
4 months ago
kosiakkatrina
4b218e759f
Update upcoming deadlines dates ( #2462 )
4 months ago
Arthur Campbell
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
4 months ago
kosiakkatrina
07750ef26c
CLDC-3289 Avoid freezing time in tests (part 1) ( #2421 )
...
* Refactor tests #1
* Refactor helper tests
* Refactor model form tests
* Remove Timecop.returns
* Update tasklist helper tests
* Update task list helper
* Fix test
* Fix flaky search test
* Refactor
4 months ago
kosiakkatrina
201fe20519
Bump braces from 3.0.2 to 3.0.3 and socket.io from 4.5.2 to 4.7.5 ( #2474 )
...
* Bump braces from 3.0.2 to 3.0.3
Bumps [braces](https://github.com/micromatch/braces ) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md )
- [Commits](https://github.com/micromatch/braces/compare/3.0.2...3.0.3 )
---
updated-dependencies:
- dependency-name: braces
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
* Bump socket.io from 4.5.2 to 4.7.5
Bumps [socket.io](https://github.com/socketio/socket.io ) from 4.5.2 to 4.7.5.
- [Release notes](https://github.com/socketio/socket.io/releases )
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md )
- [Commits](https://github.com/socketio/socket.io/compare/4.5.2...4.7.5 )
---
updated-dependencies:
- dependency-name: socket.io
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 months ago
Arthur Campbell
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
4 months ago
Arthur Campbell
d95e08cca2
Cldc 3492 oustide rent range soft validation not clearing for bedsit ( #2473 )
...
* mark the beds question as derived when the log is a bedsit to stop it from being cleared
* delete spec file not testing anything worthwhile
4 months ago
kosiakkatrina
a85fed42b1
CLDC-3504 Update period question options and error message ( #2463 )
...
* Update displayed_answer_options for period
* Update invalid rent period error message
4 months ago
Arthur Campbell
9e99f62e1d
ensure dates for beginning and end of collection year are correct in the crossover period ( #2469 )
5 months ago
Rachael Booth
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
5 months ago
kosiakkatrina
8edca7e34b
Update routing for major repairs question ( #2464 )
5 months ago
kosiakkatrina
75e8349c31
Update privacy notice links ( #2460 )
5 months ago
kosiakkatrina
310d31a61c
CLDC-3483 Update logger statements ( #2468 )
...
* Update logger statements
* Update test
5 months ago
kosiakkatrina
d488dd533f
Change busybox version ( #2467 )
5 months ago
kosiakkatrina
9f623e0cb2
CLDC-3274 Display organisation merges for a longer period ( #2456 )
...
* Display organisation merges for a longer period
* Refactor
5 months ago
kosiakkatrina
dbca9323ae
Do not display deleted schemes in homepage count ( #2458 )
5 months ago
Rachael Booth
4a5a912816
CLDC-3483: Prevent/fix missing letting allocation values ( #2453 )
...
* CLDC-3483: Enforce that all lettings allocation method fields are present for bulk uploads
* CLDC-3483: Add task to fix existing nil letting allocation values
* Better capitalisation
* Keep previous punctuation
* Use find_each for task
5 months ago
kosiakkatrina
c6d5ade30b
Fix logger ( #2457 )
5 months ago
Arthur Campbell
00c8567538
add paper trail to organisation rent periods in case of any further bugs ( #2461 )
5 months ago
kosiakkatrina
7d871edf74
CLDC-3482 Correct routing to property LA ( #2449 )
...
* Correct routing to property LA
* Add rake task to update LAs
5 months ago
kosiakkatrina
9ed93efc58
CLDC-3474 Correctly construct dates for template validation ( #2447 )
...
* Correctly construct dates
* Update tests
5 months ago
Rachael Booth
10732f92f2
CLDC-3487: Ensure locations and previous_la_known are cleared when necessary ( #2452 )
...
* CLDC-3487: Clear previous_la_known when necessary for renewal logs
* CLDC-3487: Clear location when clearing scheme due to org change
* CLDC-3487: Use nil instead of 0
* Specify orgs on sh logs when needed for tests
* Fix flaky tests
5 months ago
Rachael Booth
b6f3c2d8ad
CLDC-3463: Use find_each in update task to avoid memory problems ( #2455 )
5 months ago
Arthur Campbell
3d413c5781
CLDC-3503 rent periods bug ( #2454 )
...
* ensure in the update method that it is not possible to delete rent periods that are in use by that organisation
* lint
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
5 months ago
Rachael Booth
ada4c556e3
CLDC-3477: Account for ecstat=9 inferernce when calculating applicable_income_range ( #2450 )
5 months ago
Rachael Booth
92dc829e8e
CLDC-3463: Fix bug with vacdays calculation ( #2444 )
...
* CLDC-3463: Fix bug with vacdays calculation
* CLDC-3463: Fix lettings csv export tests
* Lint
* Use build_stubbed where necessary for lettings logs in tests
* Update all logs in rake task but without validation
* Try validations in rake tasks and log when needing to skip them
5 months ago