submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	02c41333f6	Cldc 1669 add location redesign (#1034 ) * feat: wip postcode page * feat: wip add new flow * feat: add check answers page, continue updating flow * feat: add back behaviour * feat: more flow work * feat: further flow work and flash notice, name tidying * feat: add check_answers referrer linking * feat: add controller and details linking and lint * refactor: erblinting * feat: add local_authority page (currenlty separate from edit_local_authority to avoid conflict with add location to newly created scheme path, to be fixed later). also copy and routing updates * feat: add validations to controller (could later be added to model) * fix: correct date order * feat: validate on model (except startdate) * feat: copy update * refactor: railsification * feat: add date model validation * feat: add updated availability text in check_answers * feat: more updated dynamic text and linking * refactor: erblinting * refactor: cleanup of redundant code * refactor: remove redundant create * feat: use rails route * test: wip tests * test: wip tests * feat: add new back behaviour for new scheme path and tests wip * feat: add more back behaviour for new scheme path and fix local auth validation * feat: further linking behaviour with routes and referrers, don't add new location automatically to new schemes * feat: if location with no details added, route to normal path rather than check answers * test: update model and helper location tests * test: more test updates * test: more test updates and remove redundant files * test: remove redundant tests, add postcode test * test: add new #new tests * test: add test for all new controller methods * test: add more startdate tests * refactor: erblinting * test: fix failing tests * test: update scheme test * feat: respond to PR comments * feat: make postcode clear only if changed * feat: add _update methods * refactor: simplify validation and location_edit_path method * refactor: add helper method for action text * refactor: remove redundant logic * refactor: simplify routing * refactor: reintroduce location_params * refactor: use presence validation for postcode * refactor: use presence validation for la * feat: validate confirmed * tests: make tests pass with new startdate validation * WIP * refactor: simplify display attributes helpers and update tests * refactor: linting * feat: design change to save behaviour * test: fix failing tests * feat: location code copy tweak * refactor: remove redundant function * refactor: remove add_another_location and new location page * feat: simplify startdate validations to move to model, use scheme available_from date for in range validation * test: fix failing tests * refactor: linting * feat: remove name validation as a result of PO review * test: update tests * refactor: remove redundant context Co-authored-by: James Rose <james@jbpr.net>	2 years ago
SamSeed-Softwire	a62846c212	CLDC-1666 Update locations table (#987 ) * feat: remove redundant cols from locations table * feat: add status col to locations table * test: start adding status tag tests * test: pick the simplest format for the tag helper tests * feat: make the locations table (plus related content above & below) 2/3 width * feat: add incomplete to location status method * test: all status tag helpers * test: update test text to match what's being tested * test: update locations list test in locations_controller_spec.rb * test: update locations list test in schemes feature tests * test: that status=incomplete when mandatory info is missing * feat: simplify logic for incomplete status Co-authored-by: James Rose <james@jbpr.net> * feat: hide new locations table layout behind feature flag * feat: use route helpers to get scheme_location path * feat: simplify "scheme_id: @scheme.id" to "@scheme" * feat: reference location, not @location, in scheme_location_path * feat: reorder postcode and code in locations table * feat: change ' ' to "" in location_spec * feat: update wording and ordering for 'view location details' page * test: re-add tests for locations page when new layout not enabled * test: check for mobility_type and location_admin_district in locations_controller as support user * test: update locations helper test to match new field naming and ordering * feat: always scale locations list by 2/3, not just when new layout used * feat: scale the scheme details page by 2/3 to match the locations list page * feat: only make scheme details and locations pages 2/3 scale if feature toggle on * test: mock new locations layout feature toggle in tests * feat: use the existing location_toggle_enabled instead of new_locations_table_layout_enabled * refactor: don't use html inside ruby in locations index page * refactor: use Rails routes in all places in locations index page * style: lint * feat: move logic from views/schemes/show into schemes_helper * refactor: make consistent the removal of fields from SchemeHelper base_attributes * test: improvements to tests * test: make 'returns correct display attributes' tests sensible * test: check scheme toggle off => no scheme status shown * style: correct indentation in spec/helpers/schemes_helper_spec.rb * test: that when owning = managing, "Organisation providing support" hidden * style: lint code * test: don't set scheme id explicitly in schemes_helper_spec * style: reorder tag helper spec to match tag helper * refactor: ensure display_scheme_attributes always takes user type * test: make location incomplete status depend on location.confirmed * test: add missing location validations for nil postcode & mobility type Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	a91c8da62e	Update available_from methods (#1026 ) * Update available_from methods * Move collection start date logic to form handler	2 years ago
natdeanlewissoftwire	879cdea47f	Cldc 1672 scheme reactivation (#1023 ) * feat: add scheme reactivation behaviour * test: add tests * refactor: linting * fix: find deactivation periods by scheme/location ids rather than just the first * feat: add activating_soon status to location (not to schemes as they have no startdate field) * feat: fix logic and add tests fo activating soon * fix: check for startdate presence	2 years ago
kosiakkatrina	11bb9c887c	Cldc 1670 reactivate locations (#1007 ) * route deactivated scheme to reactivation page * Render correct reactivate question content * refactor into a helper * display successful reactivation banner for default date * Save reactivation date * Add reactivation errors * lint and fix url in tests * make toggle translations generic * Add reactivation status * Reuse date validation messages * Show deactivate this location when location is reactivating soon * Display correct confirmation banner * Add validation for reactivation date before deactivation date * Improve availability label * Use current collection start date if created at is later than that * Update paths * Fix controller and don't display the previous day if location availability start afterwards * refactor availability label * Filter out active periods * lint * Refactor active_period method into the model * Allow deactivations and reactivations from available from date instead of start of the collection date * Prevent deactivations during deactivated periods * lint * typo * Remove active periods that last 1 day (because they get deactivated on the same day) * Move the active_periods into helper * extract remove_overlapping_and_empty_periods into a separate method * Remove nested deactivation periods * Make deactivate/reactvate location form use location_deactivation_period model * refactor toggle date methods * extract shared condition * update validations * refactor validations * Update schemes deactivation form to use dectivation model * Refactor * lint * remove redundant location_id and update scheme controller * update active_periods	2 years ago
kosiakkatrina	4813c5795d	Unfreeze time (#1006 ) * Unfreeze time * lint	2 years ago
kosiakkatrina	96c792b472	Cldc 1668 multiple location deactivations (#996 ) * Add location_deactivations table and remove deactivation_date from locations * Add location location_deactivations relationship * Update logs status determination for location * Update affected logs with deactivated location. * lint * Update scheme * Extract location_deactivation factory * Update location availability * lint * Rename deactivations table * fix schema * rebase fixes * fixes * refactor	2 years ago
natdeanlewissoftwire	87793f24bd	Cldc 1671 deactivate scheme (#980 ) * feat: wip update scheme summary page * feat: wip deactivate scheme schemes page * feat: wip toggle active page * feat: wip set deactivation_date to a datetime (to be more specific times later_ * Change conditional question controller to accommodate all models * feat: add specific datetimes for deactivation * feat: correct date and add notice * feat: wip error behaviour * feat: wip errors * feat: wip errors refactoring * feat: wip errors more refactoring * refactor: linting * feat: add second error in correct position and wip date range error * feat: remove unneccessary db field * feat: change type values to strings * refactor: tidy up controller logic * refactor: use same structure as locations deactivation * feat: add general partially missing date input error * feat: add tests ("updates existing scheme with valid deactivation date and renders scheme page" still wip) and add new partially nil date behaviour to locations controller * feat: fix tests, add status tag behaviour and remove unnecessary nils * refactor: linting * refactor: erblinting * refactor: remove redundant line * refactor: respond to PR comments 1 * refactor: respond to PR comments 2 * refactor: respond to PR comments 3 * refactor: respond to PR comments 3 (locations side) * fix: remove @locations in location model * fix: remove @locations in location model * fix: update status names * feat: wip validation update * feat: add validation to model layer * feat: further separate scheme deactivation behaviour * test: update tests to new flow * feat: respond to pr comments and add dynamic success text * feat: duplicate behaviour schemes -> locations (+ tests) * refactor: linting * refactor: typo and remove unnecessary line for this PR * refactor: feature toggle simplification * Refactor locations and schemes controller actions - Rename confirmation partials to `deactivate_confirm.html.erb` so that they match the actions in which they belong to - Make all deactivation date comparision UTC time * feat: update deactivation_date validation and add tests * refactor: linting Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	1630c38619	Cldc 1668 deactivate location (#981 ) * add deactivation_date to locations * Change conditional question controller to accommodate all models * UI spike * Update toggle-active views and render them correctly * Display 2 errors * Update errors * Extract text to translation file * Add collection start date * Add out of range validation * Update affected logs label * lint * Add status method * update the displayed status tags * Keep deactivation_date_type selected if an error occurs * refactor deactivation_date_type to use default and other as options instead of 1 and 2 * refactor * refactor * update lettings logs * Add reactivate ocation button and path * Fix controller and update deactivate confirm page * Don't actually update the logs data when deactivating a location * lint and typos * update a path * update current_collection_start_date * Remove unused scope	2 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	2 years ago
baarkerlounger	89120548bb	Only consider active locations for routing (#814 ) * Only consider active locations for routing * Spec nil case	2 years ago
Ted-U	6d0d40fb22	CLDC-1381-Postcode-display-formatting (#781 )	2 years ago
baarkerlounger	7c998e0942	Version schemes and locations (#799 )	2 years ago
baarkerlounger	1343e2c808	Reference translation file in spec	2 years ago
baarkerlounger	610dad81a8	CLDC-1382: Add location and search to scheme locations (#756 ) * Add search * Add "Add location" button * Add confirmed flag to schemes * Show location tab is location is being added to an existing scheme * Switch button text when scheme exists already * Remove change links for confirmed schemes * Fix spec after rebase * added title showing search results and tests for it Co-authored-by: JG <moarpheus@gmail.com>	2 years ago
J G	9d384d6b50	CLDC-1348 basic validation for scheme and location + front update (#730 ) * validation error messages for scheme * WIP for validations * fixed redirects for a correct page * expecting link to a new question * added support_services_provider * WIP for support_services_provider * WIP for support_services_provider - works concenptually * WIP passing feature tests * WIP passing feature tests * WIP validations * passing tests and working functionality * location validations * fixed after rebasing * fixed edit name * fixed after rebasing * tests for missing params * tests for validations * tests for validations locaion * tests for validation of all params for scheme * tests for location validations * What is this type of scheme? - Order options alphabetically: * Care Standards Act 2000? - Order options as follows, add missing hint text for third option * further styling * last UI changes * lmoved back button logic to the view * select options in the view * missing validation for manaing org * fixed check answers page * wip * small change * fixed * fixed check answers page ui * fixed updating * fixed tests * fixed layout * final touches * rebase * rubocop * correct condition * old test	2 years ago
Stéphane Meny	97024c321d	CLDC-1228: Handles household charges (#745 )	2 years ago
J G	5eac424384	CLDC-1337-permitted-user-can-add-location-when-creating-scheme (#704 ) * added last step * not finding postcode field * testing being direct to add locations page after submitting support questions * added route to locations controller * location controller spec * location controller * added template for new * next step in feature * added postcode * added name to locations * removed total units from schemes * moved total units to locations * changed type of unit type in db * using type of units * add locations page is finished * purged total units and added test for location create * creating location * testing creating location as data provider * fixed factory * refacotred update/create and added test creating location as a coord user * testing returning back to create page if create another location is selected * testing returning back to create page if create another location is selected - part 2 * thanks rubocop * thanks rubocop * testing back from new location * returned tests back * testing clickable locations link * testing clickable locations link under correct context * correctly looking table * table with caption * wip * fixed failing exisiting tests * fixed failing exisiting tests - part 2 * validating postcode case logs style * validating postcode specs * validating postcode specs debugger removed * navigation when editing location * spike creating new location after addition * small refactoring * added test to add another location from locations page * added test to amend a location * added test to amend a location - part 2 * testing location cell * added wheelchair adaptions to the unit tyupe * rebased * testing postcode missing * testing creating schem for a different org for coordinator * testing new scheme for a different org for coordinator * upcasing all postcodes before creation * testing edge cases around postcodes and yes or no for another location * create locations with support user * details locations specs * update locations specs * rubocop * checking raising error * fixed failed test * switched yes and no for wheelchairs * routes refactoring * fixed routing - WIP * further chanegs * feature tests passing * correct page when errros * redundant page * moving viewing locations away from schemes controller * new is fixed * create fixed * fixed locations specs * fixed tab nav specs * completed location specs * lint	2 years ago

18 Commits (7e950564ae59cf718f7bd729348ac4441f141b14)