kosiakkatrina
0799ff7a36
CLDC-3658 Extract household needs copy ( #2718 )
...
* Extract household needs subsection copy
* Extract housing needs soft validations copy
* Add new lines at the end of some files
3 months ago
kosiakkatrina
745e1e7e4b
CLDC-2248 Improve soft validations ( #1584 )
...
* Update interruption screen page
* Update routing and add flash
* Only display routed to affected questions
* Add affected_question_ids to pregnancy check
* lint
* Add skip link and lint
* Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids
* typo
* Fix button wording
* Update action href links
* Change how we route back to interruption screen
* Update affected_question_ids for lettings
* Update sales soft validations
* Update title texts
* Update styling
* Update is_referrer_interruption_screen? check and naming
* Add interuption screen helper specs
* Add request test for fixing soft validation
* Add tests for geting soft validation page
* Extract interruption screen banner
* Update action_href to be reusable
* Extract questions out of check answers summary list
* Reuse check_answers_summary_list for interruption screen
* refactor string parse
* Rename attribute
* fix test
* Add tests for sales paths
* typo
* Update validation message: void date, major repairs date
* Update validation message: rent_value_check, 2022
* Update validation message: buyer live in
* Update validation message: staircase
* Update validation message: purchase price
* Update validation message: income
* Update validation message: savings
* Update validation message: extra borrowing
* Update validation message: extra borrowing
* Update validation message: wheelchair
* Update validation message: monthly charge
* Update validation message: mortgage
* Update validation message: old persons shared ownership
* Update validation message: discount
* Update validation: min retirement
* Wording in tests and time test
* Update missing question
* Refactor is referrer methods
* Update validation message: net income
* Update validation message: deposit and savings
* Update validation message: mortgage, discount and deposit
* Fix test validation messages
* Fix the retirement check showing on the card 8, fix tests
* test
* return the user back to the check_your_answers after fixing a validation from check_your_anwers
* pr comments
2 years ago
kosiakkatrina
c339ffda1f
Cleanup the form ( #1166 )
...
* Remove empty descriptions from pages
* remove empty headers from pages
* Remove redundant subsection assignment from pages
* Remove redundant page assignement from questions
* Remove redundant section assignment from subsections
* Remove redundant form assignments from sections
* Remove empty hint texts from questions
* lint
2 years ago
kosiakkatrina
7d02752d82
Cldc 1440 household situation section ( #1132 )
...
* feat: add question page and subsection (#1120 )
* feat: add question page and subsection
* refactor: linting
* feat: remove schema rows from other branch
* feat: slight refactor, fix tag behaviour and add section tests
* test: update and add tests
* feat: update status behaviour
* feat: update subsection status tag
* refactor: linting
* [CLDC-857] Add household wheelchair check (#1122 )
* [CLDC-857] Add household wheelchair check
* Hide only if answered
* Cldc 1497 ever served armed forces (#1124 )
* feat: add question and page
* test: update tests
* refactor: linting and slight test updates
* test: fix tests
* Cldc 1498 still serving armed forces (#1123 )
* feat: new question and tests
* test: update subsection spec
* test: update tests
* feat: (future) conflict resolving
* feat: more conflict resolution
* feat: update db field
* test: update id
* test: updates
* Cldc 1488 last accomodation (#1125 )
* Add postcode fields
* Add previous postcode page and questions
* Add last accommodation page to household situation subsection
* add previous la known to the db
* infer correct location fields
* styling
* Reorder disability questions (#1127 )
* [CLDC-1487] Add buyer1 previous tenure question (#1133 )
* use collection_start_year instead of the startdate (#1128 )
* [CLDC-1487] Add buyer 1 previous tenure
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
* feat: fix routing (#1141 )
* Add last accommodation la question (#1142 )
* move hint text (#1146 )
Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com>
Co-authored-by: Jack S <113976590+bibblobcode@users.noreply.github.com>
2 years ago
kosiakkatrina
c994e67e69
Use dynamic ids for pages ( #1085 )
...
* Add income1_value_check column
* Use dynamic ids for pages
* Display Buyer1IncomeValueCheck twice
* Use id argument and pass in full IDs
* Remove accidental migration
2 years ago
kosiakkatrina
514552934d
Sales financial validations ( #1079 )
...
* Include shared validations in sales log model and run validate_numeric_min_max method
* Add non london hard max income validation
* Add london income validation
* Remove child vlidation because buyer cannot be a child
* Add income1_value_check column
* Add buyer_1_income_value_check question and page
* Update income1_under_soft_min?
* Add mortgage and value check column
* Add mortgage value check page
* Update mortgage_over_soft_max? in soft validateions
* Remove unused error message
2 years ago