submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	a4a83908ae	Refactor locations/index page (#2523 )	1 year ago
kosiakkatrina	905f869460	CLDC-2939 Link to organisations from user pages (#2489 ) * Link to organisations from user pages * Fix test	1 year ago
kosiakkatrina	1d1a7adbb2	Update UI libraries (#2125 ) * Update component versions * Update tables and header * Update govuk summary * More tweaks * lint * Update govuk-frontend * update layout file * include GovukVisuallyHiddenHelper in helpers * Update missed table body * More tests * update styling * Update @x-govuk/govuk-prototype-components * Do not set checkbox label sizes	2 years ago
Jack	56a9cb4bdf	CLDC-864 Add contract exchange date validations (#1231 ) * CLDC-864 Add exdate validations * Raise missing translation errors * Fix missing translation * Remove unused method * Remove redundant check	3 years ago
natdeanlewissoftwire	ecdc4d99c5	CLDC-1726 Update scheme and location display pages (#1190 ) * feat: update scheme and log displays * test: update tests * test: update tests	3 years ago
natdeanlewissoftwire	02c41333f6	Cldc 1669 add location redesign (#1034 ) * feat: wip postcode page * feat: wip add new flow * feat: add check answers page, continue updating flow * feat: add back behaviour * feat: more flow work * feat: further flow work and flash notice, name tidying * feat: add check_answers referrer linking * feat: add controller and details linking and lint * refactor: erblinting * feat: add local_authority page (currenlty separate from edit_local_authority to avoid conflict with add location to newly created scheme path, to be fixed later). also copy and routing updates * feat: add validations to controller (could later be added to model) * fix: correct date order * feat: validate on model (except startdate) * feat: copy update * refactor: railsification * feat: add date model validation * feat: add updated availability text in check_answers * feat: more updated dynamic text and linking * refactor: erblinting * refactor: cleanup of redundant code * refactor: remove redundant create * feat: use rails route * test: wip tests * test: wip tests * feat: add new back behaviour for new scheme path and tests wip * feat: add more back behaviour for new scheme path and fix local auth validation * feat: further linking behaviour with routes and referrers, don't add new location automatically to new schemes * feat: if location with no details added, route to normal path rather than check answers * test: update model and helper location tests * test: more test updates * test: more test updates and remove redundant files * test: remove redundant tests, add postcode test * test: add new #new tests * test: add test for all new controller methods * test: add more startdate tests * refactor: erblinting * test: fix failing tests * test: update scheme test * feat: respond to PR comments * feat: make postcode clear only if changed * feat: add _update methods * refactor: simplify validation and location_edit_path method * refactor: add helper method for action text * refactor: remove redundant logic * refactor: simplify routing * refactor: reintroduce location_params * refactor: use presence validation for postcode * refactor: use presence validation for la * feat: validate confirmed * tests: make tests pass with new startdate validation * WIP * refactor: simplify display attributes helpers and update tests * refactor: linting * feat: design change to save behaviour * test: fix failing tests * feat: location code copy tweak * refactor: remove redundant function * refactor: remove add_another_location and new location page * feat: simplify startdate validations to move to model, use scheme available_from date for in range validation * test: fix failing tests * refactor: linting * feat: remove name validation as a result of PO review * test: update tests * refactor: remove redundant context Co-authored-by: James Rose <james@jbpr.net>	3 years ago
natdeanlewissoftwire	9a51f7261c	Cldc 1390 la lookup fallback (#861 ) * feat: add la manual edit page * feat: make autocomplete accesible and la readable * feat: add correct skip and linking behaviour, also rename fallback page * feat: add page not found and tidy la list * feat: add redirection behaviour * feat: add coping with nil add_another_location query string * test: add postcodes mocks to return local authorities * feat: validate local authority to not be nil or "Select an option" * feat: persist add_another_location even on validation failure * feat: remove url query parsing, put validation before values added to db * refactor: spacing * tests: add new tests for edit-local-authority * tests: remove redundant bangs	3 years ago
kosiakkatrina	8e67c805f0	Cldc 1392 schemes list (#784 ) * shows incomplete tag if the scheme is not confirmed * displays a link to check answers page if the scheme is incomplete * return schemes with no location when searching * update tests * lint	3 years ago
J G	4afd3321eb	Small refactorings (#721 ) * location cell ref * extracted regex into initializer * extracted regex into initializer - part 2 * added PostcodeService to extract behavior * rubo * better test name * moved .delete.upcase to the PostcodeService class	3 years ago
J G	3aa7765194	Cldc 1292 permitted user can edit location name (#719 ) * added test to check locations * added test to click to change location * added edit name to routes and front * edit name request specs * finilised * tab nav helper test * specs for update * rubo	3 years ago
J G	5eac424384	CLDC-1337-permitted-user-can-add-location-when-creating-scheme (#704 ) * added last step * not finding postcode field * testing being direct to add locations page after submitting support questions * added route to locations controller * location controller spec * location controller * added template for new * next step in feature * added postcode * added name to locations * removed total units from schemes * moved total units to locations * changed type of unit type in db * using type of units * add locations page is finished * purged total units and added test for location create * creating location * testing creating location as data provider * fixed factory * refacotred update/create and added test creating location as a coord user * testing returning back to create page if create another location is selected * testing returning back to create page if create another location is selected - part 2 * thanks rubocop * thanks rubocop * testing back from new location * returned tests back * testing clickable locations link * testing clickable locations link under correct context * correctly looking table * table with caption * wip * fixed failing exisiting tests * fixed failing exisiting tests - part 2 * validating postcode case logs style * validating postcode specs * validating postcode specs debugger removed * navigation when editing location * spike creating new location after addition * small refactoring * added test to add another location from locations page * added test to amend a location * added test to amend a location - part 2 * testing location cell * added wheelchair adaptions to the unit tyupe * rebased * testing postcode missing * testing creating schem for a different org for coordinator * testing new scheme for a different org for coordinator * upcasing all postcodes before creation * testing edge cases around postcodes and yes or no for another location * create locations with support user * details locations specs * update locations specs * rubocop * checking raising error * fixed failed test * switched yes and no for wheelchairs * routes refactoring * fixed routing - WIP * further chanegs * feature tests passing * correct page when errros * redundant page * moving viewing locations away from schemes controller * new is fixed * create fixed * fixed locations specs * fixed tab nav specs * completed location specs * lint	3 years ago
J G	7815965af1	CLDC-1290 Permitted user can create a new scheme (#671 ) * added test to find link to create a new scheme * added button to create a new scheme * testing arriving to the new scheme form * non exsiting link to controller new action * SPIKEEEE * first page complete * posting to create * refactored scheme to enums * refactored new scheme page to use enums as well * views * SPIKE WIP * SPIKE WIP * SPIKE WIP * drawing list of scheme details * expanded on feature seeing more fields to fill in * expanded on feature seeing more fields to fill in 2nd page * refactored * working back buttons * working flash * more change in wip * default value for org * working spike * some spacing * filling answers * spike finished * correct name for details * testing fill in details * removed gem and further tests * Add has other client group field to schemes. Display it in the check answers. Fix tests and routing * remove details view and path Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * WIP change update paths * Implement changing answers (except the details one) * Add details page back for editing scheme details * added missing test for support questions and nested check answers under correct context * checking the back functionality * rubo and lint * checking the back functionality for primary gourp * checking the back functionality for confirm secondary * checking the back functionality for secondary group * checking the back functionality for support answers * checking the back functionality for returning to check answers from details page * checking the back functionality for returning to check answers from primary group page * checking the back functionality for secondary group confirm yes * checking the back functionality for secondary group confirm yes - fixed * checking the back functionality for secondary group * checking the back functionality for secondary group -fixed * checking the back functionality for returning from support page * Do not display secondary client group if the scheme doesn't have one * Add details path to schemes controller update method * Add more tests for back button * Add tests for new controller method * Add tests for creating schemes as data coordinator * fixed schema * added test for missing params when creating scheme * create for support user with or withotu required param * code to get controller render errors when required param is missing * code to implement correct validation * code to implement correct validation - part 2 * highlight missing field * doing silly dance to get correct field highlighted on the error * testing patch for schemes * testing patch for schemes - correct path * small refactoring * testing primary client group update via regular path * testing primary client group update via check answers page * testing confirm secondary group update with YES NO and returning from check answers page * testing updating secondary client group update and returning from check answers page * testing support answers and returning from check answers page * testing details and returning from check answers page * weird path when no names supplied * rubocop * lost in rebasing * started id to code refactoring * model specs remastered * fixed scheme controller specs * further refactorings * fixing feature schemes * final touches * removed code from db * remaining code purged * rubocop * included check for owning org field * checking for stock owning org selection * added stock owning org * added stock owning org on new page * added stock owning org to details * removed total units * managing related schems properly via Org * managing related schems properly via Org - rubocop * small refactoring * small refactoring - 2 * small refactoring - 3 * tests for owned_schemes and managed_schemes * rubocop * added tests for support user creating scheme * rubocop -a * tests for a primary-client-group * tests for a secondary-client-group * tests for a confirm-secondary-client-group * tests for a check-answers * tests for a details * rubocop * redundant action in controller * Trigger WF * switched to int for confirm * flashing test * flashing test for support user * flashing test rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	3 years ago
J G	ae377b9084	CLDC-1307 Cust Support and Coordinators can view the details of a service (#656 ) * added steps to view links to indiividual schemes * testing there are links to the schemes not just names * testing there are links to the schemes not just names -2 * added links failing due to no route * looks per spec * failing spec for tab helper * added new attributes to the scheme * added test for scheme.primary_client_group * testing clicking to individual scheme * empty template for show * testing users not signed in * testing I can see scheme details on the page * converting int to strings in scheme model * better view, seeds and factory * highlight supported housing for support user * simplified and extended sab nab logic * rubocop and redundant check removed * tests and code to make sure users are highlighted * tests and code to make sure supported housing is highlighted * full feature for support user to visit scheme show page * extended features and filing feature when coordinator viewing scheme for a different org * returning not found if coordinator user tries to see unrelated scheme * rubocop * fixed typos etc * fixed types for schemes * Trigger WF * correct expectation	3 years ago
J G	0aa46ca8be	Cldc 1275 organisations users page (#627 ) * added empty feature for viewing user specific organisation * refactored contexts in features * correctly failing feature * code to have user link * spec to test we are at correct sub menu for Users * added view for users view * edited text to pass remaining tests * fixed hidde3n field view * removed hidden field in the table * correct context * added extra field to test hidden content * test TabNavHelper with correct property * fixed tab highlights * spec for sub nav logs * spec for all sub menus * testing users inside org * better test for listing users * all test for search inside org users * pressing button * passing feature * better test with multiple orgs * almost done * fixed failing test * rubocop * expanded tests * typo * selecting subset due to null present in the list as well Co-authored-by: Ted <ted.booton@madetech.com>	3 years ago
Paul Robert Lloyd	97fb7439f2	Correct markup for user and organisation tables	3 years ago
kiddhustle	d1f01edb3b	git CLDC-1183: use email where no user name	4 years ago
Paul Robert Lloyd	3ecd1f2c6d	Make user names bold in users table	4 years ago
baarkerlounger	3acf1c65e2	CLDC-1117: Allow data providers to see but not edit users in their org (#442 ) * Allow data providers to see but not edit users in their org * Don't actually need octal literals	4 years ago
baarkerlounger	5013869c2b	User roles (#138 ) * Users have roles * Add role to active admin * Add role to users table * Redirect organisation show to details * Remove users tab for data providers	4 years ago

19 Commits (8c5a28a514e34c990e6302a6ad1e24848aba3cd9)