submit-social-housing-lettings-and-sales-data

2218 Commits

218 Branches

260 Tags

83 MiB

Tree: 90ce2656c3

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	9bbc2c2e17	CLDC-1687 allow deactivation or reactivation of last year schemes and locations in crossover period (#1396 ) * create method to test whether we are currently in the crossover period and associated tests * update copy, use method for testing whether we are in the crossover period, remove focus from test file * reuse existing method to determine whether we are in a collection period * use the existing method and update validations * fix test broken by changes * update location in same way as scheme * create method on FormHandler that finds the start date of the earliest collection period * ensure that default deactivation and reactivation dates also reflect the changes * create tests for the new validations * lint correction * minor copy change * minor logic change * amend naming error after rebase conflict remove test that is no longer correct after change on another branch to functionality update a test after a copy change	2 years ago
kosiakkatrina	11bb9c887c	Cldc 1670 reactivate locations (#1007 ) * route deactivated scheme to reactivation page * Render correct reactivate question content * refactor into a helper * display successful reactivation banner for default date * Save reactivation date * Add reactivation errors * lint and fix url in tests * make toggle translations generic * Add reactivation status * Reuse date validation messages * Show deactivate this location when location is reactivating soon * Display correct confirmation banner * Add validation for reactivation date before deactivation date * Improve availability label * Use current collection start date if created at is later than that * Update paths * Fix controller and don't display the previous day if location availability start afterwards * refactor availability label * Filter out active periods * lint * Refactor active_period method into the model * Allow deactivations and reactivations from available from date instead of start of the collection date * Prevent deactivations during deactivated periods * lint * typo * Remove active periods that last 1 day (because they get deactivated on the same day) * Move the active_periods into helper * extract remove_overlapping_and_empty_periods into a separate method * Remove nested deactivation periods * Make deactivate/reactvate location form use location_deactivation_period model * refactor toggle date methods * extract shared condition * update validations * refactor validations * Update schemes deactivation form to use dectivation model * Refactor * lint * remove redundant location_id and update scheme controller * update active_periods	2 years ago
kosiakkatrina	96c792b472	Cldc 1668 multiple location deactivations (#996 ) * Add location_deactivations table and remove deactivation_date from locations * Add location location_deactivations relationship * Update logs status determination for location * Update affected logs with deactivated location. * lint * Update scheme * Extract location_deactivation factory * Update location availability * lint * Rename deactivations table * fix schema * rebase fixes * fixes * refactor	2 years ago

Author

SHA1

Message

Date

Arthur Campbell

9bbc2c2e17

CLDC-1687 allow deactivation or reactivation of last year schemes and locations in crossover period (#1396 )

* create method to test whether we are currently in the crossover period and associated tests

* update copy, use method for testing whether we are in the crossover period, remove focus from test file

* reuse existing method to determine whether we are in a collection period

* use the existing method and update validations

* fix test broken by changes

* update location in same way as scheme

* create method on FormHandler that finds the start date of the earliest collection period

* ensure that default deactivation and reactivation dates also reflect the changes

* create tests for the new validations

* lint correction

* minor copy change

* minor logic change

* amend naming error after rebase conflict
remove test that is no longer correct after change on another branch to functionality
update a test after a copy change

2 years ago

kosiakkatrina

11bb9c887c

Cldc 1670 reactivate locations (#1007 )

* route deactivated scheme to reactivation page

* Render correct reactivate question content

* refactor into a helper

* display successful reactivation banner for default date

* Save reactivation date

* Add reactivation errors

* lint and fix url in tests

* make toggle translations generic

* Add reactivation status

* Reuse date validation messages

* Show deactivate this location when location is reactivating soon

* Display correct confirmation banner

* Add validation for reactivation date before deactivation date

* Improve availability label

* Use current collection start date if created at is later than that

* Update paths

* Fix controller and don't display the previous day if location availability start afterwards

* refactor availability label

* Filter out active periods

* lint

* Refactor active_period method into the model

* Allow deactivations and reactivations from available from date instead of start of the collection date

* Prevent deactivations during deactivated periods

* lint

* typo

* Remove active periods that last 1 day (because they get deactivated on the same day)

* Move the active_periods into helper

* extract remove_overlapping_and_empty_periods into a separate method

* Remove nested deactivation periods

* Make deactivate/reactvate location form use location_deactivation_period model

* refactor toggle date methods

* extract shared condition

* update validations

* refactor validations

* Update schemes deactivation form to use dectivation model

* Refactor

* lint

* remove redundant location_id and update scheme controller

* update active_periods

2 years ago

kosiakkatrina

96c792b472

Cldc 1668 multiple location deactivations (#996 )

* Add location_deactivations table and remove deactivation_date from locations

* Add location location_deactivations relationship

* Update logs status determination for location

* Update affected logs with deactivated location.

* lint

* Update scheme

* Extract location_deactivation factory

* Update location availability

* lint

* Rename deactivations table

* fix schema

* rebase fixes

* fixes

* refactor

2 years ago

3 Commits (90ce2656c390053bb98c3daa63c60f0bc05bc693)